mirror of
https://github.com/immich-app/immich.git
synced 2026-03-22 23:29:00 +03:00
fix: use pnpm build without install for base and ensure dirs exist
- Remove pnpm install from base build steps since it modifies the workspace lockfile and can break tsx/other deps used by later steps - Just run pnpm build using the existing node_modules from the PR install - Ensure screenshot directories exist before compare step runs https://claude.ai/code/session_01XSTqDJXuR4jaLN7SGm3uES
This commit is contained in:
6
.github/workflows/visual-review.yml
vendored
6
.github/workflows/visual-review.yml
vendored
@@ -205,14 +205,14 @@ jobs:
|
||||
if: steps.routes.outputs.has_routes == 'true'
|
||||
continue-on-error: true
|
||||
id: base-sdk
|
||||
run: pnpm install && pnpm build
|
||||
run: pnpm build
|
||||
working-directory: ./open-api/typescript-sdk
|
||||
|
||||
- name: Build web (base)
|
||||
if: steps.routes.outputs.has_routes == 'true' && steps.base-sdk.outcome == 'success'
|
||||
continue-on-error: true
|
||||
id: base-web
|
||||
run: pnpm install && pnpm build
|
||||
run: pnpm build
|
||||
working-directory: ./web
|
||||
|
||||
- name: Take screenshots (base)
|
||||
@@ -250,6 +250,8 @@ jobs:
|
||||
WORKSPACE_DIR: ${{ github.workspace }}
|
||||
IMAGE_BASE_URL: https://raw.githubusercontent.com/${{ github.repository }}/visual-review/pr-${{ github.event.pull_request.number }}
|
||||
run: |
|
||||
# Ensure directories exist even if base screenshots were skipped
|
||||
mkdir -p "$WORKSPACE_DIR/screenshots/base" "$WORKSPACE_DIR/screenshots/pr" "$WORKSPACE_DIR/screenshots/diff"
|
||||
pnpm exec tsx src/screenshots/compare.ts \
|
||||
"$WORKSPACE_DIR/screenshots/base" \
|
||||
"$WORKSPACE_DIR/screenshots/pr" \
|
||||
|
||||
Reference in New Issue
Block a user