From fe4c0a95d53a1e706f659402c942d3780d44daa1 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sun, 1 Mar 2026 19:47:19 +0000
Subject: [PATCH] fix: use pnpm build without install for base and ensure dirs
 exist

- Remove pnpm install from base build steps since it modifies the workspace
  lockfile and can break tsx/other deps used by later steps
- Just run pnpm build using the existing node_modules from the PR install
- Ensure screenshot directories exist before compare step runs

https://claude.ai/code/session_01XSTqDJXuR4jaLN7SGm3uES
---
 .github/workflows/visual-review.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/visual-review.yml b/.github/workflows/visual-review.yml
index 8806fcceba..74394eb677 100644
--- a/.github/workflows/visual-review.yml
+++ b/.github/workflows/visual-review.yml
@@ -205,14 +205,14 @@ jobs:
         if: steps.routes.outputs.has_routes == 'true'
         continue-on-error: true
         id: base-sdk
-        run: pnpm install && pnpm build
+        run: pnpm build
         working-directory: ./open-api/typescript-sdk
 
       - name: Build web (base)
         if: steps.routes.outputs.has_routes == 'true' && steps.base-sdk.outcome == 'success'
         continue-on-error: true
         id: base-web
-        run: pnpm install && pnpm build
+        run: pnpm build
         working-directory: ./web
 
       - name: Take screenshots (base)
@@ -250,6 +250,8 @@ jobs:
           WORKSPACE_DIR: ${{ github.workspace }}
           IMAGE_BASE_URL: https://raw.githubusercontent.com/${{ github.repository }}/visual-review/pr-${{ github.event.pull_request.number }}
         run: |
+          # Ensure directories exist even if base screenshots were skipped
+          mkdir -p "$WORKSPACE_DIR/screenshots/base" "$WORKSPACE_DIR/screenshots/pr" "$WORKSPACE_DIR/screenshots/diff"
           pnpm exec tsx src/screenshots/compare.ts \
             "$WORKSPACE_DIR/screenshots/base" \
             "$WORKSPACE_DIR/screenshots/pr" \