github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-22 14:09:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: add tsx dependency and fix workflow step ordering

Browse Source 
- Add tsx as an e2e devDependency (was missing, causing silent failures)
- Replace `npx tsx` with `pnpm exec tsx` throughout
- Move `pnpm install` before `playwright install` (correct ordering)
- Remove `2>/dev/null` that was hiding analyzer errors
- Add debug logging to route analysis step
- Set default working-directory for the job

https://claude.ai/code/session_01XSTqDJXuR4jaLN7SGm3uES
This commit is contained in:
Claude
2026-02-26 13:59:20 +00:00
committed by Zack Pollard
parent 028c8a2276
commit 23e3d43578
3 changed files with 24 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
.github/workflows/visual-review.yml vendored
View File

@@ -16,6 +16,9 @@ jobs:
permissions:
contents: read
pull-requests: write
defaults:
run:
working-directory: ./e2e
steps:
- id: token
uses: immich-app/devtools/actions/create-workflow-token@05e16407c0a5492138bb38139c9d9bf067b40886 # create-workflow-token-action-v1.0.1
@@ -40,9 +43,11 @@ jobs:
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- name: Install e2e dependencies
run: pnpm install --frozen-lockfile
- name: Install Playwright
run: pnpm exec playwright install chromium --only-shell
working-directory: ./e2e
- name: Determine changed web files
id: changed-files
@@ -55,7 +60,6 @@ jobs:
echo "$CHANGED" >> "$GITHUB_OUTPUT"
echo "EOF" >> "$GITHUB_OUTPUT"
# Check if there are any web changes at all
if [ -z "$CHANGED" ]; then
echo "has_changes=false" >> "$GITHUB_OUTPUT"
else
@@ -68,11 +72,12 @@ jobs:
env:
CHANGED_FILES: ${{ steps.changed-files.outputs.files }}
run: |
# Install dependencies for the analyzer
pnpm install --frozen-lockfile
# Run the dependency analyzer
ROUTES=$(echo "$CHANGED_FILES" | xargs npx tsx src/screenshots/analyze-deps.ts 2>/dev/null | grep "^ /" | sed 's/^ //' || true)
echo "Changed files:"
echo "$CHANGED_FILES"
echo "---"
ROUTES=$(echo "$CHANGED_FILES" | xargs pnpm exec tsx src/screenshots/analyze-deps.ts 2>&1 | tee /dev/stderr | grep "^ /" | sed 's/^ //' || true)
echo "routes<<EOF" >> "$GITHUB_OUTPUT"
echo "$ROUTES" >> "$GITHUB_OUTPUT"
@@ -84,15 +89,15 @@ jobs:
echo "has_routes=true" >> "$GITHUB_OUTPUT"
# Build the scenario filter JSON array
SCENARIO_NAMES=$(npx tsx -e "
SCENARIO_NAMES=$(pnpm exec tsx -e "
import { getScenariosForRoutes } from './src/screenshots/page-map.ts';
const routes = process.argv.slice(1);
const scenarios = getScenariosForRoutes(routes);
console.log(JSON.stringify(scenarios.map(s => s.name)));
" $ROUTES)
echo "scenarios=$SCENARIO_NAMES" >> "$GITHUB_OUTPUT"
echo "Scenarios: $SCENARIO_NAMES"
fi
working-directory: ./e2e
- name: Post initial comment
if: steps.changed-files.outputs.has_changes == 'true' && steps.routes.outputs.has_routes == 'true'
@@ -152,6 +157,7 @@ jobs:
# Wait for server to be ready
for i in $(seq 1 30); do
if curl -s http://127.0.0.1:4173 > /dev/null 2>&1; then
echo "Server ready after ${i}s"
break
fi
sleep 1
@@ -162,7 +168,6 @@ jobs:
# Stop the preview server
kill $SERVER_PID 2>/dev/null || true
working-directory: ./e2e
# === Screenshot base version ===
- name: Checkout base web directory
@@ -172,6 +177,7 @@ jobs:
run: |
# Restore web directory from base branch
git checkout "$BASE_SHA" -- web/ open-api/typescript-sdk/ i18n/ || true
working-directory: .
- name: Build SDK (base)
if: steps.routes.outputs.has_routes == 'true'
@@ -198,6 +204,7 @@ jobs:
# Wait for server to be ready
for i in $(seq 1 30); do
if curl -s http://127.0.0.1:4173 > /dev/null 2>&1; then
echo "Server ready after ${i}s"
break
fi
sleep 1
@@ -208,7 +215,6 @@ jobs:
# Stop the preview server
kill $SERVER_PID 2>/dev/null || true
working-directory: ./e2e
# === Compare and report ===
- name: Compare screenshots
@@ -217,11 +223,10 @@ jobs:
env:
WORKSPACE_DIR: ${{ github.workspace }}
run: |
npx tsx src/screenshots/compare.ts \
pnpm exec tsx src/screenshots/compare.ts \
"$WORKSPACE_DIR/screenshots/base" \
"$WORKSPACE_DIR/screenshots/pr" \
"$WORKSPACE_DIR/screenshots/diff"
working-directory: ./e2e
- name: Upload screenshot artifacts
if: steps.routes.outputs.has_routes == 'true'
@@ -244,15 +249,12 @@ jobs:
const workspaceDir = process.env.WORKSPACE_DIR;
const diffDir = path.join(workspaceDir, 'screenshots', 'diff');
const baseDir = path.join(workspaceDir, 'screenshots', 'base');
const prDir = path.join(workspaceDir, 'screenshots', 'pr');
// Read comparison results
let results;
try {
results = JSON.parse(fs.readFileSync(path.join(diffDir, 'results.json'), 'utf8'));
} catch {
// Post a simple message if comparison failed
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
@@ -310,7 +312,7 @@ jobs:
});
const botComment = comments.data.find(c =>
c.body && c.body.includes('## Visual Review') && c.body.includes('visual-review')
c.body && c.body.includes('## Visual Review')
);
if (botComment) {

5
e2e/package.json
View File

@@ -20,8 +20,8 @@
"lint:fix": "pnpm run lint --fix",
"check": "tsc --noEmit",
"screenshots": "pnpm exec playwright test --config playwright.screenshot.config.ts",
"screenshots:compare": "npx tsx src/screenshots/compare.ts",
"screenshots:analyze": "npx tsx src/screenshots/analyze-deps.ts"
"screenshots:compare": "pnpm exec tsx src/screenshots/compare.ts",
"screenshots:analyze": "pnpm exec tsx src/screenshots/analyze-deps.ts"
},
"keywords": [],
"author": "",
@@ -54,6 +54,7 @@
"sharp": "^0.34.5",
"socket.io-client": "^4.7.4",
"supertest": "^7.0.0",
"tsx": "^4.21.0",
"typescript": "^5.3.3",
"typescript-eslint": "^8.28.0",
"utimes": "^5.2.1",

3
pnpm-lock.yaml generated
View File

@@ -276,6 +276,9 @@ importers:
supertest:
specifier: ^7.0.0
version: 7.2.2
tsx:
specifier: ^4.21.0
version: 4.21.0
typescript:
specifier: ^5.3.3
version: 5.9.3