Merge pull request #96 from mnasiadka/ansible_facts_distribution

Change ansible_distribution usage to ansible_facts

.ansible-lint

@@ -0,0 +1 @@
+skip_list: []

.flake8

@@ -0,0 +1,3 @@
+[flake8]
+exclude = .venv/
+max-line-length = 88

.github/config.yml

@@ -0,0 +1,14 @@
+# Configuration for request-info - https://github.com/behaviorbot/request-info
+
+# *Required* Comment to reply with
+requestInfoReplyComment: >
+  We would appreciate it if you could provide us with more info about this issue/pr!
+
+# *OPTIONAL* default titles to check against for lack of descriptiveness
+# MUST BE ALL LOWERCASE
+requestInfoDefaultTitles:
+  - update readme.md
+  - updates
+
+# *OPTIONAL* Label to be added to Issues and Pull Requests with insufficient information given
+requestInfoLabelToAdd: needs-more-info

.github/release-drafter.yml

@@ -0,0 +1,32 @@
+name-template: "v$RESOLVED_VERSION 🌈"
+tag-template: "v$RESOLVED_VERSION"
+categories:
+  - title: "🚀 Features"
+    labels:
+      - "feature"
+      - "enhancement"
+  - title: "🐛 Bug Fixes"
+    labels:
+      - "fix"
+      - "bugfix"
+      - "bug"
+  - title: "🧰 Maintenance"
+    label: "chore"
+  - title: "🧺 Miscellaneous" #Everything except ABAP
+    label: "misc"
+change-template: "- $TITLE @$AUTHOR (#$NUMBER)"
+change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
+version-resolver:
+  major:
+    labels:
+      - "major"
+  minor:
+    labels:
+      - "minor"
+  patch:
+    labels:
+      - "patch"
+  default: patch
+template: |
+  ## Changes
+  $CHANGES

.github/settings.yml

@@ -0,0 +1,10 @@
+# These settings are synced to GitHub by https://probot.github.io/apps/settings/
+
+repository:
+  # See https://developer.github.com/v3/repos/#edit for all available settings.
+
+  # The name of the repository. Changing this will rename the repository
+  name: ansible-manage-lvm
+
+  # A short description of the repository that will show up on GitHub
+  description: Ansible role to manage LVM Groups/Logical Volumes

.github/stale.yml

@@ -0,0 +1,17 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - pinned
+  - security
+# Label to use when marking an issue as stale
+staleLabel: wontfix
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

.github/workflows/molecule.yml

@@ -1,41 +1,46 @@
 ---
-
-# This is a basic workflow to help you get started with Actions
-
 name: Molecule
-
-# Controls when the action will run. Triggers the workflow on push or pull request
-# events but only for the master branch
 on:
   push:
+    branches-ignore:
+      - main
+      - master
   pull_request:
     branches:
+      - develop
+      - main
       - master
-      - tags/*
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
-
   lint:
     # The type of runner that the job will run on
-    runs-on: ubuntu-latest
+    runs-on: macos-10.15
+    strategy:
+      fail-fast: false
+      max-parallel: 4
+      matrix:
+        python-version: [3.8]
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v2
-
-      - name: install lint prerequisite
+        with:
+          submodules: recursive
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/cache@v2
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+      - name: Install dependencies
         run: |
-          sudo apt -y install python3-setuptools ansible-lint
-
-      - name: Install molecule
-        run: |
-          sudo apt update
-          sudo apt -y install python3-setuptools python3 python3-pip docker vagrant
-          sudo pip3 install wheel
-          sudo pip3 install molecule testinfra yamllint ansible-lint flake8 molecule-vagrant
-
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt -r requirements-dev.txt
       - name: molecule lint
         run: |
           molecule lint

.github/workflows/release-drafter.yml

@@ -0,0 +1,17 @@
+name: Release Drafter
+
+on:
+  push:
+    # branches to consider in the event; optional, defaults to all
+    branches:
+      - main
+      - master
+
+jobs:
+  update_release_draft:
+    runs-on: ubuntu-latest
+    steps:
+      # Drafts your next Release notes as Pull Requests are merged into "master"
+      - uses: release-drafter/release-drafter@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release-galaxy.yml

@@ -0,0 +1,34 @@
+---
+name: Ansible Galaxy
+on:
+  push:
+    branches:
+      - main
+      - master
+  release:
+    types:
+      - published
+
+jobs:
+  galaxy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/cache@v2
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt -r requirements-dev.txt
+      - name: Trigger a new import on Galaxy.
+        run: ansible-galaxy role import --api-key ${{ secrets.GALAXY_API_KEY }} $(echo ${{ github.repository }} | cut -d/ -f1) $(echo ${{ github.repository }} | cut -d/ -f2)

.gitignore

@@ -1,3 +1,3 @@
 .idea
 **/__pycache__
-venv/
+.venv/

.travis.yml

@@ -26,5 +26,7 @@ before_install:
 script:
   - |
     sudo molecule test --scenario-name kvm
+    sudo molecule test --scenario-name kvmsinglelv
+    sudo molecule test --scenario-name kvmonlyvg
 notifications:
   webhooks: https://galaxy.ansible.com/api/v1/notifications/

.yamllint.yml

@@ -3,7 +3,7 @@
 extends: default
 
 ignore: |
-  venv/
+  .venv/
 
 rules:
   braces:

defaults/main.yml

@@ -61,3 +61,17 @@ lvm_groups: []
 # Defines if LVM will be managed by role
 # default is false to ensure nothing is changed by accident.
 manage_lvm: false
+
+###     nvme to scsi device name map binary helper
+ebsnvme_binary_helper_ver: '0.1.3'
+ebsnvme_binary_helper_tmp: '/tmp'
+ebsnvme_binary_helper_path: '/sbin/go-ebsnvme'
+
+###     nvme to scsi device name map script helper
+ebsnvme_scrip_helper_path: '/usr/local/bin/ebsnvme-id'
+
+###     auto pvresize (waiting until ansible 2.10 or above as collections have new lvg with integrated pvresize)
+###     waiting for new module in collection set to true or run pvresize manually on remote systems
+###     https://docs.ansible.com/ansible/3/collections/community/general/lvg_module.html
+###
+pvresize_to_max: false

meta/main.yml

@@ -2,6 +2,8 @@
 galaxy_info:
   author: Larry Smith Jr.
   description: Ansible role to manage(create, extend, resize) LVM Groups/Logical Volumes.
+  namespace: mrlesmithjr
+  role_name: manage-lvm
 
   license: MIT
   min_ansible_version: 1.2

molecule/default/converge.yml

@@ -15,7 +15,7 @@
             filesystem: ext4
             mount: true
             mntp: "/var/lib/mountpoint"
-          - lvname: my_lv2
+          - lvname: my_lw
             size: 20%VG
             opts: "--wipesignatures y"
             mount: true

molecule/default/molecule.yml

@@ -3,7 +3,10 @@ driver:
   name: vagrant
   provider:
     name: virtualbox
-lint: yamllint . && flake8 && ansible-lint
+lint: |
+  yamllint .
+  ansible-lint
+  flake8
 platforms:
   - name: CentOS-Molecule-LVM
     box: mrlesmithjr/centos7

molecule/default/tests/test_default.py

@@ -18,6 +18,13 @@ def test_mylv_logical_volume_is_created(host):
     assert int(cmd.stdout.rstrip()) >= 1
 
 
+def test_mylv_logical_volume2_is_created(host):
+    command = """sudo lvs -o lv_name  my_vg --separator='|' --noheadings \
+    | grep -c 'my_lw'"""
+    cmd = host.run(command)
+    assert int(cmd.stdout.rstrip()) >= 1
+
+
 def test_volume_is_mounted(host):
     host.file("/var/lib/mountpoint").mode == 0o731
 

molecule/kvm/converge.yml

@@ -15,7 +15,7 @@
             filesystem: ext4
             mount: true
             mntp: "/var/lib/mountpoint"
-          - lvname: my_lv2
+          - lvname: my_lw
             size: 20%VG
             opts: "--wipesignatures y"
             mount: true

molecule/kvmonlyvg/converge.yml

@@ -0,0 +1,14 @@
+---
+- name: Converge
+  hosts: all
+  vars:
+    lvm_groups:
+      - vgname: my_vg
+        disks:
+          - /dev/vdb
+        create: true
+    manage_lvm: true
+  tasks:
+    - name: "Include lvm"
+      include_role:
+        name: "ansible-manage-lvm"

molecule/kvmonlyvg/molecule.yml

@@ -0,0 +1,29 @@
+---
+driver:
+  name: vagrant
+  provider:
+    name: libvirt
+lint: yamllint . && flake8 && ansible-lint
+platforms:
+  - name: Fedora-Molecule-Volumes-KVM
+    box: fedora/31-cloud-base
+    cpu: 2
+    memory: 2048
+    provider_raw_config_args:
+      - "storage :file, :size => '1G', :device => 'vdb'"
+provisioner:
+  name: ansible
+  config_options:
+    defaults:
+      forks: 20
+    ssh_connection:
+      pipelining: true
+      ssh_args: -o ControlMaster=auto -o ControlPersist=600s
+verifier:
+  name: testinfra
+  env:
+    PYTHONWARNINGS: "ignore:.*U.*mode is deprecated:DeprecationWarning"
+  options:
+    v: 1
+scenario:
+  name: kvmonlyvg

molecule/kvmonlyvg/tests/conftest.py

@@ -0,0 +1 @@
+../../default/tests/conftest.py

molecule/kvmonlyvg/tests/test_default.py

@@ -0,0 +1,11 @@
+"""Role testing files using testinfra."""
+
+
+def test_lvm_package_shall_be_installed(host):
+    assert host.package("lvm2").is_installed
+
+
+def test_non_persistent_volume_group_is_created(host):
+    command = """sudo vgdisplay | grep -c 'my_vg'"""
+    cmd = host.run(command)
+    assert '1' in cmd.stdout

molecule/kvmsinglelv/converge.yml

@@ -0,0 +1,22 @@
+---
+- name: Converge
+  hosts: all
+  vars:
+    lvm_groups:
+      - vgname: my_vg
+        disks:
+          - /dev/vdb
+        create: true
+        lvnames:
+          - lvname: my_lv
+            size: 40%VG
+            opts: "--wipesignatures y"
+            create: true
+            filesystem: ext4
+            mount: true
+            mntp: "/var/lib/mountpoint"
+    manage_lvm: true
+  tasks:
+    - name: "Include lvm"
+      include_role:
+        name: "ansible-manage-lvm"

molecule/kvmsinglelv/molecule.yml

@@ -0,0 +1,29 @@
+---
+driver:
+  name: vagrant
+  provider:
+    name: libvirt
+lint: yamllint . && flake8 && ansible-lint
+platforms:
+  - name: Fedora-Molecule-Volumes-KVM
+    box: fedora/31-cloud-base
+    cpu: 2
+    memory: 2048
+    provider_raw_config_args:
+      - "storage :file, :size => '1G', :device => 'vdb'"
+provisioner:
+  name: ansible
+  config_options:
+    defaults:
+      forks: 20
+    ssh_connection:
+      pipelining: true
+      ssh_args: -o ControlMaster=auto -o ControlPersist=600s
+verifier:
+  name: testinfra
+  env:
+    PYTHONWARNINGS: "ignore:.*U.*mode is deprecated:DeprecationWarning"
+  options:
+    v: 1
+scenario:
+  name: kvmsinglelv

molecule/kvmsinglelv/tests/conftest.py

@@ -0,0 +1 @@
+../../default/tests/conftest.py

molecule/kvmsinglelv/tests/test_default.py

@@ -0,0 +1,22 @@
+"""Role testing files using testinfra."""
+
+
+def test_lvm_package_shall_be_installed(host):
+    assert host.package("lvm2").is_installed
+
+
+def test_non_persistent_volume_group_is_created(host):
+    command = """sudo vgdisplay | grep -c 'my_vg'"""
+    cmd = host.run(command)
+    assert '1' in cmd.stdout
+
+
+def test_mylv_logical_volume_is_created(host):
+    command = """sudo lvs -o lv_name  my_vg --separator='|' --noheadings \
+    | grep -c 'my_lv'"""
+    cmd = host.run(command)
+    assert int(cmd.stdout.rstrip()) >= 1
+
+
+def test_volume_is_mounted(host):
+    host.file("/var/lib/mountpoint").mode == 0o731

pyproject.toml

@@ -0,0 +1,30 @@
+[tool.poetry]
+name = "ansible-manage-lvm"
+version = "0.1.0"
+description = ""
+authors = ["Larry Smith Jr. <mrlesmithjr@gmail.com>"]
+
+[tool.poetry.dependencies]
+python = "^3.10"
+ansible = "4.2.0"
+
+[tool.poetry.dev-dependencies]
+bandit = "^1.7.1"
+black = "^21.11b1"
+flake8 = "^4.0.1"
+mypy = "^0.910"
+poetry = "^1.1.11"
+pylint = "^2.11.1"
+ansible-lint = "4.2.0"
+yamllint = "1.23.0"
+mkdocs = "^1.2.3"
+autopep8 = "^1.6.0"
+pycodestyle = "^2.8.0"
+pip-tools = "^6.4.0"
+molecule = "3.0.3"
+molecule-vagrant = "0.2"
+pre-commit = "^2.15.0"
+
+[build-system]
+requires = ["poetry-core>=1.0.0"]
+build-backend = "poetry.core.masonry.api"

requirements-dev.txt

@@ -1,66 +1,114 @@
-ansible==2.9.7
-ansible-lint==4.2.0
-arrow==0.15.5
-attrs==19.3.0
-bcrypt==3.1.7
-binaryornot==0.4.4
-Cerberus==1.3.2
-certifi==2020.4.5.1
-cffi==1.14.0
-chardet==3.0.4
-click==7.1.1
-click-completion==0.5.2
-click-help-colors==0.8
-colorama==0.4.3
-cookiecutter==1.7.0
-cryptography==2.9
-distro==1.5.0
-docker==4.2.0
-entrypoints==0.3
-fasteners==0.15
-flake8==3.7.9
-future==0.18.2
-idna==2.9
-importlib-metadata==1.6.0
-Jinja2==2.11.2
-jinja2-time==0.2.0
-MarkupSafe==1.1.1
-mccabe==0.6.1
-molecule==3.0.3
-molecule-vagrant==0.2
-monotonic==1.5
-more-itertools==8.2.0
-packaging==20.3
-paramiko==2.7.1
-pathspec==0.8.0
-pexpect==4.8.0
-pluggy==0.13.1
-poyo==0.5.0
-ptyprocess==0.6.0
-py==1.8.1
-pycodestyle==2.5.0
-pycparser==2.20
-pyflakes==2.1.1
-PyNaCl==1.3.0
-pyparsing==2.4.7
-pytest==5.4.1
-python-dateutil==2.8.1
-python-gilt==1.2.3
-python-vagrant==0.5.15
-PyYAML==5.3.1
-requests==2.23.0
-ruamel.yaml==0.16.10
-ruamel.yaml.clib==0.2.0
-selinux==0.2.1
-sh==1.12.14
-shellingham==1.3.2
-six==1.14.0
-tabulate==0.8.7
-testinfra==5.0.0
-tree-format==0.1.2
-urllib3==1.25.9
-wcwidth==0.1.9
-websocket-client==0.57.0
-whichcraft==0.6.1
-yamllint==1.23.0
-zipp==3.1.0
+ansible-core==2.11.6; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+ansible-lint==4.2.0; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+ansible==4.2.0; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+arrow==1.2.1; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+astroid==2.8.6; python_version >= "3.6" and python_version < "4.0"
+autopep8==1.6.0
+backports.entry-points-selectable==1.1.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "2.7"
+bandit==1.7.1; python_version >= "3.5"
+bcrypt==3.2.0; python_version >= "3.6"
+binaryornot==0.4.4; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+black==21.11b1; python_full_version >= "3.6.2"
+cachecontrol==0.12.10; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+cachy==0.3.0; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+cerberus==1.3.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+certifi==2021.10.8; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.6.0"
+cffi==1.15.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+cfgv==3.3.1; python_full_version >= "3.6.1"
+chardet==4.0.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+charset-normalizer==2.0.7; python_full_version >= "3.6.0" and python_version >= "3"
+cleo==0.8.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+click-completion==0.5.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+click-help-colors==0.9.1; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+click==8.0.3; python_version >= "3.6" and python_full_version >= "3.6.2" and (python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6")
+clikit==0.6.2; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+colorama==0.4.4; platform_system == "Windows" and python_version >= "3.6" and python_full_version >= "3.6.2" and python_version < "4.0" and sys_platform == "win32" and (python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6")
+cookiecutter==1.7.3; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+crashtest==0.3.1; python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0")
+cryptography==36.0.0; python_version >= "3.6" and python_full_version < "3.0.0" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0") and sys_platform == "linux" or python_full_version >= "3.5.0" and python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0") and sys_platform == "linux"
+distlib==0.3.3; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+distro==1.6.0; python_version >= "3.6" and python_full_version < "3.0.0" and sys_platform == "linux" or python_version >= "3.6" and python_full_version < "3.0.0" and sys_platform == "linux2" or sys_platform == "linux" and python_version >= "3.6" and python_full_version >= "3.4.0" or sys_platform == "linux2" and python_version >= "3.6" and python_full_version >= "3.4.0"
+fasteners==0.16.3; python_version >= "3.6"
+filelock==3.4.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+flake8==4.0.1; python_version >= "3.6"
+ghp-import==2.0.2; python_version >= "3.6"
+gitdb==4.0.9; python_version >= "3.7"
+gitpython==3.1.24; python_version >= "3.7"
+html5lib==1.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+identify==2.4.0; python_full_version >= "3.6.1"
+idna==3.3; python_version >= "3.5" and python_full_version < "3.0.0" or python_full_version >= "3.6.0" and python_version >= "3.5"
+importlib-metadata==4.8.2; python_version >= "3.6"
+isort==5.10.1; python_full_version >= "3.6.1" and python_version < "4.0" and python_version >= "3.6"
+jeepney==0.7.1; python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0") and sys_platform == "linux"
+jinja2-time==0.2.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+jinja2==3.0.3; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+keyring==21.8.0; python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0")
+lazy-object-proxy==1.6.0; python_version >= "3.6" and python_full_version < "3.0.0" and python_version < "4.0" or python_version >= "3.6" and python_version < "4.0" and python_full_version >= "3.6.0"
+lockfile==0.12.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+markdown==3.3.6; python_version >= "3.6"
+markupsafe==2.0.1; python_version >= "3.6"
+mccabe==0.6.1; python_version >= "3.6" and python_version < "4.0"
+mergedeep==1.3.4; python_version >= "3.6"
+mkdocs==1.2.3; python_version >= "3.6"
+molecule-vagrant==0.2; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+molecule==3.0.3; python_version >= "3.6"
+msgpack==1.0.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+mypy-extensions==0.4.3; python_full_version >= "3.6.2" and python_version >= "3.5"
+mypy==0.910; python_version >= "3.5"
+nodeenv==1.6.0; python_full_version >= "3.6.1"
+packaging==20.9; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+paramiko==2.8.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pastel==0.2.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+pathspec==0.9.0; python_full_version >= "3.6.2" and python_version >= "3.6"
+pbr==5.8.0; python_version >= "3.6"
+pep517==0.12.0; python_version >= "3.6"
+pexpect==4.8.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pip-tools==6.4.0; python_version >= "3.6"
+pkginfo==1.8.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+platformdirs==2.4.0; python_version >= "3.6" and python_full_version >= "3.6.2" and python_version < "4.0" and (python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6")
+pluggy==0.13.1; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+poetry-core==1.0.7; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+poetry==1.1.11; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+poyo==0.5.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pre-commit==2.15.0; python_full_version >= "3.6.1"
+ptyprocess==0.7.0; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+pycodestyle==2.8.0; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+pycparser==2.21; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pyflakes==2.4.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.4.0" and python_version >= "3.6"
+pylev==1.4.0; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+pylint==2.11.1; python_version >= "3.6" and python_version < "4.0"
+pynacl==1.4.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.4.0" and python_version >= "3.6"
+pyparsing==3.0.6; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+python-dateutil==2.8.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+python-gilt==1.2.3; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+python-slugify==5.0.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+python-vagrant==0.5.15; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+pywin32-ctypes==0.2.0; python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0") and sys_platform == "win32"
+pyyaml-env-tag==0.1; python_version >= "3.6"
+pyyaml==5.4.1; python_full_version >= "3.6.1" and python_version >= "3.6" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.6.0") and (python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.6.0" and python_version >= "3.6")
+regex==2021.11.10; python_full_version >= "3.6.2"
+requests-toolbelt==0.9.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+requests==2.26.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.6.0" and python_version >= "3.6"
+resolvelib==0.5.5; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+ruamel.yaml==0.17.17; python_version >= "3.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.7"
+secretstorage==3.3.1; python_version >= "3.6" and python_version < "4.0" and (python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0") and sys_platform == "linux"
+selinux==0.2.1; python_version >= "3.6" and python_full_version < "3.0.0" and sys_platform == "linux" or python_version >= "3.6" and python_full_version < "3.0.0" and sys_platform == "linux2" or sys_platform == "linux" and python_version >= "3.6" and python_full_version >= "3.5.0" or sys_platform == "linux2" and python_version >= "3.6" and python_full_version >= "3.5.0"
+sh==1.14.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+shellingham==1.4.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_version >= "3.6" and python_full_version >= "3.5.0"
+six==1.16.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+smmap==5.0.0; python_version >= "3.7"
+stevedore==3.5.0; python_version >= "3.6"
+tabulate==0.8.9; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+text-unidecode==1.3; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+toml==0.10.2; python_full_version >= "3.6.1" and python_version >= "3.6" and python_version < "4.0"
+tomli==1.2.2; python_version >= "3.6" and python_full_version >= "3.6.2"
+tomlkit==0.7.2; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+tree-format==0.1.2; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+typing-extensions==4.0.0
+urllib3==1.26.7; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.6.0" and python_version < "4"
+virtualenv==20.10.0; python_full_version >= "3.6.1"
+watchdog==2.1.6; python_version >= "3.6"
+webencodings==0.5.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+wrapt==1.13.3; python_version >= "3.6" and python_full_version < "3.0.0" and python_version < "4.0" or python_version >= "3.6" and python_version < "4.0" and python_full_version >= "3.5.0"
+yamllint==1.23.0; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.4.0")
+zipp==3.6.0; python_version >= "3.6"

requirements.txt

@@ -1,7 +1,11 @@
-ansible-lint==4.2.0
-docker==4.2.0
-flake8==3.7.9
-molecule-vagrant==0.2
-molecule==3.0.3
-testinfra==5.0.0
-yamllint==1.23.0
+ansible-core==2.11.6; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+ansible==4.2.0; (python_version >= "2.7" and python_full_version < "3.0.0") or (python_full_version >= "3.5.0")
+cffi==1.15.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+cryptography==36.0.0; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+jinja2==3.0.3; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+markupsafe==2.0.1; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+packaging==20.9; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"
+pycparser==2.21; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pyparsing==3.0.6; python_version >= "3.6" and python_full_version < "3.0.0" or python_full_version >= "3.5.0" and python_version >= "3.6"
+pyyaml==5.4.1; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.6.0"
+resolvelib==0.5.5; python_version >= "2.7" and python_full_version < "3.0.0" or python_full_version >= "3.5.0"

tasks/amazon.yml

@@ -0,0 +1,70 @@
+---
+
+- name: amazon | check for nvme devices
+  shell: |
+    set -o pipefail
+    cat /proc/partitions | awk '{print $4}' | grep -q nvme. ; echo $?
+  args:
+    executable: /bin/bash
+  register: blkdev_nvme
+  changed_when: false
+
+- name: amazon | check for amazon ebs devices
+  shell: |
+    set -o pipefail
+    lsblk -O -J | grep -qi "amazon elastic block store" ; echo $?
+  register: blkdev_awsebs
+  changed_when: false
+  args:
+    executable: /bin/bash
+
+- name: amazon | set flag for nvme subsystem
+  set_fact:
+    device_is_nvme: "{{ true if (blkdev_nvme.stdout == '0') else false }}"
+
+- name: amazon | set flag for aws ebs devices
+  set_fact:
+    device_is_awsebs: "{{ true if (blkdev_awsebs.stdout == '0') else false }}"
+
+- name: Block to map renamed ec2 ebs nvmeXnY devices to their original sdX/xvdX names
+  when: device_is_nvme and device_is_awsebs|bool
+  become: true
+  block:
+    - name: amazon | download nvme mapping binary helper
+      get_url:
+        url: "{{ ebsnvme_binary_helper_url }}"
+        dest: "{{ ebsnvme_binary_helper_tmp }}/"
+      changed_when: false
+
+    - name: amazon | extract binary helper
+      unarchive:
+        src: "{{ ebsnvme_binary_helper_tmp }}/{{ ebsnvme_binary_helper_file }}"
+        dest: "{{ ebsnvme_binary_helper_tmp }}/"
+        remote_src: yes
+        mode: 0755
+      changed_when: false
+
+    - name: amazon | copy binary helper
+      copy:
+        src: "{{ ebsnvme_binary_helper_tmp }}/go-ebsnvme"
+        dest: "{{ ebsnvme_binary_helper_path }}"
+        mode: a+x
+        remote_src: yes
+
+    - name: amazon | template script helper
+      template:
+        src: 'ebsnvme-id.j2'
+        dest: "{{ ebsnvme_scrip_helper_path }}"
+        mode: a+x
+
+    - name: amazon | template udev rule
+      template:
+        src: '70-ec2-nvme-devices.rules.j2'
+        dest: '/etc/udev/rules.d/70-ec2-nvme-devices.rules'
+        mode: 0755
+      register: udev_rule
+
+    - name: amazon | reload and trigger udev rules
+      shell:
+        cmd: udevadm control --reload-rules && udevadm trigger
+      when: udev_rule.changed

tasks/centos.yml

@@ -1,15 +1,14 @@
 ---
-- name: centos | installing lvm2
+- name: centos | installing lvm2 and sg3_utils
   package:
-    name: lvm2
+    name:
+      - lvm2
+      - sg3_utils
     state: present
   become: true
 
-- name: centos | installing sg3_utils
-  package:
-    name: sg3_utils
-    state: present
-  become: true
+- include_tasks: amazon.yml
+  when: ansible_facts.system_vendor == 'Amazon EC2'
 
 - name: centos | debug lvg
   debug:
@@ -35,13 +34,36 @@
     - lv.1.create is defined
     - lv.1.create|bool
 
-- name: centos | checking for scsi devices
-  command: sg_scan
+- name: centos | check for scsi adapters
+  find:
+    paths: "/sys/class/scsi_host"
+    file_type: any
   become: true
-  register: scsi_devices
-  changed_when: false
+  register: scsi_adapters
 
-- name: centos | rescanning for new disks
-  command: /usr/bin/rescan-scsi-bus.sh
-  become: true
-  changed_when: false
+- block:
+  - name: centos | installing sg3_utils
+    package:
+      name: sg3_utils
+      state: present
+    become: true
+
+  - name: centos | checking for scsi devices
+    command: sg_scan
+    become: true
+    register: scsi_devices
+    changed_when: false
+
+  - name: centos | rescanning for new disks
+    command: "{{ rescan_scsi_command }}"
+    become: true
+    changed_when: false
+    when: scsi_devices.stdout|length > 0
+
+  - name: centos | rescanning for resized disks
+    command: "{{ rescan_scsi_command }} -s"
+    become: true
+    changed_when: false
+    when: scsi_devices.stdout|length > 0
+
+  when: scsi_adapters.matched > 0

tasks/create_fs.yml

@@ -1,4 +1,21 @@
 ---
+
+# unable to resize xfs: looks like we've to reference the mountpoint instead of the device
+- name: create_fs | check already converted
+  # at least xfs is executed twice if the partition has changed in the meantime
+  # then it tries to recreate the fs on the mounted fs which indeed fails...
+  shell: "xfs_info {{ lv.mntp }} | grep -c 'ftype=1'"
+  become: yes
+  register: mountedxfs
+  ignore_errors: true
+  changed_when: false
+  when:
+    - lv is defined and lv != 'None'
+    - lv.filesystem is defined
+    - lv.filesystem == "xfs"
+    - lv.create is defined
+    - lv.create|bool
+
 - name: create_fs | unmounting filesystem(s)
   mount:
     path: "{{ lv.mntp }}"
@@ -6,9 +23,6 @@
     fstype: "{{ lv.filesystem | default(omit) }}"
     state: absent
   become: true
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
   when:
     - lv is defined
     - lv != 'None'
@@ -21,9 +35,6 @@
     fstype: "{{ lv.filesystem }}"
     dev: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
     resizefs: yes
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
   become: true
   when:
     - vg.create is defined
@@ -34,34 +45,13 @@
     - lv.create|bool
     - lv.filesystem is defined
     - lv.filesystem != 'None'
+    - lv.filesystem != 'swap'
     - lv.filesystem != 'xfs'
 
-# unable to resize xfs: looks like we've to reference the mountpoint instead of the device
-- name: create_fs | check already converted
-  # at least xfs is executed twice if the partition has changed in the meantime
-  # then it tries to recreate the fs on the mounted fs which indeed fails...
-  shell: "xfs_info {{ lv.mntp }} | grep -c 'ftype=1'"
-  become: yes
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
-  register: mountedxfs
-  ignore_errors: true
-  changed_when: false
-  when:
-    - lv is defined and lv != 'None'
-    - lv.filesystem is defined
-    - lv.filesystem == "xfs"
-    - lv.create is defined
-    - lv.create|bool
-
 - name: create_fs | creating new xfs filesystem on new LVM logical volume(s)
   filesystem:
     fstype: "{{ lv.filesystem }}"
     dev: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
   become: true
   when:
     - mountedxfs is failed
@@ -82,14 +72,26 @@
     state: mounted
     opts: "{{ lv.mopts | default('defaults') }}"
   become: true
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
   when:
     - vg.create is defined
     - vg.create|bool
+    - lv is defined
     - lv != 'None'
     - lv.create is defined
     - lv.create|bool
     - lv.mount is defined
     - lv.mount|bool
+
+- name: create_fs | resizing xfs filesystem on new LVM logical volume(s)
+  command: "xfs_growfs {{ lv.mntp }}"
+  become: true
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+    - lv.filesystem is defined
+    - lv.filesystem == 'xfs'
+    - lvchanged.changed

tasks/create_lv.yml

@@ -1,17 +1,10 @@
 ---
+
 - name: create_lv | Display Volume Group
   debug:
     var: vg
     verbosity: 2
 
-- name: create_lv | debug lvm
-  loop: "{{ vg.lvnames }}"
-  debug:
-    var: lv
-    verbosity: 1
-  loop_control:
-    loop_var: lv
-
 - name: create_lv | creating new LVM logical volume(s)
   lvol:
     vg: "{{ vg.vgname }}"
@@ -20,10 +13,8 @@
     shrink: false
     opts: "{{ lv.opts | default('') }}"
     state: present
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
   become: true
+  register: lvchanged
   when:
     - vg.create is defined
     - vg.create|bool
@@ -31,3 +22,10 @@
     - lv != 'None'
     - lv.create is defined
     - lv.create|bool
+
+- name: create_lv | debug changed attribute
+  debug:
+    var: lvchanged
+
+- name: create_lv | configuring FS
+  include_tasks: create_fs.yml

tasks/create_vg.yml

@@ -1,11 +1,29 @@
 ---
 - name: create_vg | creating new LVM volume group(s)
   lvg:
-    vg: "{{ item.vgname }}"
-    pvs: "{{ item.disks | join(',') }}"
+    vg: "{{ vg.vgname }}"
+    pvs: "{{ vg.disks | join(',') }}"
     state: present
   become: true
-  loop: "{{ lvm_groups }}"
   when:
-    - item.create is defined
-    - item.create|bool
+    - vg.create is defined
+    - vg.create|bool
+
+### workaround: auto pvresize waiting for upgrade to new module supporting integrated pvresize
+###             ref: https://docs.ansible.com/ansible/3/collections/community/general/lvg_module.html
+- name: create_vg | pvresize to max available free space
+  command: "pvresize {{ pv }}"
+  loop: "{{ vg.disks | default([]) }}"
+  loop_control:
+    loop_var: pv
+  changed_when: false
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - pvresize_to_max|bool
+
+- name: manage_lvm | loop over logical volume group(s) to create logical volumes
+  include_tasks: create_lv.yml
+  loop: "{{ vg.lvnames | default([]) }}"
+  loop_control:
+    loop_var: lv

tasks/debian.yml

@@ -34,7 +34,7 @@
   changed_when: false
 
 - name: debian | rescanning for new disks added
-  command: /sbin/rescan-scsi-bus
+  command: "{{ rescan_scsi_command }}"
   become: true
   changed_when: false
   when: scsi_devices['stdout'] | length

tasks/main.yml

@@ -1,10 +1,18 @@
 ---
 # tasks file for ansible-manage-lvm
+- name: Set rescan_scsi_command for old debian version
+  set_fact:
+    rescan_scsi_command: "/sbin/rescan-scsi-bus"
+  when:
+    - ansible_facts.distribution | replace(' ','') | lower == 'debian'
+    - ansible_facts.distribution_release not in ('bookworm', 'sid')
+    - ansible_facts.distribution_major_version is version(10, '<=')
+
 - include_tasks: debian.yml
-  when: ansible_os_family == "Debian"
+  when: ansible_facts.os_family == "Debian"
 
 - include_tasks: centos.yml
-  when: ansible_os_family == "RedHat"
+  when: ansible_facts.os_family == "RedHat"
 
 - include_tasks: manage_lvm.yml
   when:

tasks/manage_lvm.yml

@@ -1,15 +1,6 @@
 ---
 - name: manage_lvm | manage physical volume group creation
   include_tasks: create_vg.yml
-
-- name: manage_lvm | loop over logical volume group(s) to create logical volumes
-  include_tasks: create_lv.yml
-  loop: "{{ lvm_groups }}"
-  loop_control:
-    loop_var: vg
-
-- name: manage_lvm | loop over logical volume group(s) to create filesystems
-  include_tasks: create_fs.yml
   loop: "{{ lvm_groups }}"
   loop_control:
     loop_var: vg
@@ -21,7 +12,7 @@
     state: absent
     force: true
   become: true
-  loop: "{{ lvm_groups|subelements('lvnames') }}"
+  loop: "{{ lvm_groups|subelements('lvnames', {'skip_missing': true}) }}"
   when:
     - item.1 is defined
     - item.1 != 'None'

templates/70-ec2-nvme-devices.rules.j2

@@ -0,0 +1,3 @@
+# ebs nvme to scsi device naming mapping
+KERNEL=="nvme[0-9]*n[0-9]*", ENV{DEVTYPE}=="disk", ATTRS{model}=="Amazon Elastic Block Store", PROGRAM="{{ ebsnvme_scrip_helper_path }} /dev/%k", SYMLINK+="%c"
+

templates/ebsnvme-id.j2

@@ -0,0 +1,15 @@
+#!/bin/bash
+# This script uses go version of ebsnvme-id to provide
+# SCSI Disk device name links for nvme devices
+#
+# links:
+#
+#    https://www.logicworks.com/blog/2018/03/manage-aws-ebs-volumes-c5-m5-puppet-chef-ansible/
+#    https://github.com/mvisonneau/go-ebsnvme
+#    https://gist.github.com/lbernail/d851e5b06eb32180a4b8ead2ce4f45db
+#      and working forks like:
+#      (keenan-v1/ebsnvme-id) https://gist.github.com/keenan-v1/aee92cd7383ee02de2a817a004917a03
+#
+
+{{ ebsnvme_binary_helper_path }} -n $1 | awk -F '/' '{print $3}'
+

vars/main.yml

@@ -1,2 +1,7 @@
 ---
 # vars file for ansible-manage-lvm
+
+ebsnvme_binary_helper_file: go-ebsnvme_{{ ebsnvme_binary_helper_ver }}_linux_amd64.tar.gz
+ebsnvme_binary_helper_url:  https://github.com/mvisonneau/go-ebsnvme/releases/download/{{ ebsnvme_binary_helper_ver }}/{{ ebsnvme_binary_helper_file }}
+
+rescan_scsi_command: "/usr/bin/rescan-scsi-bus.sh"