Merge pull request #68 from stackhpc/ansible-facts

Use ansible_facts to reference facts
2026-02-04 08:49:13 +03:00 · 2021-07-26 14:25:57 -04:00 · 2021-05-13 17:21:42 +01:00 · 2021-04-23 20:58:39 -04:00 · 2021-04-23 20:56:44 -04:00 · 2021-04-23 00:20:15 -04:00
35 changed files with 634 additions and 379 deletions
--- a/.github/config.yml
+++ b/.github/config.yml
@@ -0,0 +1,14 @@
+# Configuration for request-info - https://github.com/behaviorbot/request-info
+
+# *Required* Comment to reply with
+requestInfoReplyComment: >
+  We would appreciate it if you could provide us with more info about this issue/pr!
+
+# *OPTIONAL* default titles to check against for lack of descriptiveness
+# MUST BE ALL LOWERCASE
+requestInfoDefaultTitles:
+  - update readme.md
+  - updates
+
+# *OPTIONAL* Label to be added to Issues and Pull Requests with insufficient information given
+requestInfoLabelToAdd: needs-more-info
--- a/.github/release-drafter.yml
+++ b/.github/release-drafter.yml
@@ -0,0 +1,32 @@
+name-template: "v$RESOLVED_VERSION 🌈"
+tag-template: "v$RESOLVED_VERSION"
+categories:
+  - title: "🚀 Features"
+    labels:
+      - "feature"
+      - "enhancement"
+  - title: "🐛 Bug Fixes"
+    labels:
+      - "fix"
+      - "bugfix"
+      - "bug"
+  - title: "🧰 Maintenance"
+    label: "chore"
+  - title: "🧺 Miscellaneous" #Everything except ABAP
+    label: "misc"
+change-template: "- $TITLE @$AUTHOR (#$NUMBER)"
+change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
+version-resolver:
+  major:
+    labels:
+      - "major"
+  minor:
+    labels:
+      - "minor"
+  patch:
+    labels:
+      - "patch"
+  default: patch
+template: |
+  ## Changes
+  $CHANGES
--- a/.github/settings.yml
+++ b/.github/settings.yml
@@ -0,0 +1,10 @@
+# These settings are synced to GitHub by https://probot.github.io/apps/settings/
+
+repository:
+  # See https://developer.github.com/v3/repos/#edit for all available settings.
+
+  # The name of the repository. Changing this will rename the repository
+  name: ansible-manage-lvm
+
+  # A short description of the repository that will show up on GitHub
+  description: Ansible role to manage LVM Groups/Logical Volumes
--- a/.github/stale.yml
+++ b/.github/stale.yml
@@ -0,0 +1,17 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - pinned
+  - security
+# Label to use when marking an issue as stale
+staleLabel: wontfix
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false
--- a/.github/workflows/release-drafter.yml
+++ b/.github/workflows/release-drafter.yml
@@ -0,0 +1,17 @@
+name: Release Drafter
+
+on:
+  push:
+    # branches to consider in the event; optional, defaults to all
+    branches:
+      - main
+      - master
+
+jobs:
+  update_release_draft:
+    runs-on: ubuntu-latest
+    steps:
+      # Drafts your next Release notes as Pull Requests are merged into "master"
+      - uses: release-drafter/release-drafter@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
--- a/.travis.yml
+++ b/.travis.yml
@@ -26,5 +26,7 @@ before_install:
 script:
  - |
    sudo molecule test --scenario-name kvm
+    sudo molecule test --scenario-name kvmsinglelv
+    sudo molecule test --scenario-name kvmonlyvg
 notifications:
  webhooks: https://galaxy.ansible.com/api/v1/notifications/
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,322 +1,322 @@
 commit 881d5d77fa435ccaa026c3341d0d2ac1fb537b98
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Apr 27 11:26:18 2020 -0400
+Date: Mon Apr 27 11:26:18 2020 -0400

    Fixing syntax issue for wantlist

 commit 89360e3ffef9ff1dbbb5ad525a7ee1d77e6b8895
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Apr 27 11:16:02 2020 -0400
+Date: Mon Apr 27 11:16:02 2020 -0400

    Trying to fix the subelements lookup for a single element
-    
+
    This addresses #42. Will need to do some validation testing, etc.

 commit c6a7034e4b0b381c5c5b44a15ce7baad7eab9c1b
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Fri Apr 24 17:22:07 2020 +0200
+Date: Fri Apr 24 17:22:07 2020 +0200

    remove unused molecule env property

 commit 883055c33f2d6b4c0df8e61ce49771c451905334
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Thu Apr 23 19:38:35 2020 +0200
+Date: Thu Apr 23 19:38:35 2020 +0200

    lint

 commit 325c2d6240022fe17abf40dffee842ccf79543f1
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Thu Apr 23 19:25:09 2020 +0200
+Date: Thu Apr 23 19:25:09 2020 +0200

    install xfs

 commit 4a1177e420fd9632f77d07ce0a19f89a1515f8eb
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Tue Apr 21 19:01:29 2020 +0200
+Date: Tue Apr 21 19:01:29 2020 +0200

    use xfs_info on mountpoint instead of lvm

 commit 7fd5a8eec9f4b5110929862056ab88c4db3f14de
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Sun Apr 19 01:59:29 2020 -0400
+Date: Sun Apr 19 01:59:29 2020 -0400

    Only doing a Molecule lint at this time

 commit 7e2a076b0a8155015fd21502db860fa89a2114b3
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Sun Apr 19 01:44:38 2020 -0400
+Date: Sun Apr 19 01:44:38 2020 -0400

    Added Python requirements for testing, etc.
-    
+
    Closes #33

 commit dadb9f24f7ebc2752e6495c4c3569bdee5e0cc68
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Fri Apr 17 13:12:06 2020 +0200
+Date: Fri Apr 17 13:12:06 2020 +0200

    remove unwanted files

 commit 2f63eab727cf7b0b389d0d0cc1a1c7236b71f839
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Fri Apr 17 12:56:31 2020 +0200
+Date: Fri Apr 17 12:56:31 2020 +0200

    code smells

 commit 050f8a56f10d81f7827be53b8c769b1aa5021c00
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 19:08:34 2020 +0200
+Date: Wed Apr 15 19:08:34 2020 +0200

    typo in check

 commit b955a6f073b91773f5f90da878268e74872a99e9
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 18:54:17 2020 +0200
+Date: Wed Apr 15 18:54:17 2020 +0200

    remove unwanted newline

 commit f81937e9d82bc48f2ee03f6ff462c32bca3da8f0
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 18:52:52 2020 +0200
+Date: Wed Apr 15 18:52:52 2020 +0200

    makes xfs mountpoint repeatable

 commit 1c3818e5d06887c01dc0a4b88a39c0561a446300
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 17:34:53 2020 +0200
+Date: Wed Apr 15 17:34:53 2020 +0200

    mistake on remove volume

 commit 47f8dae16a096050dccbb8d161f4a18946a6ae73
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 17:13:38 2020 +0200
+Date: Wed Apr 15 17:13:38 2020 +0200

    github action lint

 commit 96fa78d6d099d0a48642d377d3e7f30a0c554bdf
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 17:07:33 2020 +0200
+Date: Wed Apr 15 17:07:33 2020 +0200

    remove deprecated machines

 commit 17e8ec1058c5cb66b21b15a8d3912ac9980508a9
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 16:56:18 2020 +0200
+Date: Wed Apr 15 16:56:18 2020 +0200

    configured molecule and fix xfs on centos

 commit ba5d929fce982af9baa44cfe8ad0b3079133f444
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 15:14:30 2020 +0200
+Date: Wed Apr 15 15:14:30 2020 +0200

    use dots instead of carets

 commit ea9109220bb268b5f14e75e38d9fb32c2d79bae5
 Author: Charlie Mordant <cmordant1@gmail.com>
-Date:   Wed Apr 15 14:33:41 2020 +0200
+Date: Wed Apr 15 14:33:41 2020 +0200

    molecule test and idempotence

 commit d8b3a4e93257dfeb79bc8d4ef349acb53f0019dc
 Author: Samuel Mutel <smu-dw@deveryware.net>
-Date:   Mon Oct 14 12:21:03 2019 +0200
+Date: Mon Oct 14 12:21:03 2019 +0200

    bug: Resize XFS parts is not working

 commit b15ecea51d0045a89aae24e4b0c108b35f060b2c
 Author: Tony Peña <emperor.cu@gmail.com>
-Date:   Wed Jun 26 14:56:13 2019 +0200
+Date: Wed Jun 26 14:56:13 2019 +0200

    Update debian.yml
-    
+
    Since ansible 2.8.0 must be change way using dict

 commit 9788ee5df68798ad94f11c8133b1d62ff409d0e8
 Author: Michele Caputo <mikap83@gmail.com>
-Date:   Mon Apr 8 14:16:04 2019 +0200
+Date: Mon Apr 8 14:16:04 2019 +0200

    issue #23: extra parenthesis

 commit 0f428a0e40d71aea410fbc1aa329203c0b4f15cd
 Author: faisalnizam <faisal@logiik.com>
-Date:   Tue Mar 26 10:48:45 2019 +0400
+Date: Tue Mar 26 10:48:45 2019 +0400

    FIX LINT FOR BUILD
-    
+
    FIX LINT FOR BUILD

 commit 8957630c04b8befa99c08ed667e43d95198202ce
 Author: faisalnizam <faisal@logiik.com>
-Date:   Tue Mar 26 10:40:11 2019 +0400
+Date: Tue Mar 26 10:40:11 2019 +0400

    Adding SWAP FileSystem Exception
-    
+
    Adding Check for SWAP Filesystem if defined skip
    1. SKIP New Filesystem Creation
    2. SKIP mountpoint check

 commit 183087e767cbce08ce2da1a3b04f47d3fc03a7e6
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Apr 2 08:03:42 2019 -0400
+Date: Tue Apr 2 08:03:42 2019 -0400

    Resolves #21

 commit b3ef85d4f738597260d9db0d90e84d0f8721259a
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Wed Dec 5 08:39:10 2018 -0500
+Date: Wed Dec 5 08:39:10 2018 -0500

    Added skip codes for ansible-lint

 commit 9f4afa7afb3fedc270c44ff1fa357da4b87845c0
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Wed Dec 5 08:00:13 2018 -0500
+Date: Wed Dec 5 08:00:13 2018 -0500

    Fixing Travis testing and yamllint issues

 commit 5603c5f6b0899a1b2cdeeeb3c035eb6249e96fa7
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Wed Dec 5 07:51:31 2018 -0500
+Date: Wed Dec 5 07:51:31 2018 -0500

    Added Travis testing and hooks for galaxy

 commit 563aa1effba936340cbaad9766a49f570292edee
 Author: Mark Goddard <mark@stackhpc.com>
-Date:   Wed Oct 31 11:42:20 2018 +0000
+Date: Wed Oct 31 11:42:20 2018 +0000

    Fix indentation

 commit 4a58cb36cf6d4dd4bb23e86972658be508cca082
 Author: Mark Goddard <mark@stackhpc.com>
-Date:   Wed Oct 31 11:16:27 2018 +0000
+Date: Wed Oct 31 11:16:27 2018 +0000

    Update tasks/manage_lvm.yml
-    
+
    Co-Authored-By: oneswig <stig.github@telfer.org>

 commit a0c784797f538fc5393d75589ac48e86c51e88db
 Author: Stig Telfer <stig@stackhpc.com>
-Date:   Wed Oct 31 10:16:44 2018 +0100
+Date: Wed Oct 31 10:16:44 2018 +0100

    Support not formatting volumes.
-    
+
    Logic to make the filesystem attribute optional, in situations where
    we do not want the volumes formatted.

 commit 66368de1d3d2b6712cbf66fc3dd0962705bf86f9
 Author: David Castellanos <dcastellanos@fintonic.com>
-Date:   Mon Dec 18 00:33:45 2017 +0100
+Date: Mon Dec 18 00:33:45 2017 +0100

    Add opts and mopts support

 commit 386cc28bdb58886ed492d3438c9cb088d36de161
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Sun Jun 11 14:57:53 2017 -0400
+Date: Sun Jun 11 14:57:53 2017 -0400

    Addresses issue #10
-    
+
    Signed-off-by: Larry Smith Jr <mrlesmithjr@gmail.com>

 commit 0d255cb5ce9e6016a503203c2ed39a70fb0ccd9c
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Fri May 5 09:12:25 2017 -0400
+Date: Fri May 5 09:12:25 2017 -0400

    Fixes issue #8
-    
+
    Signed-off-by: Larry Smith Jr <mrlesmithjr@gmail.com>

 commit f2d06d0d46086da0191b4dbde0d420e709e3ea01
 Author: Stefan Heimberg <kontakt@stefanheimberg.ch>
-Date:   Thu Apr 6 00:25:55 2017 +0200
+Date: Thu Apr 6 00:25:55 2017 +0200

    added support for btrfs

 commit 7749d0c62a6e1539aff94c57fd2c0eeaf43dd1a0
 Author: Kevin Loveland <kevin.loveland@gmail.com>
-Date:   Fri Nov 18 10:26:16 2016 -0800
+Date: Fri Nov 18 10:26:16 2016 -0800

    Fixed issue with idempotency of lvol module. See ansible-module-extras issue #428

 commit 3ad965237280d534f0aab0027f9ef61701354e8b
 Author: Kevin Loveland <kevin.loveland@gmail.com>
-Date:   Thu Nov 17 15:17:26 2016 -0800
+Date: Thu Nov 17 15:17:26 2016 -0800

    Changes to adjust to removal of bare vars in Ansible 2.2

 commit a82877c290cfe0b62eda90d8874b8e2b62402946
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Sun Oct 2 09:58:47 2016 -0400
+Date: Sun Oct 2 09:58:47 2016 -0400

    First commit of CHANGELOG
-    
+
    Signed-off-by: Larry Smith Jr <mrlesmithjr@gmail.com>

 commit 99366fa547faccb0359dd8d3b19cec802640eb95
 Author: Rohit Kothari <rohietkothari@gmail.com>
-Date:   Thu Sep 29 17:59:19 2016 -0700
+Date: Thu Sep 29 17:59:19 2016 -0700

    Replace system-storage-manager with lvm2 in centos

 commit ca1535d774b4e3310fc993841f1f99400612c7a5
 Author: Olivier LOCARD <olivier.locard@deveryware.com>
-Date:   Fri Sep 23 16:21:07 2016 +0200
+Date: Fri Sep 23 16:21:07 2016 +0200

    Add xfs_growfs for xfs systemfile type.

 commit bb87fa8dbff5df50ed376db74a6d2b95f64fd745
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Nov 3 10:39:58 2015 -0500
+Date: Tue Nov 3 10:39:58 2015 -0500

    updated vars and conditionals

 commit 49b20e2e4a80581f1c53559ff4073b3384eae28c
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Nov 3 10:24:54 2015 -0500
+Date: Tue Nov 3 10:24:54 2015 -0500

    updated when conditions

 commit 0232734bed92e976376d4c9f2550b515f72f3d54
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Nov 3 10:22:09 2015 -0500
+Date: Tue Nov 3 10:22:09 2015 -0500

    updated tasks to only work when lvnames is defined

 commit 9f592112095208843da1fd69a658bd49c163a7bb
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Nov 3 09:37:38 2015 -0500
+Date: Tue Nov 3 09:37:38 2015 -0500

    updated vars and meta

 commit 686455514d8bc0da70b3440dbc5afe669188d333
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Tue Nov 3 09:22:00 2015 -0500
+Date: Tue Nov 3 09:22:00 2015 -0500

    cleaned up and fixed all tasks including swap

 commit 9f5c61e25599a130e1625e879438561cc1f6a437
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Nov 2 23:38:38 2015 -0500
+Date: Mon Nov 2 23:38:38 2015 -0500

    added new task

 commit a5103ff6396138f531cf8457f16706b6fc90d1d1
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Nov 2 23:38:23 2015 -0500
+Date: Mon Nov 2 23:38:23 2015 -0500

    changing role tasks and vars

 commit c776e9f339f0bcfe987aa571d29411ac44a29526
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Nov 2 21:50:07 2015 -0500
+Date: Mon Nov 2 21:50:07 2015 -0500

    updated meta

 commit 46e0fd1fc2477693fc66aa4b38ac7bde19087047
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Nov 2 21:23:59 2015 -0500
+Date: Mon Nov 2 21:23:59 2015 -0500

    updated meta

 commit d1d99b2f17d3bc46a479af5d01a976686429b7ce
 Author: Larry Smith Jr <mrlesmithjr@gmail.com>
-Date:   Mon Nov 2 21:23:03 2015 -0500
+Date: Mon Nov 2 21:23:03 2015 -0500

    first commit
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
-# Role Name
+# ansible-manage-lvm

-An [Ansible] role to manage LVM Groups/Logical Volumes.
+Ansible role to manage LVM Groups/Logical Volumes.

 > NOTE: Can be used to create, extend or resize LVM Groups and volumes.

@@ -9,78 +9,9 @@ An [Ansible] role to manage LVM Groups/Logical Volumes.
 Devices/disks to be members of the LVM setup **must be** identified prior to
 using this role.

-> NOTE: Ensure that you select the correct devices/disks.
->
-> NOTE: To create an LVM VG w/out creating LVM LVOLS...define lvname w/ var as
-> `None` as in the below example.
-
 ## Role Variables

-```yaml
---
-# defaults file for ansible-manage-lvm
-lvm_groups: []
-  # - vgname: ubuntu-vg
-  #   disks:
-  #     - /dev/sda5
-  #     - /dev/sdc
-  #     - /dev/sdd
-  #   # defines if VG should exist or be removed
-  #   # true or false
-  #   create: true
-  #   lvnames:
-  #     - lvname: swap_1
-  #       # Define size of lvol
-  #       # 100%FREE, 10g, 1024 (megabytes by default)
-  #       size: 5g
-  #       # Defines additional lvcreate options (e.g. stripes, stripesize, etc)
-  #       opts: ''
-  #       # Defines if lvol should exist or be removed
-  #       # true or false
-  #       create: true
-  #       # Defines filesystem to format lvol as
-  #       filesystem: swap
-  #       # Defines if filesystem should be mounted
-  #       mount: false
-  #       # Defines mountpoint for lvol
-  #       mntp: []
-  #       # Defines additional mount options (e.g. noatime, noexec, etc)
-  #       mopts: ''
-  #     - lvname: root
-  #       size: 40g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /
-  # - vgname: test-vg
-  #   disks:
-  #     - /dev/sdb
-  #   create: true
-  #   lvnames:
-  #     - lvname: test_1
-  #       size: 5g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /mnt/test_1
-  #     - lvname: test_2
-  #       size: 10g
-  #       create: true
-  #       filesystem: ext4
-  #       mount: true
-  #       mntp: /mnt/test_2
-  # - vgname: cinder-volumes
-  #   disks:
-  #     - /dev/cciss/c0d1
-  #   create: true
-  #   lvnames:
-  #   # Set to None to only create LVM VG w/out creating LVM LVOLS
-  #    - None
-
-# Defines if LVM will be managed by role
-# default is false to ensure nothing is changed by accident.
-manage_lvm: false
-```
+[defaults/main.yml](defaults/main.yml)

 ## Dependencies

@@ -88,48 +19,16 @@ None

 ## Example Playbook

-```yaml
---
- hosts: test-nodes
-  vars:
-    lvm_groups:
-      - vgname: test-vg
-        disks:
-          - /dev/sdb
-          - /dev/sdc
-        create: true
-        lvnames:
-          - lvname: test_1
-            size: 5g
-            create: true
-            filesystem: ext4
-            mount: true
-            mntp: /mnt/test_1
-          - lvname: test_2
-            size: 10g
-            create: true
-            filesystem: ext4
-            mount: true
-            mntp: /mnt/test_2
-    manage_lvm: true
-    pri_domain_name: 'test.vagrant.local'
-  roles:
-    - role: ansible-manage-lvm
-  tasks:
-```
+[playbook.yml](playbook.yml)

 ## License

-BSD
+MIT

 ## Author Information

 Larry Smith Jr.

-   [@mrlesmithjr]
-   <http://everythingshouldbevirtual.com>
-   mrlesmithjr [at] gmail.com
-
-[@mrlesmithjr]: https://www.twitter.com/mrlesmithjr
-
-[ansible]: https://www.ansible.com
+- [@mrlesmithjr](https://twitter.com/mrlesmithjr)
+- [mrlesmithjr@gmail.com](mailto:mrlesmithjr@gmail.com)
+- [http://everythingshouldbevirtual.com](http://everythingshouldbevirtual.com)
--- a/defaults/main.yml
+++ b/defaults/main.yml
@@ -61,3 +61,17 @@ lvm_groups: []
 # Defines if LVM will be managed by role
 # default is false to ensure nothing is changed by accident.
 manage_lvm: false
+
+###     nvme to scsi device name map binary helper
+ebsnvme_binary_helper_ver: '0.1.3'
+ebsnvme_binary_helper_tmp: '/tmp'
+ebsnvme_binary_helper_path: '/sbin/go-ebsnvme'
+
+###     nvme to scsi device name map script helper
+ebsnvme_scrip_helper_path: '/usr/local/bin/ebsnvme-id'
+
+###     auto pvresize (waiting until ansible 2.10 or above as collections have new lvg with integrated pvresize)
+###     waiting for new module in collection set to true or run pvresize manually on remote systems
+###     https://docs.ansible.com/ansible/3/collections/community/general/lvg_module.html
+###
+pvresize_to_max: false
--- a/meta/main.yml
+++ b/meta/main.yml
@@ -1,7 +1,7 @@
 ---
 galaxy_info:
  author: Larry Smith Jr.
-  description: Role to manage LVM Groups/Logical Volumes. Can be used to create, extend or resize LVM.
+  description: Ansible role to manage(create, extend, resize) LVM Groups/Logical Volumes.

  license: MIT
  min_ansible_version: 1.2
@@ -12,17 +12,16 @@ galaxy_info:

    - name: EL
      versions:
-        - 6
-        - 7
+        - all
+    - name: Fedora
+      versions:
+        - all
    - name: Ubuntu
      versions:
-        - precise
-        - trusty
+        - all
    - name: Debian
      versions:
-        - jessie
-        - wheezy
-
+        - all
  galaxy_tags:
    - system
    - lvm
--- a/molecule/default/converge.yml
+++ b/molecule/default/converge.yml
@@ -15,7 +15,7 @@
            filesystem: ext4
            mount: true
            mntp: "/var/lib/mountpoint"
-          - lvname: my_lv2
+          - lvname: my_lw
            size: 20%VG
            opts: "--wipesignatures y"
            mount: true
--- a/molecule/default/molecule.yml
+++ b/molecule/default/molecule.yml
@@ -5,13 +5,27 @@ driver:
    name: virtualbox
 lint: yamllint . && flake8 && ansible-lint
 platforms:
-  - name: Fedora-Molecule-LVM
-    box: fedora/31-cloud-base
-    cpu: 2
-    memory: 2048
+  - name: CentOS-Molecule-LVM
+    box: mrlesmithjr/centos7
    provider_override_args:
      - "persistent_storage.enabled = true"
-      - "persistent_storage.location = 'molecule-lvm.vdi'"
+      - "persistent_storage.location = 'centos-molecule-lvm.vdi'"
+      - "persistent_storage.size = 100"
+      - "persistent_storage.mount = false"
+      - "persistent_storage.diskdevice = '/dev/sdb'"
+  - name: Fedora-Molecule-LVM
+    box: mrlesmithjr/fedora31
+    provider_override_args:
+      - "persistent_storage.enabled = true"
+      - "persistent_storage.location = 'fedora-molecule-lvm.vdi'"
+      - "persistent_storage.size = 100"
+      - "persistent_storage.mount = false"
+      - "persistent_storage.diskdevice = '/dev/sdb'"
+  - name: Ubuntu-Molecule-LVM
+    box: mrlesmithjr/bionic64
+    provider_override_args:
+      - "persistent_storage.enabled = true"
+      - "persistent_storage.location = 'ubuntu-molecule-lvm.vdi'"
      - "persistent_storage.size = 100"
      - "persistent_storage.mount = false"
      - "persistent_storage.diskdevice = '/dev/sdb'"
--- a/molecule/default/tests/test_default.py
+++ b/molecule/default/tests/test_default.py
@@ -18,6 +18,13 @@ def test_mylv_logical_volume_is_created(host):
    assert int(cmd.stdout.rstrip()) >= 1


+def test_mylv_logical_volume2_is_created(host):
+    command = """sudo lvs -o lv_name  my_vg --separator='|' --noheadings \
+    | grep -c 'my_lw'"""
+    cmd = host.run(command)
+    assert int(cmd.stdout.rstrip()) >= 1
+
+
 def test_volume_is_mounted(host):
    host.file("/var/lib/mountpoint").mode == 0o731

--- a/molecule/kvm/converge.yml
+++ b/molecule/kvm/converge.yml
@@ -15,7 +15,7 @@
            filesystem: ext4
            mount: true
            mntp: "/var/lib/mountpoint"
-          - lvname: my_lv2
+          - lvname: my_lw
            size: 20%VG
            opts: "--wipesignatures y"
            mount: true
--- a/molecule/kvmonlyvg/converge.yml
+++ b/molecule/kvmonlyvg/converge.yml
@@ -0,0 +1,14 @@
+---
+- name: Converge
+  hosts: all
+  vars:
+    lvm_groups:
+      - vgname: my_vg
+        disks:
+          - /dev/vdb
+        create: true
+    manage_lvm: true
+  tasks:
+    - name: "Include lvm"
+      include_role:
+        name: "ansible-manage-lvm"
--- a/molecule/kvmonlyvg/molecule.yml
+++ b/molecule/kvmonlyvg/molecule.yml
@@ -0,0 +1,29 @@
+---
+driver:
+  name: vagrant
+  provider:
+    name: libvirt
+lint: yamllint . && flake8 && ansible-lint
+platforms:
+  - name: Fedora-Molecule-Volumes-KVM
+    box: fedora/31-cloud-base
+    cpu: 2
+    memory: 2048
+    provider_raw_config_args:
+      - "storage :file, :size => '1G', :device => 'vdb'"
+provisioner:
+  name: ansible
+  config_options:
+    defaults:
+      forks: 20
+    ssh_connection:
+      pipelining: true
+      ssh_args: -o ControlMaster=auto -o ControlPersist=600s
+verifier:
+  name: testinfra
+  env:
+    PYTHONWARNINGS: "ignore:.*U.*mode is deprecated:DeprecationWarning"
+  options:
+    v: 1
+scenario:
+  name: kvmonlyvg
--- a/molecule/kvmonlyvg/tests/conftest.py
+++ b/molecule/kvmonlyvg/tests/conftest.py
@@ -0,0 +1 @@
+../../default/tests/conftest.py
--- a/molecule/kvmonlyvg/tests/test_default.py
+++ b/molecule/kvmonlyvg/tests/test_default.py
@@ -0,0 +1,11 @@
+"""Role testing files using testinfra."""
+
+
+def test_lvm_package_shall_be_installed(host):
+    assert host.package("lvm2").is_installed
+
+
+def test_non_persistent_volume_group_is_created(host):
+    command = """sudo vgdisplay | grep -c 'my_vg'"""
+    cmd = host.run(command)
+    assert '1' in cmd.stdout
--- a/molecule/kvmsinglelv/converge.yml
+++ b/molecule/kvmsinglelv/converge.yml
@@ -0,0 +1,22 @@
+---
+- name: Converge
+  hosts: all
+  vars:
+    lvm_groups:
+      - vgname: my_vg
+        disks:
+          - /dev/vdb
+        create: true
+        lvnames:
+          - lvname: my_lv
+            size: 40%VG
+            opts: "--wipesignatures y"
+            create: true
+            filesystem: ext4
+            mount: true
+            mntp: "/var/lib/mountpoint"
+    manage_lvm: true
+  tasks:
+    - name: "Include lvm"
+      include_role:
+        name: "ansible-manage-lvm"
--- a/molecule/kvmsinglelv/molecule.yml
+++ b/molecule/kvmsinglelv/molecule.yml
@@ -0,0 +1,29 @@
+---
+driver:
+  name: vagrant
+  provider:
+    name: libvirt
+lint: yamllint . && flake8 && ansible-lint
+platforms:
+  - name: Fedora-Molecule-Volumes-KVM
+    box: fedora/31-cloud-base
+    cpu: 2
+    memory: 2048
+    provider_raw_config_args:
+      - "storage :file, :size => '1G', :device => 'vdb'"
+provisioner:
+  name: ansible
+  config_options:
+    defaults:
+      forks: 20
+    ssh_connection:
+      pipelining: true
+      ssh_args: -o ControlMaster=auto -o ControlPersist=600s
+verifier:
+  name: testinfra
+  env:
+    PYTHONWARNINGS: "ignore:.*U.*mode is deprecated:DeprecationWarning"
+  options:
+    v: 1
+scenario:
+  name: kvmsinglelv
--- a/molecule/kvmsinglelv/tests/conftest.py
+++ b/molecule/kvmsinglelv/tests/conftest.py
@@ -0,0 +1 @@
+../../default/tests/conftest.py
--- a/molecule/kvmsinglelv/tests/test_default.py
+++ b/molecule/kvmsinglelv/tests/test_default.py
@@ -0,0 +1,22 @@
+"""Role testing files using testinfra."""
+
+
+def test_lvm_package_shall_be_installed(host):
+    assert host.package("lvm2").is_installed
+
+
+def test_non_persistent_volume_group_is_created(host):
+    command = """sudo vgdisplay | grep -c 'my_vg'"""
+    cmd = host.run(command)
+    assert '1' in cmd.stdout
+
+
+def test_mylv_logical_volume_is_created(host):
+    command = """sudo lvs -o lv_name  my_vg --separator='|' --noheadings \
+    | grep -c 'my_lv'"""
+    cmd = host.run(command)
+    assert int(cmd.stdout.rstrip()) >= 1
+
+
+def test_volume_is_mounted(host):
+    host.file("/var/lib/mountpoint").mode == 0o731
--- a/playbook.yml
+++ b/playbook.yml
@@ -0,0 +1,27 @@
+---
+- hosts: test-nodes
+  vars:
+    lvm_groups:
+      - vgname: test-vg
+        disks:
+          - /dev/sdb
+          - /dev/sdc
+        create: true
+        lvnames:
+          - lvname: test_1
+            size: 5g
+            create: true
+            filesystem: ext4
+            mount: true
+            mntp: /mnt/test_1
+          - lvname: test_2
+            size: 10g
+            create: true
+            filesystem: ext4
+            mount: true
+            mntp: /mnt/test_2
+    manage_lvm: true
+  tasks:
+    - name: Include lvm
+      include_role:
+        name: ansible-manage-lvm
--- a/setup_travis_tests.sh
+++ b/setup_travis_tests.sh
@@ -1,17 +0,0 @@
-#!/usr/bin/env bash
-
-TAR_FILE="v1.6.0.tar.gz"
-
-# Prompt for Ansible role name
-read -p "Enter the Ansible role name: " input
-
-# Update .travis.yml with Ansible role name
-sed -i '' "s/replace_role/${input}/g" ".travis.yml"
-
-# Update tests/test.yml with Ansible role name
-sed -i '' "s/replace_role/${input}/g" "tests/test.yml"
-
-# Cleanup
-if [ -f $TAR_FILE ]; then
-  rm $TAR_FILE
-fi
--- a/tasks/amazon.yml
+++ b/tasks/amazon.yml
@@ -0,0 +1,70 @@
+---
+
+- name: amazon | check for nvme devices
+  shell: |
+    set -o pipefail
+    cat /proc/partitions | awk '{print $4}' | grep -q nvme. ; echo $?
+  args:
+    executable: /bin/bash
+  register: blkdev_nvme
+  changed_when: false
+
+- name: amazon | check for amazon ebs devices
+  shell: |
+    set -o pipefail
+    lsblk -O -J | grep -qi "amazon elastic block store" ; echo $?
+  register: blkdev_awsebs
+  changed_when: false
+  args:
+    executable: /bin/bash
+
+- name: amazon | set flag for nvme subsystem
+  set_fact:
+    device_is_nvme: "{{ true if (blkdev_nvme.stdout == '0') else false }}"
+
+- name: amazon | set flag for aws ebs devices
+  set_fact:
+    device_is_awsebs: "{{ true if (blkdev_awsebs.stdout == '0') else false }}"
+
+- name: Block to map renamed ec2 ebs nvmeXnY devices to their original sdX/xvdX names
+  when: device_is_nvme and device_is_awsebs|bool
+  become: true
+  block:
+    - name: amazon | download nvme mapping binary helper
+      get_url:
+        url: "{{ ebsnvme_binary_helper_url }}"
+        dest: "{{ ebsnvme_binary_helper_tmp }}/"
+      changed_when: false
+
+    - name: amazon | extract binary helper
+      unarchive:
+        src: "{{ ebsnvme_binary_helper_tmp }}/{{ ebsnvme_binary_helper_file }}"
+        dest: "{{ ebsnvme_binary_helper_tmp }}/"
+        remote_src: yes
+        mode: 0755
+      changed_when: false
+
+    - name: amazon | copy binary helper
+      copy:
+        src: "{{ ebsnvme_binary_helper_tmp }}/go-ebsnvme"
+        dest: "{{ ebsnvme_binary_helper_path }}"
+        mode: a+x
+        remote_src: yes
+
+    - name: amazon | template script helper
+      template:
+        src: 'ebsnvme-id.j2'
+        dest: "{{ ebsnvme_scrip_helper_path }}"
+        mode: a+x
+
+    - name: amazon | template udev rule
+      template:
+        src: '70-ec2-nvme-devices.rules.j2'
+        dest: '/etc/udev/rules.d/70-ec2-nvme-devices.rules'
+        mode: 0755
+      register: udev_rule
+
+    - name: amazon | reload and trigger udev rules
+      shell:
+        cmd: udevadm control --reload-rules && udevadm trigger
+      when: udev_rule.changed
--- a/tasks/centos.yml
+++ b/tasks/centos.yml
@@ -1,14 +1,17 @@
 ---
 - name: centos | installing lvm2
  package:
-    name: "lvm2"
-    state: "present"
+    name: lvm2
+    state: present
  become: true

+- include_tasks: amazon.yml
+  when: ansible_facts.system_vendor == 'Amazon EC2'
+
 - name: centos | installing sg3_utils
  package:
-    name: "sg3_utils"
-    state: "present"
+    name: sg3_utils
+    state: present
  become: true

 - name: centos | debug lvg
@@ -36,12 +39,19 @@
    - lv.1.create|bool

 - name: centos | checking for scsi devices
-  command: "sg_scan"
+  command: sg_scan
  become: true
-  register: "scsi_devices"
+  register: scsi_devices
  changed_when: false

 - name: centos | rescanning for new disks
-  command: "/usr/bin/rescan-scsi-bus.sh"
+  command: /usr/bin/rescan-scsi-bus.sh
  become: true
  changed_when: false
+  when: scsi_devices.stdout|length > 0
+
+- name: centos | rescanning for resized disks
+  command: /usr/bin/rescan-scsi-bus.sh -s
+  become: true
+  changed_when: false
+  when: scsi_devices.stdout|length > 0
--- a/tasks/create_fs.yml
+++ b/tasks/create_fs.yml
@@ -1,110 +1,96 @@
 ---
- name: manage_lvm | unmounting filesystem(s)
-  mount:
-    path: "{{ lv.mntp }}"
-    src: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
-    fstype: "{{ lv.filesystem | default(omit) }}"
-    state: "absent"
-  become: true
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
-  when: >
-    (lv is defined and
-    lv != 'None') and
-    (lv.create is defined and
-    not lv.create and
-    lv.filesystem != "swap")

- name: manage_lvm | creating new filesystem on new LVM logical volume(s)
-  filesystem:
-    fstype: "{{ lv.filesystem }}"
-    dev: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
-    resizefs: yes
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
-  become: true
-  when: >
-    (
-    (vg.create is defined and
-    vg.create) and
-    (lv is defined and
-    lv != 'None') and
-    (lv.create is defined and
-    lv.create) and
-    (
-    lv.filesystem is defined and
-    lv.filesystem != 'None' and
-    lv.filesystem != 'xfs'
-    )
-    )
-  # unable to resize xfs: looks like we've to reference the mountpoint instead of the device
-
- name: lvm | check already converted
+# unable to resize xfs: looks like we've to reference the mountpoint instead of the device
+- name: create_fs | check already converted
  # at least xfs is executed twice if the partition has changed in the meantime
  # then it tries to recreate the fs on the mounted fs which indeed fails...
  shell: "xfs_info {{ lv.mntp }} | grep -c 'ftype=1'"
  become: yes
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
  register: mountedxfs
  ignore_errors: true
-  changed_when: no
-  when: >
-    (
-    (lv is defined and lv != 'None') and
-    (
-    lv.filesystem is defined and
-    lv.filesystem == "xfs"
-    )
-    and
-    (
-    lv.create is defined and
-    lv.create
-    )
-    )
+  changed_when: false
+  when:
+    - lv is defined and lv != 'None'
+    - lv.filesystem is defined
+    - lv.filesystem == "xfs"
+    - lv.create is defined
+    - lv.create|bool

- name: manage_lvm | creating new xfs filesystem on new LVM logical volume(s)
+- name: create_fs | unmounting filesystem(s)
+  mount:
+    path: "{{ lv.mntp }}"
+    src: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
+    fstype: "{{ lv.filesystem | default(omit) }}"
+    state: absent
+  become: true
+  when:
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - not lv.create|bool
+    - lv.filesystem != "swap"
+
+- name: create_fs | creating new filesystem on new LVM logical volume(s)
  filesystem:
    fstype: "{{ lv.filesystem }}"
    dev: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
+    resizefs: yes
  become: true
-  when: >
-    (
-    mountedxfs is failed and
-    (vg.create is defined and
-    vg.create) and
-    (lv is defined and
-    lv != 'None') and
-    (lv.create is defined and
-    lv.create) and
-    (
-    lv.filesystem is defined and
-    lv.filesystem == 'xfs'
-    )
-    )
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+    - lv.filesystem is defined
+    - lv.filesystem != 'None'
+    - lv.filesystem != 'xfs'

- name: manage_lvm | mounting new filesystem(s)
+- name: create_fs | creating new xfs filesystem on new LVM logical volume(s)
+  filesystem:
+    fstype: "{{ lv.filesystem }}"
+    dev: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
+  become: true
+  when:
+    - mountedxfs is failed
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+    - lv.filesystem is defined
+    - lv.filesystem == 'xfs'
+
+- name: create_fs | mounting new filesystem(s)
  mount:
    path: "{{ lv.mntp }}"
    src: "/dev/{{ vg.vgname }}/{{ lv.lvname }}"
    fstype: "{{ lv.filesystem }}"
-    state: "mounted"
+    state: mounted
    opts: "{{ lv.mopts | default('defaults') }}"
  become: true
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
-  when: >
-    ((vg.create is defined and
-    vg.create) and
-    lv != 'None' and
-    (lv.create is defined and
-    lv.create) and
-    (lv.mount is defined and
-    lv.mount))
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+    - lv.mount is defined
+    - lv.mount|bool
+
+- name: create_fs | resizing xfs filesystem on new LVM logical volume(s)
+  command: "xfs_growfs {{ lv.mntp }}"
+  become: true
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+    - lv.filesystem is defined
+    - lv.filesystem == 'xfs'
+    - lvchanged.changed
--- a/tasks/create_lv.yml
+++ b/tasks/create_lv.yml
@@ -1,35 +1,31 @@
 ---
- name: "debug vg"
+
+- name: create_lv | Display Volume Group
  debug:
    var: vg
    verbosity: 2

- name: "debug lvm"
-  loop: "{{ vg.lvnames }}"
-  debug:
-    var: lv
-    verbosity: 1
-  loop_control:
-    loop_var: lv
-
- name: manage_lvm | creating new LVM logical volume(s)
+- name: create_lv | creating new LVM logical volume(s)
  lvol:
    vg: "{{ vg.vgname }}"
    lv: "{{ lv.lvname }}"
    size: "{{ lv.size }}"
-    shrink: no
+    shrink: false
    opts: "{{ lv.opts | default('') }}"
-    state: "present"
-  loop: "{{ vg.lvnames }}"
-  loop_control:
-    loop_var: lv
+    state: present
  become: true
-  when: >
-    (
-    (vg.create is defined
-    and vg.create) and
-    (lv is defined and
-    lv != 'None') and
-    (lv.create is defined and
-    lv.create)
-    )
+  register: lvchanged
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - lv is defined
+    - lv != 'None'
+    - lv.create is defined
+    - lv.create|bool
+
+- name: create_lv | debug changed attribute
+  debug:
+    var: lvchanged
+
+- name: create_lv | configuring FS
+  include_tasks: create_fs.yml
--- a/tasks/create_vg.yml
+++ b/tasks/create_vg.yml
@@ -1,12 +1,29 @@
 ---
-
- name: manage_lvm | creating new LVM volume group(s)
+- name: create_vg | creating new LVM volume group(s)
  lvg:
-    vg: "{{ item.vgname }}"
-    pvs: "{{ item.disks | join(',') }}"
-    state: "present"
+    vg: "{{ vg.vgname }}"
+    pvs: "{{ vg.disks | join(',') }}"
+    state: present
  become: true
-  loop: "{{ lvm_groups }}"
-  when: >
-    item.create is defined and
-    item.create
+  when:
+    - vg.create is defined
+    - vg.create|bool
+
+### workaround: auto pvresize waiting for upgrade to new module supporting integrated pvresize
+###             ref: https://docs.ansible.com/ansible/3/collections/community/general/lvg_module.html
+- name: create_vg | pvresize to max available free space
+  command: "pvresize {{ pv }}"
+  loop: "{{ vg.disks | default([]) }}"
+  loop_control:
+    loop_var: pv
+  changed_when: false
+  when:
+    - vg.create is defined
+    - vg.create|bool
+    - pvresize_to_max|bool
+
+- name: manage_lvm | loop over logical volume group(s) to create logical volumes
+  include_tasks: create_lv.yml
+  loop: "{{ vg.lvnames | default([]) }}"
+  loop_control:
+    loop_var: lv
--- a/tasks/debian.yml
+++ b/tasks/debian.yml
@@ -1,40 +1,40 @@
 ---
+- name: debian | Updating Apt Cache
+  apt:
+    update_cache: true
+    cache_valid_time: 3600
+  become: true
+
 - name: debian | installing pre-reqs
-  package:
+  apt:
    name:
      - lvm2
      - scsitools
-    state: "present"
+    state: present
  become: true

 - name: debian | install xfs tools
-  package:
-    name: "xfsprogs"
-    state: "present"
-  become: yes
+  apt:
+    name: xfsprogs
+    state: present
+  become: true
  loop: "{{ lvm_groups|subelements('lvnames') }}"
-  when: >
-    (
-    (item.1 is defined and item.1 != 'None') and
-    (
-    item.1.filesystem is defined and
-    item.1.filesystem == "xfs"
-    )
-    and
-    (
-    item.1.create is defined and
-    item.1.create
-    )
-    )
+  when:
+    - item.1 is defined
+    - item.1 != 'None'
+    - item.1.filesystem is defined
+    - item.1.filesystem == "xfs"
+    - item.1.create is defined
+    - item.1.create|bool

 - name: debian | checking for scsi devices
-  command: "sg_scan"
+  command: sg_scan
  become: true
-  register: "scsi_devices"
+  register: scsi_devices
  changed_when: false

 - name: debian | rescanning for new disks added
-  command: "/sbin/rescan-scsi-bus"
+  command: /sbin/rescan-scsi-bus
  become: true
  changed_when: false
  when: scsi_devices['stdout'] | length
--- a/tasks/main.yml
+++ b/tasks/main.yml
@@ -1,12 +1,12 @@
 ---
 # tasks file for ansible-manage-lvm
 - include_tasks: debian.yml
-  when: ansible_os_family == "Debian"
+  when: ansible_facts.os_family == "Debian"

 - include_tasks: centos.yml
-  when: ansible_os_family == "RedHat"
+  when: ansible_facts.os_family == "RedHat"

 - include_tasks: manage_lvm.yml
-  when: >
-    manage_lvm and
-    lvm_groups is defined
+  when:
+    - lvm_groups is defined
+    - manage_lvm|bool
--- a/tasks/manage_lvm.yml
+++ b/tasks/manage_lvm.yml
@@ -1,15 +1,6 @@
 ---
 - name: manage_lvm | manage physical volume group creation
  include_tasks: create_vg.yml
-
- name: manage_lvm | loop over logical volume group(s) to create logical volumes
-  include_tasks: create_lv.yml
-  loop: "{{ lvm_groups }}"
-  loop_control:
-    loop_var: vg
-
- name: manage_lvm | loop over logical volume group(s) to create filesystems
-  include_tasks: create_fs.yml
  loop: "{{ lvm_groups }}"
  loop_control:
    loop_var: vg
@@ -18,23 +9,23 @@
  lvol:
    vg: "{{ item.0.vgname }}"
    lv: "{{ item.1.lvname }}"
-    state: "absent"
-    force: yes
+    state: absent
+    force: true
  become: true
-  loop: "{{ lvm_groups|subelements('lvnames') }}"
-  when: >
-    (item.1 is defined and
-    item.1 != 'None') and
-    (item.1.create is defined and
-    not item.1.create)
+  loop: "{{ lvm_groups|subelements('lvnames', {'skip_missing': true}) }}"
+  when:
+    - item.1 is defined
+    - item.1 != 'None'
+    - item.1.create is defined
+    - not item.1.create|bool

 - name: manage_lvm | Removing LVM volume group(s)
  lvg:
    vg: "{{ item.vgname }}"
    pvs: "{{ item.disks | join(',') }}"
-    state: "absent"
+    state: absent
  become: true
  loop: "{{ lvm_groups }}"
-  when: >
-    item.create is defined and
-    not item.create
+  when:
+    - item.create is defined
+    - not item.create|bool
--- a/templates/70-ec2-nvme-devices.rules.j2
+++ b/templates/70-ec2-nvme-devices.rules.j2
@@ -0,0 +1,3 @@
+# ebs nvme to scsi device naming mapping
+KERNEL=="nvme[0-9]*n[0-9]*", ENV{DEVTYPE}=="disk", ATTRS{model}=="Amazon Elastic Block Store", PROGRAM="{{ ebsnvme_scrip_helper_path }} /dev/%k", SYMLINK+="%c"
+
--- a/templates/ebsnvme-id.j2
+++ b/templates/ebsnvme-id.j2
@@ -0,0 +1,15 @@
+#!/bin/bash
+# This script uses go version of ebsnvme-id to provide
+# SCSI Disk device name links for nvme devices
+#
+# links:
+#
+#    https://www.logicworks.com/blog/2018/03/manage-aws-ebs-volumes-c5-m5-puppet-chef-ansible/
+#    https://github.com/mvisonneau/go-ebsnvme
+#    https://gist.github.com/lbernail/d851e5b06eb32180a4b8ead2ce4f45db
+#      and working forks like:
+#      (keenan-v1/ebsnvme-id) https://gist.github.com/keenan-v1/aee92cd7383ee02de2a817a004917a03
+#
+
+{{ ebsnvme_binary_helper_path }} -n $1 | awk -F '/' '{print $3}'
+
--- a/vars/main.yml
+++ b/vars/main.yml
@@ -1,2 +1,5 @@
 ---
 # vars file for ansible-manage-lvm
+
+ebsnvme_binary_helper_file: go-ebsnvme_{{ ebsnvme_binary_helper_ver }}_linux_amd64.tar.gz
+ebsnvme_binary_helper_url:  https://github.com/mvisonneau/go-ebsnvme/releases/download/{{ ebsnvme_binary_helper_ver }}/{{ ebsnvme_binary_helper_file }}
Author	SHA1	Message	Date
Larry Smith Jr	73db3c747c	Merge pull request #68 from stackhpc/ansible-facts Use ansible_facts to reference facts	2021-07-26 14:25:57 -04:00
Mark Goddard	73b6bce608	Use ansible_facts to reference facts By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.<fact>. This change updates all references to Ansible facts from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars	2021-05-13 17:21:42 +01:00
Larry Smith Jr	098bd79154	Merge pull request #64 from mrlesmithjr/issue-63-Add_Probot_configs_for_new_apps Closes Add Probot configs for new apps #63	2021-04-23 20:58:39 -04:00
Larry Smith Jr	fddf9804dd	Closes Add Probot configs for new apps #63	2021-04-23 20:56:44 -04:00
Larry Smith Jr	506da4707e	Create stale.yml	2021-04-23 00:20:15 -04:00
Larry Smith Jr	773ce28061	Merge pull request #57 from Roxyrob/issue-51-nvme mitigation for aws ec2 nvme random device name assignment + scsi device rescan + auto pvresize + skip scsi if scsi adapter not installed	2021-04-18 08:49:45 -04:00
Roxyrob	1bb56066fe	* Doc: set subfile task comments	2021-03-19 19:28:54 +01:00
Roxyrob	cb792e59a6	* Refactor: aws code in its own tasks file to mitigate concerns about performance at scale	2021-03-18 15:38:22 +01:00
Roxyrob	48e3be3c5c	* Refactor: task comment review	2021-03-17 13:46:10 +01:00
Roxyrob	2492c96566	* Fix: allow automatic pvresize also for ansible ersion 2.10 or above without new lvg collection version installed	2021-03-17 10:01:24 +01:00
Roxyrob	e4bc8a9e9b	* Fix: lint	2021-03-17 01:40:26 +01:00
Roxyrob	1d57a469b0	* Fix: pvresize waiting for new collection lvg native support	2021-03-17 01:29:14 +01:00
Roxyrob	19e56ac7d8	* Fix: improve centos7/8 recognize scsi disk resize without reboot	2021-03-17 01:24:15 +01:00
Roxyrob	5c3e601078	* Fix: lint	2021-03-17 01:13:53 +01:00
Roxyrob	535b410363	* Fix: follow best practice for pipe in shell command	2021-03-16 23:24:24 +01:00
Roxyrob	f87c42a8c5	* Fix: remove too many blank lines (molecule)	2021-03-16 20:28:13 +01:00
Roxyrob	34e4f08c31	* New: support mitigation for aws ec2 nvme random device name assignment	2021-03-16 19:41:37 +01:00
Larry Smith Jr	f1a54639c6	Merge pull request #48 from Tcharl/rebased XFS resize	2020-06-07 20:05:35 -04:00
Larry Smith Jr	88489df0ac	Merge pull request #45 from OsgiliathEnterprise/master Allow to define only volume groups	2020-06-07 20:05:22 -04:00
Charlie Mordant	b288695b9a	lint	2020-06-07 17:25:33 +02:00
Charlie Mordant	ed0eb14ce8	xfs resize	2020-06-07 17:17:48 +02:00
Charlie Mordant	9c04be9046	Merge pull request #14 from OsgiliathEnterprise/rebased Rebased from upstream	2020-05-15 00:03:37 +02:00
Charlie Mordant	96fd3b2b06	rebase done	2020-05-14 23:46:35 +02:00
Charlie Mordant	15b2b7b4e0	rebased mrjsmith	2020-05-14 23:43:59 +02:00
Larry Smith Jr	9ead2c9b18	Merge pull request #38 from mrlesmithjr/issue-37 Issue 37	2020-05-14 09:52:39 -04:00
Charlie Mordant	79f4787208	Merge pull request #13 from Tcharl/master Merge pull request #5 from Tcharl/id2	2020-05-11 18:44:01 +02:00
Charlie Mordant	94582de25d	use symbolic links instead of replicating files	2020-05-11 17:38:02 +02:00
Charlie Mordant	6ee72799b4	improve tests	2020-05-11 17:09:58 +02:00
Charlie Mordant	69e25effd4	improve tests	2020-05-11 16:56:04 +02:00
Charlie Mordant	62fc5a5e2b	testing singl lv and only vg	2020-05-11 16:35:31 +02:00
Charlie Mordant	c40f9b7d03	testing singl lv and only vg	2020-05-11 16:35:00 +02:00
Charlie Mordant	0621cadde8	avoid error when lv not defined	2020-05-11 14:36:04 +02:00
Charlie Mordant	b7cef8e323	avoid error when lv not defined	2020-05-11 14:26:48 +02:00
Charlie Mordant	59ffcfac4a	avoid error when lv not defined	2020-05-11 14:23:32 +02:00
Charlie Mordant	976ff31d00	avoid error when lv not defined	2020-05-11 14:21:02 +02:00
Charlie Mordant	78205e51cb	Merge pull request #12 from Tcharl/id2 rename manage_lvm.yml due to recursive parsing error	2020-05-11 13:53:03 +02:00
Charlie Mordant	b731c20100	rename manage_lvm.yml due to recursive parsing error	2020-05-11 13:51:45 +02:00
Charlie Mordant	f2df804926	Merge pull request #11 from OsgiliathEnterprise/id2 Id2	2020-05-11 13:39:16 +02:00
Larry Smith Jr	9f37fa3ed1	Cleaned up tasks These changes include: - Cleaning up logic of conditionals for more clarity - Naming of tasks as some were either missing or incorrect - Removing unnecessary parens, etc. - Closes #37	2020-04-27 13:50:00 -04:00
Larry Smith Jr	c9a9e1660e	Cleaned up conditionals logic	2020-04-27 13:47:43 -04:00
Larry Smith Jr	ec0737d26b	Cleaned up distro specific tasks - Cleaned up conditions, etc.	2020-04-27 13:47:40 -04:00
Larry Smith Jr	52c0270a53	Updated Molecule Vagrant boxes for testing - We need to test against CentOS, Fedora, and Ubuntu - Added my Vagrant boxes to ensure that we know what is included, etc. - This ensures we can at least test these distros locally	2020-04-27 13:46:08 -04:00
Larry Smith Jr	94be28c09b	Updated repo info	2020-04-27 13:43:46 -04:00
Larry Smith Jr	a6b07da847	Added example playbook	2020-04-27 13:43:46 -04:00
Larry Smith Jr	643c7b6ee1	Updated Galaxy meta info	2020-04-27 13:43:46 -04:00
Charlie Mordant	1e997a3e80	Merge pull request #5 from Tcharl/id2 xfs support on centos	2020-04-23 19:56:02 +02:00