Merge pull request #3 from Tcharl/id2

code smells

.github/workflows/molecule.yml

@@ -15,7 +15,7 @@ on:
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
-  # This workflow contains a single job called "build"
+
   lint:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest

.gitignore

@@ -0,0 +1,2 @@
+.idea
+**/__pycache__

.idea/.gitignore

@@ -1,8 +0,0 @@
-# Default ignored files
-/shelf/
-/workspace.xml
-# Datasource local storage ignored files
-/dataSources/
-/dataSources.local.xml
-# Editor-based HTTP Client requests
-/httpRequests/

.idea/ansible-manage-lvm.iml

@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<module type="PYTHON_MODULE" version="4">
-  <component name="NewModuleRootManager">
-    <content url="file://$MODULE_DIR$" />
-    <orderEntry type="inheritedJdk" />
-    <orderEntry type="sourceFolder" forTests="false" />
-  </component>
-</module>

.idea/inspectionProfiles/profiles_settings.xml

@@ -1,6 +0,0 @@
-<component name="InspectionProjectProfileManager">
-  <settings>
-    <option name="USE_PROJECT_PROFILE" value="false" />
-    <version value="1.0" />
-  </settings>
-</component>

.idea/misc.xml

@@ -1,7 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="JavaScriptSettings">
-    <option name="languageLevel" value="ES6" />
-  </component>
-  <component name="ProjectRootManager" version="2" project-jdk-name="Python 3.7" project-jdk-type="Python SDK" />
-</project>

.idea/modules.xml

@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="ProjectModuleManager">
-    <modules>
-      <module fileurl="file://$PROJECT_DIR$/.idea/ansible-manage-lvm.iml" filepath="$PROJECT_DIR$/.idea/ansible-manage-lvm.iml" />
-    </modules>
-  </component>
-</project>

.idea/vcs.xml

@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="VcsDirectoryMappings">
-    <mapping directory="$PROJECT_DIR$" vcs="Git" />
-  </component>
-</project>

tasks/create_fs.yml

@@ -89,12 +89,6 @@
     )
     )
 
-- name: "debug mount"
-  loop: "{{ vg.lvnames }}"
-  debug: var=lv
-  loop_control:
-    loop_var: lv
-
 - name: manage_lvm | mounting new filesystem(s)
   mount:
     path: "{{ lv.mntp }}"

tasks/debian.yml

@@ -7,7 +7,7 @@
     state: "present"
   become: true
 
-- name: centos | install xfs tools
+- name: debian | install xfs tools
   package:
     name: "xfsprogs"
     state: "present"

tasks/main.yml

@@ -1,12 +1,12 @@
 ---
 # tasks file for ansible-manage-lvm
-- include: debian.yml
+- include_tasks: debian.yml
   when: ansible_os_family == "Debian"
 
-- include: centos.yml
+- include_tasks: centos.yml
   when: ansible_os_family == "RedHat"
 
-- include: manage_lvm.yml
+- include_tasks: manage_lvm.yml
   when: >
     manage_lvm and
     lvm_groups is defined

tasks/manage_lvm.yml

@@ -1,15 +1,15 @@
 ---
 - name: manage_lvm | manage physical volume group creation
-  include: create_vg.yml
+  include_tasks: create_vg.yml
 
 - name: manage_lvm | loop over logical volume group(s) to create logical volumes
-  include: create_lv.yml
+  include_tasks: create_lv.yml
   loop: "{{ lvm_groups }}"
   loop_control:
     loop_var: vg
 
 - name: manage_lvm | loop over logical volume group(s) to create filesystems
-  include: create_fs.yml
+  include_tasks: create_fs.yml
   loop: "{{ lvm_groups }}"
   loop_control:
     loop_var: vg