github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-07 18:47:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore(server,cli,web): housekeeping and stricter code style (#6751)

Browse Source 
* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
This commit is contained in:
Jonathan Jogenfors
2024-02-02 04:18:00 +01:00
committed by GitHub
parent e4d0560d49
commit f44fa45aa0
218 changed files with 2471 additions and 1244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/lib/components/photos-page/actions/add-to-album.svelte
View File

@@ -26,7 +26,7 @@
const handleAddToNewAlbum = (albumName: string) => {
showAlbumPicker = false;
const assetIds = Array.from(getAssets()).map((asset) => asset.id);
const assetIds = [...getAssets()].map((asset) => asset.id);
api.albumApi.createAlbum({ createAlbumDto: { albumName, assetIds } }).then((response) => {
const { id, albumName } = response.data;
@@ -43,7 +43,7 @@
const handleAddToAlbum = async (album: AlbumResponseDto) => {
showAlbumPicker = false;
const assetIds = Array.from(getAssets()).map((asset) => asset.id);
const assetIds = [...getAssets()].map((asset) => asset.id);
await addAssetsToAlbum(album.id, assetIds);
clearSelect();
};

2
web/src/lib/components/photos-page/actions/archive-action.svelte
View File

@@ -28,7 +28,7 @@
loading = true;
try {
const assets = Array.from(getOwnedAssets()).filter((asset) => asset.isArchived !== isArchived);
const assets = [...getOwnedAssets()].filter((asset) => asset.isArchived !== isArchived);
const ids = assets.map(({ id }) => id);
if (ids.length > 0) {

4
web/src/lib/components/photos-page/actions/asset-job-actions.svelte
View File

@@ -16,11 +16,11 @@
const { clearSelect, getOwnedAssets } = getAssetControlContext();
$: isAllVideos = Array.from(getOwnedAssets()).every((asset) => asset.type === AssetTypeEnum.Video);
$: isAllVideos = [...getOwnedAssets()].every((asset) => asset.type === AssetTypeEnum.Video);
const handleRunJob = async (name: AssetJobName) => {
try {
const ids = Array.from(getOwnedAssets()).map(({ id }) => id);
const ids = [...getOwnedAssets()].map(({ id }) => id);
await api.assetApi.runAssetJobs({ assetJobsDto: { assetIds: ids, name } });
notificationController.show({ message: api.getAssetJobMessage(name), type: NotificationType.Info });
clearSelect();

2
web/src/lib/components/photos-page/actions/create-shared-link.svelte
View File

@@ -20,7 +20,7 @@
{#if showModal}
<CreateSharedLinkModal
assetIds={Array.from(getAssets()).map(({ id }) => id)}
assetIds={[...getAssets()].map(({ id }) => id)}
on:close={() => (showModal = false)}
on:escape={escape}
/>

4
web/src/lib/components/photos-page/actions/delete-assets.svelte
View File

@@ -32,9 +32,7 @@
const handleDelete = async () => {
loading = true;
const ids = Array.from(getOwnedAssets())
.filter((a) => !a.isExternal)
.map((a) => a.id);
const ids = [...getOwnedAssets()].filter((a) => !a.isExternal).map((a) => a.id);
await deleteAssets(force, onAssetDelete, ids);
clearSelect();
isShowConfirmation = false;

2
web/src/lib/components/photos-page/actions/download-action.svelte
View File

@@ -11,7 +11,7 @@
const { getAssets, clearSelect } = getAssetControlContext();
const handleDownloadFiles = async () => {
const assets = Array.from(getAssets());
const assets = [...getAssets()];
if (assets.length === 1) {
clearSelect();
await downloadFile(assets[0]);

2
web/src/lib/components/photos-page/actions/favorite-action.svelte
View File

@@ -28,7 +28,7 @@
loading = true;
try {
const assets = Array.from(getOwnedAssets()).filter((asset) => asset.isFavorite !== isFavorite);
const assets = [...getOwnedAssets()].filter((asset) => asset.isFavorite !== isFavorite);
const ids = assets.map(({ id }) => id);

8
web/src/lib/components/photos-page/actions/remove-from-album.svelte
View File

@@ -11,7 +11,7 @@
import { mdiDeleteOutline } from '@mdi/js';
export let album: AlbumResponseDto;
export let onRemove: ((assetIds: string[]) => void) | undefined = undefined;
export let onRemove: ((assetIds: string[]) => void) | undefined;
export let menuItem = false;
const { getAssets, clearSelect } = getAssetControlContext();
@@ -20,7 +20,7 @@
const removeFromAlbum = async () => {
try {
const ids = Array.from(getAssets()).map((a) => a.id);
const ids = [...getAssets()].map((a) => a.id);
const { data: results } = await api.albumApi.removeAssetFromAlbum({
id: album.id,
bulkIdsDto: { ids },
@@ -38,8 +38,8 @@
});
clearSelect();
} catch (e) {
console.error('Error [album-viewer] [removeAssetFromAlbum]', e);
} catch (error) {
console.error('Error [album-viewer] [removeAssetFromAlbum]', error);
notificationController.show({
type: NotificationType.Error,
message: 'Error removing assets from album, check console for more details',

2
web/src/lib/components/photos-page/actions/remove-from-shared-link.svelte
View File

@@ -18,7 +18,7 @@
const { data: results } = await api.sharedLinkApi.removeSharedLinkAssets({
id: sharedLink.id,
assetIdsDto: {
assetIds: Array.from(getAssets()).map((asset) => asset.id),
assetIds: [...getAssets()].map((asset) => asset.id),
},
key: api.getKey(),
});

8
web/src/lib/components/photos-page/actions/restore-assets.svelte
View File

@@ -11,7 +11,7 @@
import { mdiHistory } from '@mdi/js';
import type { OnRestore } from '$lib/utils/actions';
export let onRestore: OnRestore | undefined = undefined;
export let onRestore: OnRestore | undefined;
const { getAssets, clearSelect } = getAssetControlContext();
@@ -21,7 +21,7 @@
loading = true;
try {
const ids = Array.from(getAssets()).map((a) => a.id);
const ids = [...getAssets()].map((a) => a.id);
await api.trashApi.restoreAssets({ bulkIdsDto: { ids } });
onRestore?.(ids);
@@ -31,8 +31,8 @@
});
clearSelect();
} catch (e) {
handleError(e, 'Error restoring assets');
} catch (error) {
handleError(error, 'Error restoring assets');
} finally {
loading = false;
}

4
web/src/lib/components/photos-page/actions/select-all-assets.svelte
View File

@@ -28,8 +28,8 @@
}
selecting = false;
} catch (e) {
handleError(e, 'Error selecting all assets');
} catch (error) {
handleError(error, 'Error selecting all assets');
}
};
</script>

6
web/src/lib/components/photos-page/actions/stack-action.svelte
View File

@@ -9,13 +9,13 @@
import { handleError } from '$lib/utils/handle-error';
import type { OnStack } from '$lib/utils/actions';
export let onStack: OnStack | undefined = undefined;
export let onStack: OnStack | undefined;
const { clearSelect, getOwnedAssets } = getAssetControlContext();
const handleStack = async () => {
try {
const assets = Array.from(getOwnedAssets());
const assets = [...getOwnedAssets()];
const parent = assets.at(0);
if (parent == undefined) {
@@ -33,7 +33,7 @@
for (const asset of children) {
asset.stackParentId = parent?.id;
// Add grand-children's count to new parent
childrenCount += asset.stackCount == null ? 1 : asset.stackCount + 1;
childrenCount += asset.stackCount == undefined ? 1 : asset.stackCount + 1;
// Reset children stack info
asset.stackCount = null;
asset.stack = [];