feat(server,web): remove external path nonsense and make libraries admin-only (#7237)

* remove external path

* open-api

* make sql

* move library settings to admin panel

* Add documentation

* show external libraries only

* fix library list

* make user library settings look good

* fix test

* fix tests

* fix tests

* can pick user for library

* fix tests

* fix e2e

* chore: make sql

* Use unauth exception

* delete user library list

* cleanup

* fix e2e

* fix await lint

* chore: remove unused code

* chore: cleanup

* revert docs

* fix: is admin stuff

* table alignment

---------

Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Co-authored-by: Alex Tran <alex.tran1502@gmail.com>

server/src/domain/user/dto/create-user.dto.ts

@@ -21,10 +21,6 @@ export class CreateUserDto {
   @Transform(toSanitized)
   storageLabel?: string | null;
 
-  @Optional({ nullable: true })
-  @IsString()
-  externalPath?: string | null;
-
   @Optional()
   @IsBoolean()
   memoriesEnabled?: boolean;

server/src/domain/user/dto/update-user.dto.ts

@@ -25,10 +25,6 @@ export class UpdateUserDto {
   @Transform(toSanitized)
   storageLabel?: string;
 
-  @Optional()
-  @IsString()
-  externalPath?: string;
-
   @IsNotEmpty()
   @IsUUID('4')
   @ApiProperty({ format: 'uuid' })

server/src/domain/user/response-dto/user-response.dto.ts

@@ -22,7 +22,6 @@ export class UserDto {
 
 export class UserResponseDto extends UserDto {
   storageLabel!: string | null;
-  externalPath!: string | null;
   shouldChangePassword!: boolean;
   isAdmin!: boolean;
   createdAt!: Date;
@@ -50,7 +49,6 @@ export function mapUser(entity: UserEntity): UserResponseDto {
   return {
     ...mapSimpleUser(entity),
     storageLabel: entity.storageLabel,
-    externalPath: entity.externalPath,
     shouldChangePassword: entity.shouldChangePassword,
     isAdmin: entity.isAdmin,
     createdAt: entity.createdAt,

server/src/domain/user/user.core.ts

@@ -1,6 +1,5 @@
 import { LibraryType, UserEntity } from '@app/infra/entities';
 import { BadRequestException, ForbiddenException } from '@nestjs/common';
-import path from 'node:path';
 import sanitize from 'sanitize-filename';
 import { ICryptoRepository, ILibraryRepository, IUserRepository } from '../repositories';
 import { UserResponseDto } from './response-dto';
@@ -42,7 +41,6 @@ export class UserCore {
       // Users can never update the isAdmin property.
       delete dto.isAdmin;
       delete dto.storageLabel;
-      delete dto.externalPath;
     } else if (dto.isAdmin && user.id !== id) {
       // Admin cannot create another admin.
       throw new BadRequestException('The server already has an admin');
@@ -70,12 +68,6 @@ export class UserCore {
       dto.storageLabel = null;
     }
 
-    if (dto.externalPath === '') {
-      dto.externalPath = null;
-    } else if (dto.externalPath) {
-      dto.externalPath = path.normalize(dto.externalPath);
-    }
-
     return this.userRepository.update(id, dto);
   }