chore: dart http foreground upload (#24883)

* feat: bring back manual backup

* expose iCloud retrieval progress

* wip

* unify http upload method, check for connectivity on iOS

* handle LivePhotos progress

* feat: speed calculation

* wip

* better upload detail page

* handle error

* handle error

* pr feedback

* feat: share intent upload

* feat: manual upload

* feat: manual upload progress

* chore: styling

* refactor

* refactor

* remove unused logs

* fix: background android backup

* feat: add error section

* remove complete section

* remove empty state and prevent slot jumps

* more refactor

* fix: background test

* chore: add metadata to foreground upload

* fix: email and name get reset in auth provider

* pr feedback

* remove version check for metadata field in upload payload

* chore: fix unit test

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>

mobile/test/domain/service.mock.dart

@@ -3,7 +3,7 @@ import 'package:immich_mobile/domain/services/user.service.dart';
 import 'package:immich_mobile/domain/utils/background_sync.dart';
 import 'package:immich_mobile/platform/native_sync_api.g.dart';
 import 'package:immich_mobile/services/app_settings.service.dart';
-import 'package:immich_mobile/services/upload.service.dart';
+import 'package:immich_mobile/services/background_upload.service.dart';
 import 'package:mocktail/mocktail.dart';
 
 class MockStoreService extends Mock implements StoreService {}
@@ -16,5 +16,5 @@ class MockNativeSyncApi extends Mock implements NativeSyncApi {}
 
 class MockAppSettingsService extends Mock implements AppSettingsService {}
 
-class MockUploadService extends Mock implements UploadService {}
+class MockBackgroundUploadService extends Mock implements BackgroundUploadService {}
 

mobile/test/services/auth.service_test.dart

@@ -21,7 +21,6 @@ void main() {
   late MockApiService apiService;
   late MockNetworkService networkService;
   late MockBackgroundSyncManager backgroundSyncManager;
-  late MockUploadService uploadService;
   late MockAppSettingService appSettingsService;
   late Isar db;
 
@@ -31,7 +30,6 @@ void main() {
     apiService = MockApiService();
     networkService = MockNetworkService();
     backgroundSyncManager = MockBackgroundSyncManager();
-    uploadService = MockUploadService();
     appSettingsService = MockAppSettingService();
 
     sut = AuthService(
@@ -118,7 +116,6 @@ void main() {
       when(() => authApiRepository.logout()).thenAnswer((_) async => {});
       when(() => backgroundSyncManager.cancel()).thenAnswer((_) async => {});
       when(() => authRepository.clearLocalData()).thenAnswer((_) => Future.value(null));
-      when(() => uploadService.cancelBackup()).thenAnswer((_) => Future.value(1));
       when(
         () => appSettingsService.setSetting(AppSettingsEnum.enableBackup, false),
       ).thenAnswer((_) => Future.value(null));
@@ -133,7 +130,6 @@ void main() {
       when(() => authApiRepository.logout()).thenThrow(Exception('Server error'));
       when(() => backgroundSyncManager.cancel()).thenAnswer((_) async => {});
       when(() => authRepository.clearLocalData()).thenAnswer((_) => Future.value(null));
-      when(() => uploadService.cancelBackup()).thenAnswer((_) => Future.value(1));
       when(
         () => appSettingsService.setSetting(AppSettingsEnum.enableBackup, false),
       ).thenAnswer((_) => Future.value(null));

mobile/test/services/background_upload.service_test.dart

@@ -12,13 +12,8 @@ import 'package:immich_mobile/domain/services/store.service.dart';
 import 'package:immich_mobile/entities/store.entity.dart';
 import 'package:immich_mobile/infrastructure/repositories/db.repository.dart';
 import 'package:immich_mobile/infrastructure/repositories/store.repository.dart';
-import 'package:immich_mobile/models/server_info/server_config.model.dart';
-import 'package:immich_mobile/models/server_info/server_disk_info.model.dart';
-import 'package:immich_mobile/models/server_info/server_features.model.dart';
-import 'package:immich_mobile/models/server_info/server_info.model.dart';
-import 'package:immich_mobile/models/server_info/server_version.model.dart';
 import 'package:immich_mobile/services/app_settings.service.dart';
-import 'package:immich_mobile/services/upload.service.dart';
+import 'package:immich_mobile/services/background_upload.service.dart';
 import 'package:mocktail/mocktail.dart';
 
 import '../domain/service.mock.dart';
@@ -27,33 +22,12 @@ import '../infrastructure/repository.mock.dart';
 import '../mocks/asset_entity.mock.dart';
 import '../repository.mocks.dart';
 
-// Test ServerInfo stub
-const _serverInfo = ServerInfo(
-  serverVersion: ServerVersion(major: 2, minor: 4, patch: 0),
-  latestVersion: ServerVersion(major: 2, minor: 4, patch: 0),
-  serverFeatures: ServerFeatures(trash: true, map: true, oauthEnabled: false, passwordLogin: true, ocr: false),
-  serverConfig: ServerConfig(
-    trashDays: 30,
-    oauthButtonText: 'Login with OAuth',
-    externalDomain: '',
-    mapDarkStyleUrl: '',
-    mapLightStyleUrl: '',
-  ),
-  serverDiskInfo: ServerDiskInfo(
-    diskAvailable: '100GB',
-    diskSize: '500GB',
-    diskUse: '400GB',
-    diskUsagePercentage: 80.0,
-  ),
-  versionStatus: VersionStatus.upToDate,
-);
-
 void main() {
-  late UploadService sut;
+  late BackgroundUploadService sut;
   late MockUploadRepository mockUploadRepository;
-  late MockDriftBackupRepository mockBackupRepository;
   late MockStorageRepository mockStorageRepository;
   late MockDriftLocalAssetRepository mockLocalAssetRepository;
+  late MockDriftBackupRepository mockBackupRepository;
   late MockAppSettingsService mockAppSettingsService;
   late MockAssetMediaRepository mockAssetMediaRepository;
   late Drift db;
@@ -75,23 +49,22 @@ void main() {
 
   setUp(() {
     mockUploadRepository = MockUploadRepository();
-    mockBackupRepository = MockDriftBackupRepository();
     mockStorageRepository = MockStorageRepository();
     mockLocalAssetRepository = MockDriftLocalAssetRepository();
+    mockBackupRepository = MockDriftBackupRepository();
     mockAppSettingsService = MockAppSettingsService();
     mockAssetMediaRepository = MockAssetMediaRepository();
 
     when(() => mockAppSettingsService.getSetting(AppSettingsEnum.useCellularForUploadVideos)).thenReturn(false);
     when(() => mockAppSettingsService.getSetting(AppSettingsEnum.useCellularForUploadPhotos)).thenReturn(false);
 
-    sut = UploadService(
+    sut = BackgroundUploadService(
       mockUploadRepository,
-      mockBackupRepository,
       mockStorageRepository,
       mockLocalAssetRepository,
+      mockBackupRepository,
       mockAppSettingsService,
       mockAssetMediaRepository,
-      _serverInfo,
     );
 
     mockUploadRepository.onUploadStatus = (_) {};
@@ -201,14 +174,13 @@ void main() {
       debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
       addTearDown(() => debugDefaultTargetPlatformOverride = null);
 
-      final sutWithV24 = UploadService(
+      final sutWithV24 = BackgroundUploadService(
         mockUploadRepository,
-        mockBackupRepository,
         mockStorageRepository,
         mockLocalAssetRepository,
+        mockBackupRepository,
         mockAppSettingsService,
         mockAssetMediaRepository,
-        _serverInfo,
       );
       addTearDown(() => sutWithV24.dispose());
 
@@ -247,61 +219,17 @@ void main() {
       expect(metadata[0]['value']['longitude'], isNotNull);
     });
 
-    test('should NOT include metadata on iOS when server version is below 2.4', () async {
-      debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
-      addTearDown(() => debugDefaultTargetPlatformOverride = null);
-
-      final sutWithV23 = UploadService(
-        mockUploadRepository,
-        mockBackupRepository,
-        mockStorageRepository,
-        mockLocalAssetRepository,
-        mockAppSettingsService,
-        mockAssetMediaRepository,
-        _serverInfo.copyWith(
-          serverVersion: const ServerVersion(major: 2, minor: 3, patch: 0),
-          latestVersion: const ServerVersion(major: 2, minor: 3, patch: 0),
-        ),
-      );
-      addTearDown(() => sutWithV23.dispose());
-
-      final assetWithCloudId = LocalAsset(
-        id: 'test-asset-id',
-        name: 'test.jpg',
-        type: AssetType.image,
-        createdAt: DateTime(2025, 1, 1),
-        updatedAt: DateTime(2025, 1, 2),
-        cloudId: 'cloud-id-123',
-        latitude: 37.7749,
-        longitude: -122.4194,
-      );
-
-      final mockEntity = MockAssetEntity();
-      final mockFile = File('/path/to/test.jpg');
-
-      when(() => mockEntity.isLivePhoto).thenReturn(false);
-      when(() => mockStorageRepository.getAssetEntityForAsset(assetWithCloudId)).thenAnswer((_) async => mockEntity);
-      when(() => mockStorageRepository.getFileForAsset(assetWithCloudId.id)).thenAnswer((_) async => mockFile);
-      when(() => mockAssetMediaRepository.getOriginalFilename(assetWithCloudId.id)).thenAnswer((_) async => 'test.jpg');
-
-      final task = await sutWithV23.getUploadTask(assetWithCloudId);
-
-      expect(task, isNotNull);
-      expect(task!.fields.containsKey('metadata'), isFalse);
-    });
-
     test('should NOT include metadata on Android regardless of server version', () async {
       debugDefaultTargetPlatformOverride = TargetPlatform.android;
       addTearDown(() => debugDefaultTargetPlatformOverride = null);
 
-      final sutAndroid = UploadService(
+      final sutAndroid = BackgroundUploadService(
         mockUploadRepository,
-        mockBackupRepository,
         mockStorageRepository,
         mockLocalAssetRepository,
+        mockBackupRepository,
         mockAppSettingsService,
         mockAssetMediaRepository,
-        _serverInfo,
       );
       addTearDown(() => sutAndroid.dispose());
 
@@ -334,14 +262,13 @@ void main() {
       debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
       addTearDown(() => debugDefaultTargetPlatformOverride = null);
 
-      final sutWithV24 = UploadService(
+      final sutWithV24 = BackgroundUploadService(
         mockUploadRepository,
-        mockBackupRepository,
         mockStorageRepository,
         mockLocalAssetRepository,
+        mockBackupRepository,
         mockAppSettingsService,
         mockAssetMediaRepository,
-        _serverInfo,
       );
       addTearDown(() => sutWithV24.dispose());
 
@@ -374,14 +301,13 @@ void main() {
       debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
       addTearDown(() => debugDefaultTargetPlatformOverride = null);
 
-      final sutWithV24 = UploadService(
+      final sutWithV24 = BackgroundUploadService(
         mockUploadRepository,
-        mockBackupRepository,
         mockStorageRepository,
         mockLocalAssetRepository,
+        mockBackupRepository,
         mockAppSettingsService,
         mockAssetMediaRepository,
-        _serverInfo,
       );
       addTearDown(() => sutWithV24.dispose());