github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-28 09:38:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

test: thumbnail selector (#26383)

Browse Source 
* test: face ordering issue/flakiness

* test: thumbnail selector
This commit is contained in:
Min Idzelis
2026-02-20 10:04:17 -05:00
committed by GitHub
parent 18bf96b4b2
commit aae64b5e2f
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
e2e/src/ui/specs/timeline/utils.ts
View File

@@ -65,7 +65,7 @@ export const thumbnailUtils = {
return page.locator(`[data-thumbnail-focus-container][data-asset="${assetId}"] button`); return page.locator(`[data-thumbnail-focus-container][data-asset="${assetId}"] button`);
}, },
selectedAsset(page: Page) { selectedAsset(page: Page) {
return page.locator('[data-thumbnail-focus-container]:has(button[aria-checked])'); return page.locator('[data-thumbnail-focus-container][data-selected]');
}, },
async clickAssetId(page: Page, assetId: string) { async clickAssetId(page: Page, assetId: string) {
await thumbnailUtils.withAssetId(page, assetId).click(); await thumbnailUtils.withAssetId(page, assetId).click();
@@ -103,11 +103,8 @@ export const thumbnailUtils = {
await expect(thumbnailUtils.withAssetId(page, assetId).locator('[data-icon-archive]')).toHaveCount(0); await expect(thumbnailUtils.withAssetId(page, assetId).locator('[data-icon-archive]')).toHaveCount(0);
}, },
async expectSelectedReadonly(page: Page, assetId: string) { async expectSelectedReadonly(page: Page, assetId: string) {
// todo - need a data attribute for selected
await expect( await expect(
page.locator( page.locator(`[data-thumbnail-focus-container][data-asset="${assetId}"][data-selected]`),
`[data-thumbnail-focus-container][data-asset="${assetId}"] > .group.cursor-not-allowed > .rounded-xl`,
),
).toBeVisible(); ).toBeVisible();
}, },
async expectTimelineHasOnScreenAssets(page: Page) { async expectTimelineHasOnScreenAssets(page: Page) {

1
web/src/lib/components/assets/thumbnail/thumbnail.svelte
View File

@@ -223,6 +223,7 @@
bind:this={element} bind:this={element}
data-asset={asset.id} data-asset={asset.id}
data-thumbnail-focus-container data-thumbnail-focus-container
data-selected={selected ? true : undefined}
tabindex={0} tabindex={0}
role="link" role="link"
> >