github-mirrors/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 01:59:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat(server): check additional exif date tags (#19216)

Browse Source 
* feat(server): check additional exif date tags

- Add support for UTC date tags (GPSDateTime, DateTimeUTC, GPSDateStamp, SonyDateTime2)
- This matches tags that exiftool-vendored uses for tzSource in extractTzOffsetFromUTCOffset()

* Review comments

* nit

* review comments

* lots of tests for exif datetime

* missed

* format

* format again

---------

Co-authored-by: Alex <alex.tran1502@gmail.com>
This commit is contained in:
Min Idzelis
2025-06-26 11:18:40 -04:00
committed by GitHub
parent a43159f4ba
commit 934649c8df
7 changed files with 1213 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
server/src/services/metadata.service.spec.ts
View File

@@ -6,7 +6,7 @@ import { defaults } from 'src/config';
import { MapAsset } from 'src/dtos/asset-response.dto';
import { AssetType, AssetVisibility, ExifOrientation, ImmichWorker, JobName, JobStatus, SourceType } from 'src/enum';
import { ImmichTags } from 'src/repositories/metadata.repository';
import { MetadataService } from 'src/services/metadata.service';
import { firstDateTime, MetadataService } from 'src/services/metadata.service';
import { assetStub } from 'test/fixtures/asset.stub';
import { fileStub } from 'test/fixtures/file.stub';
import { probeStub } from 'test/fixtures/media.stub';
@@ -1639,4 +1639,80 @@ describe(MetadataService.name, () => {
});
});
});
describe('firstDateTime', () => {
it('should ignore date-only tags like GPSDateStamp', () => {
const tags = {
GPSDateStamp: '2023:08:08', // Date-only tag, should be ignored
SonyDateTime2: '2023:07:07 07:00:00',
};
const result = firstDateTime(tags);
expect(result?.tag).toBe('SonyDateTime2');
expect(result?.dateTime?.toDate()?.toISOString()).toBe('2023-07-07T07:00:00.000Z');
});
it('should respect full priority order with all date tags present', () => {
const tags = {
// SubSec and standard EXIF date tags
SubSecDateTimeOriginal: '2023:01:01 01:00:00',
SubSecCreateDate: '2023:02:02 02:00:00',
SubSecMediaCreateDate: '2023:03:03 03:00:00',
DateTimeOriginal: '2023:04:04 04:00:00',
CreateDate: '2023:05:05 05:00:00',
MediaCreateDate: '2023:06:06 06:00:00',
CreationDate: '2023:07:07 07:00:00',
DateTimeCreated: '2023:08:08 08:00:00',
// Additional date tags
TimeCreated: '2023:09:09 09:00:00',
GPSDateTime: '2023:10:10 10:00:00',
DateTimeUTC: '2023:11:11 11:00:00',
GPSDateStamp: '2023:12:12', // Date-only tag, should be ignored
SonyDateTime2: '2023:13:13 13:00:00',
// Non-standard tag
SourceImageCreateTime: '2023:14:14 14:00:00',
};
const result = firstDateTime(tags);
// Should use SubSecDateTimeOriginal as it has highest priority
expect(result?.tag).toBe('SubSecDateTimeOriginal');
expect(result?.dateTime?.toDate()?.toISOString()).toBe('2023-01-01T01:00:00.000Z');
});
it('should handle missing SubSec tags and use available date tags', () => {
const tags = {
// Standard date tags
CreationDate: '2023:07:07 07:00:00',
DateTimeCreated: '2023:08:08 08:00:00',
// Additional date tags
TimeCreated: '2023:09:09 09:00:00',
GPSDateTime: '2023:10:10 10:00:00',
DateTimeUTC: '2023:11:11 11:00:00',
GPSDateStamp: '2023:12:12', // Date-only tag, should be ignored
SonyDateTime2: '2023:13:13 13:00:00',
};
const result = firstDateTime(tags);
// Should use CreationDate when available
expect(result?.tag).toBe('CreationDate');
expect(result?.dateTime?.toDate()?.toISOString()).toBe('2023-07-07T07:00:00.000Z');
});
it('should handle invalid date formats gracefully', () => {
const tags = {
TimeCreated: 'invalid-date',
GPSDateTime: '2023:10:10 10:00:00',
DateTimeUTC: 'also-invalid',
SonyDateTime2: '2023:13:13 13:00:00',
};
const result = firstDateTime(tags);
// Should skip invalid dates and use the first valid one
expect(result?.tag).toBe('GPSDateTime');
expect(result?.dateTime?.toDate()?.toISOString()).toBe('2023-10-10T10:00:00.000Z');
});
});
});