mirror of
https://github.com/immich-app/immich.git
synced 2026-03-22 11:49:46 +03:00
fix(web): fix zoom touch event handling (#26866)
fix(web): fix zoom touch event handling and add clarifying comments - Suppress Safari's synthetic dblclick on double-tap which conflicts with zoom-image's touchstart-based zoom - Add comment explaining pointer-events-none on zoom transform wrapper - Add comments for touchAction and overflow style overrides
This commit is contained in:
@@ -23,7 +23,25 @@ export const zoomImageAction = (node: HTMLElement, options?: { disabled?: boolea
|
|||||||
node.addEventListener('wheel', onInteractionStart, { capture: true });
|
node.addEventListener('wheel', onInteractionStart, { capture: true });
|
||||||
node.addEventListener('pointerdown', onInteractionStart, { capture: true });
|
node.addEventListener('pointerdown', onInteractionStart, { capture: true });
|
||||||
|
|
||||||
|
// Suppress Safari's synthetic dblclick on double-tap. Without this, zoom-image's touchstart
|
||||||
|
// handler zooms to maxZoom (10x), then Safari's synthetic dblclick triggers photo-viewer's
|
||||||
|
// handler which conflicts. Chrome does not fire synthetic dblclick on touch.
|
||||||
|
let lastPointerWasTouch = false;
|
||||||
|
const trackPointerType = (event: PointerEvent) => {
|
||||||
|
lastPointerWasTouch = event.pointerType === 'touch';
|
||||||
|
};
|
||||||
|
const suppressTouchDblClick = (event: MouseEvent) => {
|
||||||
|
if (lastPointerWasTouch) {
|
||||||
|
event.stopImmediatePropagation();
|
||||||
|
}
|
||||||
|
};
|
||||||
|
node.addEventListener('pointerdown', trackPointerType, { capture: true });
|
||||||
|
node.addEventListener('dblclick', suppressTouchDblClick, { capture: true });
|
||||||
|
|
||||||
|
// Allow zoomed content to render outside the container bounds
|
||||||
node.style.overflow = 'visible';
|
node.style.overflow = 'visible';
|
||||||
|
// Prevent browser handling of touch gestures so zoom-image can manage them
|
||||||
|
node.style.touchAction = 'none';
|
||||||
return {
|
return {
|
||||||
update(newOptions?: { disabled?: boolean }) {
|
update(newOptions?: { disabled?: boolean }) {
|
||||||
options = newOptions;
|
options = newOptions;
|
||||||
@@ -34,6 +52,8 @@ export const zoomImageAction = (node: HTMLElement, options?: { disabled?: boolea
|
|||||||
}
|
}
|
||||||
node.removeEventListener('wheel', onInteractionStart, { capture: true });
|
node.removeEventListener('wheel', onInteractionStart, { capture: true });
|
||||||
node.removeEventListener('pointerdown', onInteractionStart, { capture: true });
|
node.removeEventListener('pointerdown', onInteractionStart, { capture: true });
|
||||||
|
node.removeEventListener('pointerdown', trackPointerType, { capture: true });
|
||||||
|
node.removeEventListener('dblclick', suppressTouchDblClick, { capture: true });
|
||||||
zoomInstance.cleanup();
|
zoomInstance.cleanup();
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -162,8 +162,9 @@
|
|||||||
<div class="relative h-full w-full overflow-hidden will-change-transform" bind:this={ref}>
|
<div class="relative h-full w-full overflow-hidden will-change-transform" bind:this={ref}>
|
||||||
{@render backdrop?.()}
|
{@render backdrop?.()}
|
||||||
|
|
||||||
|
<!-- pointer-events-none so events pass through to the container where zoom-image listens -->
|
||||||
<div
|
<div
|
||||||
class="absolute inset-0"
|
class="absolute inset-0 pointer-events-none"
|
||||||
style:transform={zoomTransform}
|
style:transform={zoomTransform}
|
||||||
style:transform-origin={zoomTransform ? '0 0' : undefined}
|
style:transform-origin={zoomTransform ? '0 0' : undefined}
|
||||||
>
|
>
|
||||||
|
|||||||
Reference in New Issue
Block a user