refactor: user factories instead of stubs (#17540)

server/test/fixtures/auth.stub.ts

@@ -52,24 +52,4 @@ export const authStub = {
       key: Buffer.from('shared-link-key'),
     } as SharedLinkEntity,
   }),
-  adminSharedLinkNoExif: Object.freeze<AuthDto>({
-    user: authUser.admin,
-    sharedLink: {
-      id: '123',
-      showExif: false,
-      allowDownload: true,
-      allowUpload: true,
-      key: Buffer.from('shared-link-key'),
-    } as SharedLinkEntity,
-  }),
-  passwordSharedLink: Object.freeze<AuthDto>({
-    user: authUser.admin,
-    sharedLink: {
-      id: '123',
-      allowUpload: false,
-      allowDownload: false,
-      password: 'password-123',
-      showExif: true,
-    } as SharedLinkEntity,
-  }),
 };

server/test/fixtures/user.stub.ts

@@ -57,36 +57,4 @@ export const userStub = {
     quotaSizeInBytes: null,
     quotaUsageInBytes: 0,
   },
-  storageLabel: <UserAdmin>{
-    ...authStub.user1.user,
-    status: UserStatus.ACTIVE,
-    profileChangedAt: new Date('2021-01-01'),
-    metadata: [],
-    name: 'immich_name',
-    storageLabel: 'label-1',
-    oauthId: '',
-    shouldChangePassword: false,
-    profileImagePath: '',
-    createdAt: new Date('2021-01-01'),
-    deletedAt: null,
-    updatedAt: new Date('2021-01-01'),
-    quotaSizeInBytes: null,
-    quotaUsageInBytes: 0,
-  },
-  profilePath: <UserAdmin>{
-    ...authStub.user1.user,
-    status: UserStatus.ACTIVE,
-    profileChangedAt: new Date('2021-01-01'),
-    metadata: [],
-    name: 'immich_name',
-    storageLabel: 'label-1',
-    oauthId: '',
-    shouldChangePassword: false,
-    profileImagePath: '/path/to/profile.jpg',
-    createdAt: new Date('2021-01-01'),
-    deletedAt: null,
-    updatedAt: new Date('2021-01-01'),
-    quotaSizeInBytes: null,
-    quotaUsageInBytes: 0,
-  },
 };

server/test/small.factory.ts

@@ -4,6 +4,7 @@ import {
   ApiKey,
   Asset,
   AuthApiKey,
+  AuthSharedLink,
   AuthUser,
   Library,
   Memory,
@@ -35,12 +36,20 @@ export const newEmbedding = () => {
 const authFactory = ({
   apiKey,
   session,
-  ...user
-}: Partial<AuthUser> & { apiKey?: Partial<AuthApiKey>; session?: { id: string } } = {}) => {
+  sharedLink,
+  user,
+}: {
+  apiKey?: Partial<AuthApiKey>;
+  session?: { id: string };
+  user?: Partial<UserAdmin>;
+  sharedLink?: Partial<AuthSharedLink>;
+} = {}) => {
   const auth: AuthDto = {
-    user: authUserFactory(user),
+    user: authUserFactory(userAdminFactory(user ?? {})),
   };
 
+  const userId = auth.user.id;
+
   if (apiKey) {
     auth.apiKey = authApiKeyFactory(apiKey);
   }
@@ -49,24 +58,45 @@ const authFactory = ({
     auth.session = { id: session.id };
   }
 
+  if (sharedLink) {
+    auth.sharedLink = authSharedLinkFactory({ ...sharedLink, userId });
+  }
+
   return auth;
 };
 
+const authSharedLinkFactory = (sharedLink: Partial<AuthSharedLink> = {}) => {
+  const {
+    id = newUuid(),
+    expiresAt = null,
+    userId = newUuid(),
+    showExif = true,
+    allowUpload = false,
+    allowDownload = true,
+    password = null,
+  } = sharedLink;
+
+  return { id, expiresAt, userId, showExif, allowUpload, allowDownload, password };
+};
+
 const authApiKeyFactory = (apiKey: Partial<AuthApiKey> = {}) => ({
   id: newUuid(),
   permissions: [Permission.ALL],
   ...apiKey,
 });
 
-const authUserFactory = (authUser: Partial<AuthUser> = {}) => ({
-  id: newUuid(),
-  isAdmin: false,
-  name: 'Test User',
-  email: 'test@immich.cloud',
-  quotaUsageInBytes: 0,
-  quotaSizeInBytes: null,
-  ...authUser,
-});
+const authUserFactory = (authUser: Partial<AuthUser> = {}) => {
+  const {
+    id = newUuid(),
+    isAdmin = false,
+    name = 'Test User',
+    email = 'test@immich.cloud',
+    quotaUsageInBytes = 0,
+    quotaSizeInBytes = null,
+  } = authUser;
+
+  return { id, isAdmin, name, email, quotaUsageInBytes, quotaSizeInBytes };
+};
 
 const partnerFactory = (partner: Partial<Partner> = {}) => {
   const sharedBy = userFactory(partner.sharedBy || {});
@@ -112,25 +142,44 @@ const userFactory = (user: Partial<User> = {}) => ({
   ...user,
 });
 
-const userAdminFactory = (user: Partial<UserAdmin> = {}) => ({
-  id: newUuid(),
-  name: 'Test User',
-  email: 'test@immich.cloud',
-  profileImagePath: '',
-  profileChangedAt: newDate(),
-  storageLabel: null,
-  shouldChangePassword: false,
-  isAdmin: false,
-  createdAt: newDate(),
-  updatedAt: newDate(),
-  deletedAt: null,
-  oauthId: '',
-  quotaSizeInBytes: null,
-  quotaUsageInBytes: 0,
-  status: UserStatus.ACTIVE,
-  metadata: [],
-  ...user,
-});
+const userAdminFactory = (user: Partial<UserAdmin> = {}) => {
+  const {
+    id = newUuid(),
+    name = 'Test User',
+    email = 'test@immich.cloud',
+    profileImagePath = '',
+    profileChangedAt = newDate(),
+    storageLabel = null,
+    shouldChangePassword = false,
+    isAdmin = false,
+    createdAt = newDate(),
+    updatedAt = newDate(),
+    deletedAt = null,
+    oauthId = '',
+    quotaSizeInBytes = null,
+    quotaUsageInBytes = 0,
+    status = UserStatus.ACTIVE,
+    metadata = [],
+  } = user;
+  return {
+    id,
+    name,
+    email,
+    profileImagePath,
+    profileChangedAt,
+    storageLabel,
+    shouldChangePassword,
+    isAdmin,
+    createdAt,
+    updatedAt,
+    deletedAt,
+    oauthId,
+    quotaSizeInBytes,
+    quotaUsageInBytes,
+    status,
+    metadata,
+  };
+};
 
 const assetFactory = (asset: Partial<Asset> = {}) => ({
   id: newUuid(),