From 13e8a0121fcb8d2d4271740c6754fd8b512c9cc4 Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Sun, 1 Mar 2026 19:59:29 +0000
Subject: [PATCH] fix: disable pnpm verifyDepsBeforeRun for base steps and
 restore PR source

The workspace has verifyDepsBeforeRun: install which triggers pnpm install
before every pnpm exec/run. After checking out the base web/SDK code, the
package.json files no longer match the lockfile, causing pnpm to re-install
and corrupt the workspace state. This broke both the base build and the
compare step.

- Set PNPM_VERIFY_DEPS_BEFORE_RUN=false on all steps after the base checkout
- Add a "Restore PR source" step to reset web/SDK to the PR version before
  running compare, so subsequent pnpm commands work normally

https://claude.ai/code/session_01XSTqDJXuR4jaLN7SGm3uES
---
 .github/workflows/visual-review.yml | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/.github/workflows/visual-review.yml b/.github/workflows/visual-review.yml
index 74394eb677..0d1bf99dff 100644
--- a/.github/workflows/visual-review.yml
+++ b/.github/workflows/visual-review.yml
@@ -192,6 +192,8 @@ jobs:
           kill $SERVER_PID 2>/dev/null || true
 
       # === Screenshot base version ===
+      # Disable pnpm's verifyDepsBeforeRun for all base steps since the base
+      # checkout changes package.json files, making them mismatch the lockfile.
       - name: Checkout base web directory
         if: steps.routes.outputs.has_routes == 'true'
         env:
@@ -205,6 +207,8 @@ jobs:
         if: steps.routes.outputs.has_routes == 'true'
         continue-on-error: true
         id: base-sdk
+        env:
+          PNPM_VERIFY_DEPS_BEFORE_RUN: 'false'
         run: pnpm build
         working-directory: ./open-api/typescript-sdk
 
@@ -212,6 +216,8 @@ jobs:
         if: steps.routes.outputs.has_routes == 'true' && steps.base-sdk.outcome == 'success'
         continue-on-error: true
         id: base-web
+        env:
+          PNPM_VERIFY_DEPS_BEFORE_RUN: 'false'
         run: pnpm build
         working-directory: ./web
 
@@ -222,6 +228,7 @@ jobs:
           SCREENSHOT_OUTPUT_DIR: ${{ github.workspace }}/screenshots/base
           SCREENSHOT_SCENARIOS: ${{ steps.routes.outputs.scenarios }}
           SCREENSHOT_BASE_URL: http://127.0.0.1:4173
+          PNPM_VERIFY_DEPS_BEFORE_RUN: 'false'
         run: |
           # Start the preview server in background
           cd ../web && pnpm preview --port 4173 --host 127.0.0.1 &
@@ -242,6 +249,14 @@ jobs:
           # Stop the preview server
           kill $SERVER_PID 2>/dev/null || true
 
+      - name: Restore PR source
+        if: steps.routes.outputs.has_routes == 'true'
+        env:
+          HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+        run: |
+          git checkout "$HEAD_SHA" -- web/ open-api/typescript-sdk/ i18n/ || true
+        working-directory: .
+
       # === Compare and report ===
       - name: Compare screenshots
         if: steps.routes.outputs.has_routes == 'true'