From 01cca7328d716738730f988ca3a7f7e4fb49b33f Mon Sep 17 00:00:00 2001 From: Arno Wiest Date: Fri, 13 Jun 2025 14:46:24 +0200 Subject: [PATCH] chore: added no-undef oxlint rule --- web/.oxlintrc.json | 9 ++++----- web/.prettierignore | 2 ++ web/eslint.config.js | 1 - .../settings/template-settings/template-settings.svelte | 5 +++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/web/.oxlintrc.json b/web/.oxlintrc.json index f001a311d4..b0145e05f5 100644 --- a/web/.oxlintrc.json +++ b/web/.oxlintrc.json @@ -200,7 +200,8 @@ "@typescript-eslint/prefer-as-const": "error", "@typescript-eslint/prefer-namespace-keyword": "error", "@typescript-eslint/triple-slash-reference": "error", - "curly": "warn" + "curly": "warn", + "eslint/no-undef": "error" }, "globals": { "NodeJS": "writeable" @@ -225,11 +226,9 @@ ], "overrides": [ { - "files": [ - "*.svelte", - "**/*.svelte" - ], + "files": ["*.svelte", "**/*.svelte", "**/*.svelte.ts", "**/*.svelte.js"], "rules": { + "eslint/no-undef": "off", "no-inner-declarations": "off", "no-self-assign": "off" } diff --git a/web/.prettierignore b/web/.prettierignore index 22f25a7d84..0216283899 100644 --- a/web/.prettierignore +++ b/web/.prettierignore @@ -13,3 +13,5 @@ node_modules pnpm-lock.yaml package-lock.json yarn.lock +biome.json +.oxlintrc.json \ No newline at end of file diff --git a/web/eslint.config.js b/web/eslint.config.js index da155a60b1..9a545fcbc7 100644 --- a/web/eslint.config.js +++ b/web/eslint.config.js @@ -99,5 +99,4 @@ export default typescriptEslint.config( }, }, }, - oxlint.buildFromOxlintConfigFile('./.oxlintrc.json'), ); diff --git a/web/src/lib/components/admin-page/settings/template-settings/template-settings.svelte b/web/src/lib/components/admin-page/settings/template-settings/template-settings.svelte index 38ecc17036..3bafc117c9 100644 --- a/web/src/lib/components/admin-page/settings/template-settings/template-settings.svelte +++ b/web/src/lib/components/admin-page/settings/template-settings/template-settings.svelte @@ -4,7 +4,6 @@ import LoadingSpinner from '$lib/components/shared-components/loading-spinner.svelte'; import SettingAccordion from '$lib/components/shared-components/settings/setting-accordion.svelte'; import SettingTextarea from '$lib/components/shared-components/settings/setting-textarea.svelte'; - import { modalManager } from '$lib/managers/modal-manager.svelte'; import EmailTemplatePreviewModal from '$lib/modals/EmailTemplatePreviewModal.svelte'; import { handleError } from '$lib/utils/handle-error'; import { type SystemConfigDto, type SystemConfigTemplateEmailsDto, getNotificationTemplateAdmin } from '@immich/sdk'; @@ -22,11 +21,13 @@ let loadingPreview = $state(false); + const myCoolVariable = 'hello!'; + const getTemplate = async (name: string, template: string) => { try { loadingPreview = true; const { html } = await getNotificationTemplateAdmin({ name, templateDto: { template } }); - modalManager.show(EmailTemplatePreviewModal, { html }); + modalManger.show(EmailTemplatePreviewModal, { html }); } catch (error) { handleError(error, 'Could not load template.'); } finally {