Proposing fixes for contrib/terraform/vsphere/ #8436 (#8441)

* fixes issues in vSphere Terraform contrib. #8436

* fix formatting

* add variables to the main module and document changes

* add missing newline

contrib/terraform/vsphere/modules/kubernetes-cluster/templates/cloud-init.tpl

@@ -0,0 +1,6 @@
+#cloud-config
+
+ssh_authorized_keys:
+%{ for ssh_public_key in ssh_public_keys ~}
+  - ${ssh_public_key}
+%{ endfor ~}

contrib/terraform/vsphere/modules/kubernetes-cluster/templates/metadata.tpl

@@ -0,0 +1,14 @@
+instance-id: ${hostname}
+local-hostname: ${hostname}
+network:
+  version: 2
+  ethernets:
+    ${interface_name}:
+      match:
+        name: ${interface_name}
+      dhcp4: false
+      addresses:
+        - ${ip}/${netmask}
+      gateway4: ${gw}
+      nameservers:
+        addresses: [${dns}]

contrib/terraform/vsphere/modules/kubernetes-cluster/templates/vapp-cloud-init.tpl

@@ -6,23 +6,12 @@ ssh_authorized_keys:
 %{ endfor ~}
 
 write_files:
-  - path: /etc/netplan/20-internal-network.yaml
-    content: |
-      network:
-        version: 2
-        ethernets:
-          "lo:0":
-            match:
-              name: lo
-            dhcp4: false
-            addresses:
-            - 172.17.0.100/32
   - path: /etc/netplan/10-user-network.yaml
-    content: |
+    content: |.
       network:
         version: 2
         ethernets:
-          ens192:
+          ${interface_name}:
             dhcp4: false #true to use dhcp
             addresses:
             - ${ip}/${netmask}