PHASE 2 - Enable Packet-CI in gitlab and move unit-tests and deploy-part1 (#4538)

* PHASE 2 - Enable Packet-CI in gitlab

* Add gitlab files

* Reset files back and only keep Packet

* Include packet

* Add missing Upgrade Tests

* Update GCE jobs etc

* Fix bug

* Yaml lint all gitlab files

* Remove GCE

* Test

* Test again

* Enable GCE again

* Install requirements

* Cleanup the gitlab file

* Cleanup runner tags

* Install requirements

* Test

* Test variables for gce

* Test again

* Test again

* Fix

* Update

.gitlab-ci/digital-ocean.yml

@@ -1,3 +1,4 @@
+---
 .do_variables: &do_variables
   PRIVATE_KEY: $DO_PRIVATE_KEY
   CI_PLATFORM: "do"
@@ -5,6 +6,8 @@
 
 .do: &do
   extends: .testcases
+  tags:
+    - do
 
 do_ubuntu-canal-ha:
   stage: deploy-part2

.gitlab-ci/gce.yml

@@ -1,3 +1,4 @@
+---
 .gce_variables: &gce_variables
   GCE_USER: travis
   SSH_USER: $GCE_USER
@@ -5,113 +6,41 @@
   CI_PLATFORM: "gce"
   PRIVATE_KEY: $GCE_PRIVATE_KEY
 
+.docker_service: &docker_service
+  services:
+    - docker:dind
+
+.cache: &cache
+  cache:
+    key: "$CI_BUILD_REF_NAME"
+    paths:
+      - downloads/
+      - $HOME/.cache
+
 .gce: &gce
   extends: .testcases
-
-# Test matrix. Leave the comments for markup scripts.
-.coreos_calico_aio_variables: &coreos_calico_aio_variables
-  # stage: deploy-part1
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu18_flannel_aio_variables: &ubuntu18_flannel_aio_variables
-  # stage: deploy-part1
-  MOVED_TO_GROUP_VARS: "true"
+  <<: *docker_service
+  <<: *cache
+  variables:
+    <<: *gce_variables
+  tags:
+    - gce
 
 .centos_weave_kubeadm_variables: &centos_weave_kubeadm_variables
   # stage: deploy-part1
   UPGRADE_TEST: "graceful"
 
-.ubuntu_canal_kubeadm_variables: &ubuntu_canal_kubeadm_variables
-  # stage: deploy-part1
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_canal_ha_variables: &ubuntu_canal_ha_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_contiv_sep_variables: &ubuntu_contiv_sep_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.coreos_cilium_variables: &coreos_cilium_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_cilium_sep_variables: &ubuntu_cilium_sep_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.rhel7_weave_variables: &rhel7_weave_variables
-  # stage: deploy-part1
-  MOVED_TO_GROUP_VARS: "true"
-
-.centos7_flannel_addons_variables: &centos7_flannel_addons_variables
-  # stage: deploy-part2
-  MOVED_TO_GROUP_VARS: "true"
-
-.debian9_calico_variables: &debian9_calico_variables
-  # stage: deploy-part2
-  MOVED_TO_GROUP_VARS: "true"
-
-.coreos_canal_variables: &coreos_canal_variables
-  # stage: deploy-part2
-  MOVED_TO_GROUP_VARS: "true"
-
-.rhel7_canal_sep_variables: &rhel7_canal_sep_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_weave_sep_variables: &ubuntu_weave_sep_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.centos7_calico_ha_variables: &centos7_calico_ha_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.centos7_kube_router_variables: &centos7_kube_router_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
 .centos7_multus_calico_variables: &centos7_multus_calico_variables
   # stage: deploy-part2
   UPGRADE_TEST: "graceful"
 
-.coreos_alpha_weave_ha_variables: &coreos_alpha_weave_ha_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.coreos_kube_router_variables: &coreos_kube_router_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_rkt_sep_variables: &ubuntu_rkt_sep_variables
-  # stage: deploy-part1
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_flannel_variables: &ubuntu_flannel_variables
-  # stage: deploy-part2
-  MOVED_TO_GROUP_VARS: "true"
-
-.ubuntu_kube_router_variables: &ubuntu_kube_router_variables
-  # stage: deploy-special
-  MOVED_TO_GROUP_VARS: "true"
-
-.opensuse_canal_variables: &opensuse_canal_variables
-  # stage: deploy-part2
-  MOVED_TO_GROUP_VARS: "true"
-
-
 # Builds for PRs only (premoderated by unit-tests step) and triggers (auto)
 ### PR JOBS PART1
 
 gce_ubuntu18-flannel-aio:
   stage: deploy-part1
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu18_flannel_aio_variables
-  when: on_success
+  when: manual
   except: ['triggers']
   only: [/^pr-.*$/]
 
@@ -120,9 +49,6 @@ gce_ubuntu18-flannel-aio:
 gce_coreos-calico-aio:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_calico_aio_variables
   when: on_success
   except: ['triggers']
   only: [/^pr-.*$/]
@@ -130,9 +56,6 @@ gce_coreos-calico-aio:
 gce_centos7-flannel-addons:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *centos7_flannel_addons_variables
   when: on_success
   except: ['triggers']
   only: [/^pr-.*$/]
@@ -143,7 +66,6 @@ gce_centos-weave-kubeadm-sep:
   stage: deploy-part2
   <<: *gce
   variables:
-    <<: *gce_variables
     <<: *centos_weave_kubeadm_variables
   when: on_success
   only: ['triggers']
@@ -151,45 +73,30 @@ gce_centos-weave-kubeadm-sep:
 gce_ubuntu-weave-sep:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_weave_sep_variables
   when: manual
   only: ['triggers']
 
 gce_coreos-calico-sep-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_calico_aio_variables
   when: on_success
   only: ['triggers']
 
 gce_ubuntu-canal-ha-triggers:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_canal_ha_variables
   when: on_success
   only: ['triggers']
 
 gce_centos7-flannel-addons-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *centos7_flannel_addons_variables
   when: on_success
   only: ['triggers']
 
 gce_ubuntu-weave-sep-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_weave_sep_variables
   when: on_success
   only: ['triggers']
 
@@ -199,9 +106,6 @@ gce_ubuntu-weave-sep-triggers:
 gce_ubuntu-canal-ha:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_canal_ha_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -209,9 +113,6 @@ gce_ubuntu-canal-ha:
 gce_ubuntu-canal-kubeadm:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_canal_kubeadm_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -219,18 +120,12 @@ gce_ubuntu-canal-kubeadm:
 gce_ubuntu-canal-kubeadm-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_canal_kubeadm_variables
   when: on_success
   only: ['triggers']
 
 gce_ubuntu-flannel-ha:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_flannel_variables
   when: manual
   except: ['triggers']
 
@@ -238,7 +133,6 @@ gce_centos-weave-kubeadm-triggers:
   stage: deploy-part2
   <<: *gce
   variables:
-    <<: *gce_variables
     <<: *centos_weave_kubeadm_variables
   when: on_success
   only: ['triggers']
@@ -246,9 +140,6 @@ gce_centos-weave-kubeadm-triggers:
 gce_ubuntu-contiv-sep:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_contiv_sep_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -256,9 +147,6 @@ gce_ubuntu-contiv-sep:
 gce_coreos-cilium:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_cilium_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -266,9 +154,6 @@ gce_coreos-cilium:
 gce_ubuntu-cilium-sep:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_cilium_sep_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -276,9 +161,6 @@ gce_ubuntu-cilium-sep:
 gce_rhel7-weave:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *rhel7_weave_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -286,18 +168,12 @@ gce_rhel7-weave:
 gce_rhel7-weave-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *rhel7_weave_variables
   when: on_success
   only: ['triggers']
 
 gce_debian9-calico-upgrade:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *debian9_calico_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -305,18 +181,12 @@ gce_debian9-calico-upgrade:
 gce_debian9-calico-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *debian9_calico_variables
   when: on_success
   only: ['triggers']
 
 gce_coreos-canal:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_canal_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -324,18 +194,12 @@ gce_coreos-canal:
 gce_coreos-canal-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_canal_variables
   when: on_success
   only: ['triggers']
 
 gce_rhel7-canal-sep:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *rhel7_canal_sep_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -343,18 +207,12 @@ gce_rhel7-canal-sep:
 gce_rhel7-canal-sep-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *rhel7_canal_sep_variables
   when: on_success
   only: ['triggers']
 
 gce_centos7-calico-ha:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *centos7_calico_ha_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -362,18 +220,12 @@ gce_centos7-calico-ha:
 gce_centos7-calico-ha-triggers:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *centos7_calico_ha_variables
   when: on_success
   only: ['triggers']
 
 gce_centos7-kube-router:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *centos7_kube_router_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -382,7 +234,6 @@ gce_centos7-multus-calico:
   stage: deploy-part2
   <<: *gce
   variables:
-    <<: *gce_variables
     <<: *centos7_multus_calico_variables
   when: manual
   except: ['triggers']
@@ -391,9 +242,6 @@ gce_centos7-multus-calico:
 gce_opensuse-canal:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *opensuse_canal_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -402,9 +250,6 @@ gce_opensuse-canal:
 gce_coreos-alpha-weave-ha:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_alpha_weave_ha_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -412,9 +257,6 @@ gce_coreos-alpha-weave-ha:
 gce_coreos-kube-router:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *coreos_kube_router_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -422,9 +264,6 @@ gce_coreos-kube-router:
 gce_ubuntu-rkt-sep:
   stage: deploy-part2
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_rkt_sep_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]
@@ -432,9 +271,6 @@ gce_ubuntu-rkt-sep:
 gce_ubuntu-kube-router-sep:
   stage: deploy-special
   <<: *gce
-  variables:
-    <<: *gce_variables
-    <<: *ubuntu_kube_router_variables
   when: manual
   except: ['triggers']
   only: ['master', /^pr-.*$/]

.gitlab-ci/lint.yml

@@ -1,3 +1,4 @@
+---
 yamllint:
   extends: .job
   stage: unit-tests

.gitlab-ci/packet.yml

@@ -0,0 +1,158 @@
+---
+.packet_variables: &packet_variables
+  CI_PLATFORM: "packet"
+  SSH_USER: "kubespray"
+
+.packet: &packet
+  extends: .testcases
+  variables:
+    <<: *packet_variables
+  tags:
+    - packet
+
+.test-upgrade: &test-upgrade
+  variables:
+    UPGRADE_TEST: "graceful"
+
+packet_ubuntu18-flannel-aio:
+  stage: deploy-part1
+  <<: *packet
+  when: on_success
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+# ### PR JOBS PART2
+
+packet_centos7-flannel-addons:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: [/^pr-.*$/]
+
+# ### MANUAL JOBS
+
+packet_centos-weave-kubeadm-sep:
+  stage: deploy-part2
+  <<: *packet
+  when: on_success
+  only: ['triggers']
+
+packet_ubuntu-weave-sep:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  only: ['triggers']
+
+# # More builds for PRs/merges (manual) and triggers (auto)
+
+packet_ubuntu-canal-ha:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_ubuntu-canal-kubeadm:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_ubuntu-flannel-ha:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+
+packet_ubuntu-contiv-sep:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_ubuntu-cilium-sep:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_rhel7-weave:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_debian9-calico-upgrade:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_rhel7-canal-sep:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_centos7-calico-ha:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_centos7-cilium:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_rhel7-cilium:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_centos7-kube-router:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_centos7-multus-calico:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_opensuse-canal:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_ubuntu-rkt-sep:
+  stage: deploy-part2
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]
+
+packet_ubuntu-kube-router-sep:
+  stage: deploy-special
+  <<: *packet
+  when: manual
+  except: ['triggers']
+  only: ['master', /^pr-.*$/]

.gitlab-ci/terraform.yml

@@ -1,3 +1,4 @@
+---
 # Tests for contrib/terraform/
 .terraform_install:
   extends: .job
@@ -123,7 +124,7 @@ tf-apply-ovh:
     TF_VAR_floatingip_pool: "Ext-Net"
     TF_VAR_external_net: "6011fbc9-4cbf-46a4-8452-6890a340b60b"
     TF_VAR_network_name: "Ext-Net"
-    TF_VAR_flavor_k8s_master: "defa64c3-bd46-43b4-858a-d93bbae0a229" #s1-8
-    TF_VAR_flavor_k8s_node: "defa64c3-bd46-43b4-858a-d93bbae0a229" #s1-8
+    TF_VAR_flavor_k8s_master: "defa64c3-bd46-43b4-858a-d93bbae0a229"    # s1-8
+    TF_VAR_flavor_k8s_node: "defa64c3-bd46-43b4-858a-d93bbae0a229"      # s1-8
     TF_VAR_image: "Ubuntu 18.04"
     TF_VAR_k8s_allowed_remote_ips: '["0.0.0.0/0"]'