From bca5a4ce3b45e016a81784cebc498157e1a65c31 Mon Sep 17 00:00:00 2001
From: Max Gautier <mg@max.gautier.name>
Date: Fri, 16 May 2025 10:27:13 +0000
Subject: [PATCH] CI: remove ci-not-authorized job (#12225)

This is now handled directly at the failfast-ci level (== integration
Github <-> Gitlab).
The whole pipeline will not be triggered unless:
- The author is a maintainer
- The PR has the /ok-to-test label
---
 .gitlab-ci.yml           | 28 ----------------------------
 .gitlab-ci/kubevirt.yml  |  1 -
 .gitlab-ci/molecule.yml  |  1 -
 .gitlab-ci/terraform.yml |  1 -
 .gitlab-ci/vagrant.yml   |  2 --
 5 files changed, 33 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index e6c9509f0..955880f97 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -55,37 +55,9 @@ before_script:
   extends: .job
   needs:
     - pipeline-image
-    - ci-not-authorized
     - pre-commit            # lint
     - vagrant-validate      # lint
 
-# For failfast, at least 1 job must be defined in .gitlab-ci.yml
-# Premoderated with manual actions
-ci-not-authorized:
-  stage: build
-  before_script: []
-  after_script: []
-  rules:
-    # LGTM or ok-to-test labels
-    - if: $PR_LABELS =~ /.*,(lgtm|approved|ok-to-test).*|^(lgtm|approved|ok-to-test).*/i
-      variables:
-        CI_OK_TO_TEST: '0'
-      when: always
-    - if: $CI_PIPELINE_SOURCE == "schedule" || $CI_PIPELINE_SOURCE == "trigger"
-      variables:
-        CI_OK_TO_TEST: '0'
-    - if: $CI_COMMIT_BRANCH == "master"
-      variables:
-        CI_OK_TO_TEST: '0'
-    - when: always
-      variables:
-        CI_OK_TO_TEST: '1'
-  script:
-    - exit $CI_OK_TO_TEST
-  tags:
-    - ffci
-  needs: []
-
 include:
   - .gitlab-ci/build.yml
   - .gitlab-ci/lint.yml
diff --git a/.gitlab-ci/kubevirt.yml b/.gitlab-ci/kubevirt.yml
index ebc148838..842003e10 100644
--- a/.gitlab-ci/kubevirt.yml
+++ b/.gitlab-ci/kubevirt.yml
@@ -12,7 +12,6 @@
     - ffci
   needs:
     - pipeline-image
-    - ci-not-authorized
 
 # TODO: generate testcases matrixes from the files in tests/files/
 # this is needed to avoid the need for PR rebasing when a job was added or removed in the target branch
diff --git a/.gitlab-ci/molecule.yml b/.gitlab-ci/molecule.yml
index 36d5a53bf..c2a19d08c 100644
--- a/.gitlab-ci/molecule.yml
+++ b/.gitlab-ci/molecule.yml
@@ -12,7 +12,6 @@
   image: $PIPELINE_IMAGE
   needs:
   - pipeline-image
-  # - ci-not-authorized
   script:
   - ./tests/scripts/molecule_run.sh
   after_script:
diff --git a/.gitlab-ci/terraform.yml b/.gitlab-ci/terraform.yml
index 97003a860..cac69852b 100644
--- a/.gitlab-ci/terraform.yml
+++ b/.gitlab-ci/terraform.yml
@@ -3,7 +3,6 @@
 .terraform_install:
   extends: .job
   needs:
-    - ci-not-authorized
     - pipeline-image
   variables:
     TF_VAR_public_key_path: "${ANSIBLE_PRIVATE_KEY_FILE}.pub"
diff --git a/.gitlab-ci/vagrant.yml b/.gitlab-ci/vagrant.yml
index 173f8301f..d4b33bfd8 100644
--- a/.gitlab-ci/vagrant.yml
+++ b/.gitlab-ci/vagrant.yml
@@ -1,8 +1,6 @@
 ---
 vagrant:
   extends: .job-moderated
-  needs:
-    - ci-not-authorized
   variables:
     CI_PLATFORM: "vagrant"
     SSH_USER: "vagrant"