From a3e569f5c4701806c9d0ddbcfa611ee240f1b3a6 Mon Sep 17 00:00:00 2001
From: Max Gautier <mg@max.gautier.name>
Date: Wed, 18 Dec 2024 21:58:13 +0100
Subject: [PATCH] kubernetes/preinstall: switch coredns_server to vars/

---
 .../preinstall/tasks/0020-set_facts.yml           | 15 ---------------
 roles/kubernetes/preinstall/vars/main.yml         |  7 +++++++
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/roles/kubernetes/preinstall/tasks/0020-set_facts.yml b/roles/kubernetes/preinstall/tasks/0020-set_facts.yml
index 6109479c1..3a0f8d8a3 100644
--- a/roles/kubernetes/preinstall/tasks/0020-set_facts.yml
+++ b/roles/kubernetes/preinstall/tasks/0020-set_facts.yml
@@ -162,21 +162,6 @@
     supersede_domain:
       supersede domain-name "{{ dns_domain }}";
 
-- name: Pick coredns cluster IP or default resolver
-  set_fact:
-    coredns_server: |-
-      {%- if dns_mode == 'coredns' and not dns_early | bool -%}
-        {{ [skydns_server] }}
-      {%- elif dns_mode == 'coredns_dual' and not dns_early | bool -%}
-        {{ [skydns_server] + [skydns_server_secondary] }}
-      {%- elif dns_mode == 'manual' and not dns_early | bool -%}
-        {{ (manual_dns_server.split(',') | list) }}
-      {%- elif dns_mode == 'none' and not dns_early | bool -%}
-        []
-      {%- elif dns_early | bool -%}
-        {{ upstream_dns_servers | default([]) }}
-      {%- endif -%}
-
 # This task should only run after cluster/nodelocal DNS is up, otherwise all DNS lookups will timeout
 - name: Generate nameservers for resolvconf, including cluster DNS
   set_fact:
diff --git a/roles/kubernetes/preinstall/vars/main.yml b/roles/kubernetes/preinstall/vars/main.yml
index 699a87de5..12458b557 100644
--- a/roles/kubernetes/preinstall/vars/main.yml
+++ b/roles/kubernetes/preinstall/vars/main.yml
@@ -70,3 +70,10 @@ pkgs:
   tar: []
   unzip: []
   xfsprogs: []
+
+coredns_server_by_mode:
+  coredns: "{{ [skydns_server] }}"
+  coredns_dual: "{{ [skydns_server, skydns_server_secondary] }}"
+  manual: "{{ manual_dns_server.split(',') }}"
+  none: []
+coredns_server: "{{ upstream_dns_server if dns_early else coredns_server_by_mode[dns_mode] }}"