Merge pull request #188 from teutostack/warnings-removal

Fixing deprecation warnings regarding bare variables and apt

roles/kubernetes/master/tasks/main.yml

@@ -45,7 +45,7 @@
 - meta: flush_handlers
 
 - include: start.yml
-  with_items: groups['kube-master']
+  with_items: "{{ groups['kube-master'] }}"
   when: "{{ hostvars[item].inventory_hostname == inventory_hostname }}"
 
 # Create kube-system namespace

roles/kubernetes/preinstall/tasks/etchosts.yml

@@ -8,7 +8,7 @@
     create: yes
     backup: yes
   when: hostvars[item].ansible_default_ipv4.address is defined
-  with_items: groups['all']
+  with_items: "{{ groups['all'] }}"
 
 - name: Hosts | populate kubernetes loadbalancer address into hosts file
   lineinfile:

roles/kubernetes/preinstall/tasks/main.yml

@@ -64,18 +64,13 @@
     - "/opt/cni/bin"
   when: kube_network_plugin == "calico"
 
-- name: Update package management cache (APT)
-  apt: update_cache=yes
-  when: ansible_pkg_mgr == 'apt'
-
 - name: Update package management cache (YUM)
   yum: update_cache=yes name='*'
   when: ansible_pkg_mgr == 'yum'
 
-- name: Install python-apt for Debian distribs
-  command: apt-get install -y python-apt
+- name: Install latest version of python-apt for Debian distribs
+  apt: name=python-apt state=latest update_cache=yes cache_valid_time=3600
   when: ansible_os_family == "Debian"
-  changed_when: False
 
 - name: Install python-dnf for latest RedHat versions
   command: dnf install -y python-dnf yum

roles/kubernetes/secrets/tasks/gen_certs.yml

@@ -48,4 +48,4 @@
   file:
     path: "{{ item }}"
     mode: 0600
-  with_items: keyfiles.stdout_lines
+  with_items: "{{ keyfiles.stdout_lines }}"