Do not use ‘yes/no’ for boolean values (#11472)

Consistent boolean values in ansible playbooks

roles/etcd/tasks/check_certs.yml

@@ -17,9 +17,9 @@
 - name: "Check certs | Register ca and etcd admin/member certs on etcd hosts"
   stat:
     path: "{{ etcd_cert_dir }}/{{ item }}"
-    get_attributes: no
-    get_checksum: yes
-    get_mime: no
+    get_attributes: false
+    get_checksum: true
+    get_mime: false
   register: etcd_member_certs
   when: inventory_hostname in groups['etcd']
   with_items:

roles/etcd/tasks/configure.yml

@@ -6,8 +6,8 @@
   register: etcd_cluster_is_healthy
   failed_when: false
   changed_when: false
-  check_mode: no
-  run_once: yes
+  check_mode: false
+  run_once: true
   when:
     - is_etcd_master
     - etcd_cluster_setup
@@ -27,8 +27,8 @@
   register: etcd_events_cluster_is_healthy
   failed_when: false
   changed_when: false
-  check_mode: no
-  run_once: yes
+  check_mode: false
+  run_once: true
   when:
     - is_etcd_master
     - etcd_events_cluster_setup
@@ -49,7 +49,7 @@
   template:
     src: "etcd-{{ etcd_deployment_type }}.service.j2"
     dest: /etc/systemd/system/etcd.service
-    backup: yes
+    backup: true
     mode: "0644"
     # FIXME: check that systemd version >= 250 (factory-reset.target was introduced in that release)
     # Remove once we drop support for systemd < 250
@@ -60,7 +60,7 @@
   template:
     src: "etcd-events-{{ etcd_deployment_type }}.service.j2"
     dest: /etc/systemd/system/etcd-events.service
-    backup: yes
+    backup: true
     mode: "0644"
     validate: "sh -c '[ -f /usr/bin/systemd/system/factory-reset.target ] || exit 0 && systemd-analyze verify %s:etcd-events-{{ etcd_deployment_type }}.service'"
     # FIXME: check that systemd version >= 250 (factory-reset.target was introduced in that release)
@@ -77,7 +77,7 @@
   service:
     name: etcd
     state: started
-    enabled: yes
+    enabled: true
   ignore_errors: "{{ etcd_cluster_is_healthy.rc == 0 }}"  # noqa ignore-errors
   when: is_etcd_master and etcd_cluster_setup
 
@@ -86,7 +86,7 @@
   service:
     name: etcd-events
     state: started
-    enabled: yes
+    enabled: true
   ignore_errors: "{{ etcd_events_cluster_is_healthy.rc != 0 }}"  # noqa ignore-errors
   when: is_etcd_master and etcd_events_cluster_setup
 
@@ -99,8 +99,8 @@
   retries: "{{ etcd_retries }}"
   delay: "{{ retry_stagger | random + 3 }}"
   changed_when: false
-  check_mode: no
-  run_once: yes
+  check_mode: false
+  run_once: true
   when:
     - is_etcd_master
     - etcd_cluster_setup
@@ -122,8 +122,8 @@
   retries: "{{ etcd_retries }}"
   delay: "{{ retry_stagger | random + 3 }}"
   changed_when: false
-  check_mode: no
-  run_once: yes
+  check_mode: false
+  run_once: true
   when:
     - is_etcd_master
     - etcd_events_cluster_setup
@@ -141,7 +141,7 @@
   register: etcd_member_in_cluster
   ignore_errors: true  # noqa ignore-errors
   changed_when: false
-  check_mode: no
+  check_mode: false
   when: is_etcd_master and etcd_cluster_setup
   tags:
     - facts
@@ -157,7 +157,7 @@
   register: etcd_events_member_in_cluster
   ignore_errors: true  # noqa ignore-errors
   changed_when: false
-  check_mode: no
+  check_mode: false
   when: is_etcd_master and etcd_events_cluster_setup
   tags:
     - facts

roles/etcd/tasks/gen_certs_script.yml

@@ -6,7 +6,7 @@
     state: directory
     owner: "{{ etcd_owner }}"
     mode: "{{ etcd_cert_dir_mode }}"
-    recurse: yes
+    recurse: true
 
 - name: "Gen_certs | create etcd script dir (on {{ groups['etcd'][0] }})"
   file:
@@ -14,7 +14,7 @@
     state: directory
     owner: root
     mode: "0700"
-  run_once: yes
+  run_once: true
   when: inventory_hostname == groups['etcd'][0]
 
 - name: Gen_certs | write openssl config
@@ -22,7 +22,7 @@
     src: "openssl.conf.j2"
     dest: "{{ etcd_config_dir }}/openssl.conf"
     mode: "0640"
-  run_once: yes
+  run_once: true
   delegate_to: "{{ groups['etcd'][0] }}"
   when:
     - gen_certs | default(false)
@@ -33,7 +33,7 @@
     src: "make-ssl-etcd.sh.j2"
     dest: "{{ etcd_script_dir }}/make-ssl-etcd.sh"
     mode: "0700"
-  run_once: yes
+  run_once: true
   when:
     - gen_certs | default(false)
     - inventory_hostname == groups['etcd'][0]
@@ -43,7 +43,7 @@
   environment:
     MASTERS: "{{ groups['gen_master_certs_True'] | ansible.builtin.intersect(groups['etcd']) | join(' ') }}"
     HOSTS: "{{ groups['gen_node_certs_True'] | ansible.builtin.intersect(groups['kube_control_plane']) | join(' ') }}"
-  run_once: yes
+  run_once: true
   delegate_to: "{{ groups['etcd'][0] }}"
   when: gen_certs | default(false)
   notify: Set etcd_secret_changed
@@ -52,7 +52,7 @@
   command: "bash -x {{ etcd_script_dir }}/make-ssl-etcd.sh -f {{ etcd_config_dir }}/openssl.conf -d {{ etcd_cert_dir }}"
   environment:
     HOSTS: "{{ groups['gen_node_certs_True'] | ansible.builtin.intersect(groups['k8s_cluster']) | join(' ') }}"
-  run_once: yes
+  run_once: true
   delegate_to: "{{ groups['etcd'][0] }}"
   when:
     - kube_network_plugin in ["calico", "flannel", "cilium"] or cilium_deploy_additionally | default(false) | bool
@@ -153,4 +153,4 @@
     state: directory
     owner: "{{ etcd_owner }}"
     mode: "{{ etcd_cert_dir_mode }}"
-    recurse: yes
+    recurse: true

roles/etcd/tasks/gen_nodes_certs_script.yml

@@ -21,7 +21,7 @@
     executable: /bin/bash
   no_log: "{{ not (unsafe_show_logs | bool) }}"
   register: etcd_node_certs
-  check_mode: no
+  check_mode: false
   delegate_to: "{{ groups['etcd'][0] }}"
   changed_when: false
 

roles/etcd/tasks/install_docker.yml

@@ -29,7 +29,7 @@
     dest: "{{ bin_dir }}/etcd"
     owner: 'root'
     mode: "0750"
-    backup: yes
+    backup: true
   when: etcd_cluster_setup
 
 - name: Install etcd-events launch script
@@ -38,5 +38,5 @@
     dest: "{{ bin_dir }}/etcd-events"
     owner: 'root'
     mode: "0750"
-    backup: yes
+    backup: true
   when: etcd_events_cluster_setup

roles/etcd/tasks/install_host.yml

@@ -25,7 +25,7 @@
     src: "{{ local_release_dir }}/etcd-{{ etcd_version }}-linux-{{ host_architecture }}/{{ item }}"
     dest: "{{ bin_dir }}/{{ item }}"
     mode: "0755"
-    remote_src: yes
+    remote_src: true
   with_items:
     - etcd
   when: etcd_cluster_setup

roles/etcd/tasks/join_etcd-events_member.yml

@@ -32,7 +32,7 @@
     executable: /bin/bash
   register: etcd_events_member_in_cluster
   changed_when: false
-  check_mode: no
+  check_mode: false
   tags:
     - facts
   environment:
@@ -46,4 +46,4 @@
   service:
     name: etcd-events
     state: started
-    enabled: yes
+    enabled: true

roles/etcd/tasks/join_etcd_member.yml

@@ -33,7 +33,7 @@
     executable: /bin/bash
   register: etcd_member_in_cluster
   changed_when: false
-  check_mode: no
+  check_mode: false
   retries: "{{ etcd_retries }}"
   delay: "{{ retry_stagger | random + 3 }}"
   until: etcd_member_in_cluster.rc == 0
@@ -50,4 +50,4 @@
   service:
     name: etcd
     state: started
-    enabled: yes
+    enabled: true

roles/etcd/tasks/main.yml

@@ -33,7 +33,7 @@
   command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial"
   register: "etcd_client_cert_serial_result"
   changed_when: false
-  check_mode: no
+  check_mode: false
   when:
     - kube_network_plugin in ["calico", "flannel", "cilium"] or cilium_deploy_additionally | default(false) | bool
     - kube_network_plugin != "calico" or calico_datastore == "etcd"