Improving yamllint configuration (#11389)

Signed-off-by: Bas Meijer <bas.meijer@enexis.nl>

roles/network_plugin/calico/tasks/calico_apiserver_certs.yml

@@ -9,7 +9,7 @@
   template:
     src: "calico-apiserver-ns.yml.j2"
     dest: "{{ kube_config_dir }}/calico-apiserver-ns.yml"
-    mode: 0644
+    mode: "0644"
 
 - name: Calico | Apply ns manifests
   kube:
@@ -21,21 +21,21 @@
   file:
     path: /etc/calico/certs
     state: directory
-    mode: 0755
+    mode: "0755"
   when: calico_apiserver_secret.rc != 0
 
 - name: Calico | Copy ssl script for apiserver certs
   template:
     src: make-ssl-calico.sh.j2
     dest: "{{ bin_dir }}/make-ssl-apiserver.sh"
-    mode: 0755
+    mode: "0755"
   when: calico_apiserver_secret.rc != 0
 
 - name: Calico | Copy ssl config for apiserver certs
   copy:
     src: openssl.conf
     dest: /etc/calico/certs/openssl.conf
-    mode: 0644
+    mode: "0644"
   when: calico_apiserver_secret.rc != 0
 
 - name: Calico | Generate apiserver certs

roles/network_plugin/calico/tasks/install.yml

@@ -13,14 +13,14 @@
   copy:
     src: "{{ downloads.calicoctl.dest }}"
     dest: "{{ bin_dir }}/calicoctl"
-    mode: 0755
+    mode: "0755"
     remote_src: yes
 
 - name: Calico | Create calico certs directory
   file:
     dest: "{{ calico_cert_dir }}"
     state: directory
-    mode: 0750
+    mode: "0750"
     owner: root
     group: root
   when: calico_datastore == "etcd"
@@ -30,7 +30,7 @@
     src: "{{ etcd_cert_dir }}/{{ item.s }}"
     dest: "{{ calico_cert_dir }}/{{ item.d }}"
     state: hard
-    mode: 0640
+    mode: "0640"
     force: yes
   with_items:
     - {s: "{{ kube_etcd_cacert_file }}", d: "ca_cert.crt"}
@@ -54,7 +54,7 @@
   template:
     src: "calicoctl.{{ calico_datastore }}.sh.j2"
     dest: "{{ bin_dir }}/calicoctl.sh"
-    mode: 0755
+    mode: "0755"
     owner: root
     group: root
 
@@ -142,7 +142,7 @@
       assemble:
         src: "{{ calico_kdd_path }}"
         dest: "{{ kube_config_dir }}/kdd-crds.yml"
-        mode: 0644
+        mode: "0644"
         delimiter: "---\n"
         regexp: ".*\\.yaml"
         remote_src: true
@@ -372,7 +372,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: calico-config, file: calico-config.yml, type: cm}
     - {name: calico-node, file: calico-node.yml, type: ds}
@@ -389,7 +389,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: calico, file: calico-typha.yml, type: typha}
   register: calico_node_typha_manifest
@@ -416,7 +416,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: calico, file: calico-apiserver.yml, type: calico-apiserver}
   register: calico_apiserver_manifest
@@ -469,7 +469,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: calico, file: calico-ipamconfig.yml, type: ipam}
   when:

roles/network_plugin/calico/tasks/typha_certs.yml

@@ -9,21 +9,22 @@
   file:
     path: /etc/calico/certs
     state: directory
-    mode: 0755
+    mode: "0755"
   when: typha_server_secret.rc != 0
 
 - name: Calico | Copy ssl script for typha certs
   template:
     src: make-ssl-calico.sh.j2
     dest: "{{ bin_dir }}/make-ssl-typha.sh"
-    mode: 0755
+    mode: "0755"
+
   when: typha_server_secret.rc != 0
 
 - name: Calico | Copy ssl config for typha certs
   copy:
     src: openssl.conf
     dest: /etc/calico/certs/openssl.conf
-    mode: 0644
+    mode: "0644"
   when: typha_server_secret.rc != 0
 
 - name: Calico | Generate typha certs

roles/network_plugin/cilium/tasks/install.yml

@@ -10,7 +10,7 @@
   file:
     dest: "{{ cilium_cert_dir }}"
     state: directory
-    mode: 0750
+    mode: "0750"
     owner: root
     group: root
   when:
@@ -20,7 +20,7 @@
   file:
     src: "{{ etcd_cert_dir }}/{{ item.s }}"
     dest: "{{ cilium_cert_dir }}/{{ item.d }}"
-    mode: 0644
+    mode: "0644"
     state: hard
     force: yes
   loop:
@@ -36,7 +36,7 @@
     state: directory
     owner: root
     group: root
-    mode: 0755
+    mode: "0755"
   when:
     - inventory_hostname == groups['kube_control_plane'][0]
     - cilium_hubble_install
@@ -45,7 +45,7 @@
   template:
     src: "{{ item.name }}/{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.name }}-{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   loop:
     - {name: cilium, file: config.yml, type: cm}
     - {name: cilium-operator, file: crb.yml, type: clusterrolebinding}
@@ -66,7 +66,7 @@
   template:
     src: "{{ item.name }}/{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/addons/hubble/{{ item.name }}-{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   loop:
     - {name: hubble, file: config.yml, type: cm}
     - {name: hubble, file: crb.yml, type: clusterrolebinding}
@@ -86,12 +86,12 @@
   template:
     src: 000-cilium-portmap.conflist.j2
     dest: /etc/cni/net.d/000-cilium-portmap.conflist
-    mode: 0644
+    mode: "0644"
   when: cilium_enable_portmap
 
 - name: Cilium | Copy Ciliumcli binary from download dir
   copy:
     src: "{{ local_release_dir }}/cilium"
     dest: "{{ bin_dir }}/cilium"
-    mode: 0755
+    mode: "0755"
     remote_src: yes

roles/network_plugin/cni/tasks/main.yml

@@ -3,7 +3,7 @@
   file:
     path: /opt/cni/bin
     state: directory
-    mode: 0755
+    mode: "0755"
     owner: "{{ cni_bin_owner }}"
     recurse: true
 
@@ -11,6 +11,6 @@
   unarchive:
     src: "{{ downloads.cni.dest }}"
     dest: "/opt/cni/bin"
-    mode: 0755
+    mode: "0755"
     owner: "{{ cni_bin_owner }}"
     remote_src: yes

roles/network_plugin/custom_cni/tasks/main.yml

@@ -12,7 +12,7 @@
     template:
       src: "{{ item }}"
       dest: "{{ kube_config_dir }}/{{ item | basename | replace('.j2', '') }}"
-      mode: 0644
+      mode: "0644"
     loop: "{{ custom_cni_manifests }}"
     delegate_to: "{{ groups['kube_control_plane'] | first }}"
     run_once: true

roles/network_plugin/flannel/tasks/main.yml

@@ -12,7 +12,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: flannel, file: cni-flannel-rbac.yml, type: sa}
     - {name: kube-flannel, file: cni-flannel.yml, type: ds}

roles/network_plugin/kube-ovn/defaults/main.yml

@@ -115,4 +115,4 @@ kube_ovn_ls_dnat_mod_dl_dst: true
 kube_ovn_keep_vm_ip: true
 
 ## cni config priority, default: 01
-kube_ovn_cni_config_priority: 01
+kube_ovn_cni_config_priority: '01'

roles/network_plugin/kube-ovn/tasks/main.yml

@@ -9,7 +9,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: kube-ovn-crd, file: cni-kube-ovn-crd.yml}
     - {name: ovn, file: cni-ovn.yml}

roles/network_plugin/kube-router/tasks/main.yml

@@ -9,13 +9,13 @@
     state: directory
     owner: "{{ kube_owner }}"
     recurse: true
-    mode: 0755
+    mode: "0755"
 
 - name: Kube-router | Create kubeconfig
   template:
     src: kubeconfig.yml.j2
     dest: /var/lib/kube-router/kubeconfig
-    mode: 0644
+    mode: "0644"
     owner: "{{ kube_owner }}"
   notify:
     - Reset_kube_router
@@ -43,7 +43,7 @@
   template:
     src: cni-conf.json.j2
     dest: /etc/cni/net.d/10-kuberouter.conflist
-    mode: 0644
+    mode: "0644"
     owner: "{{ kube_owner }}"
   notify:
     - Reset_kube_router
@@ -57,6 +57,6 @@
   template:
     src: kube-router.yml.j2
     dest: "{{ kube_config_dir }}/kube-router.yml"
-    mode: 0644
+    mode: "0644"
   delegate_to: "{{ groups['kube_control_plane'] | first }}"
   run_once: true

roles/network_plugin/macvlan/tasks/main.yml

@@ -23,7 +23,7 @@
   template:
     src: debian-network-macvlan.cfg.j2
     dest: /etc/network/interfaces.d/60-mac0.cfg
-    mode: 0644
+    mode: "0644"
   notify: Macvlan | restart network
   when: ansible_os_family in ["Debian"]
 
@@ -53,7 +53,7 @@
     template:
       src: "{{ item.src }}.j2"
       dest: "/etc/sysconfig/network-scripts/{{ item.dst }}"
-      mode: 0644
+      mode: "0644"
     with_items:
     - {src: centos-network-macvlan.cfg, dst: ifcfg-mac0 }
     - {src: centos-routes-macvlan.cfg, dst: route-mac0 }
@@ -67,7 +67,7 @@
     template:
       src: coreos-service-nat_ouside.j2
       dest: /etc/systemd/system/enable_nat_ouside.service
-      mode: 0644
+      mode: "0644"
     when: enable_nat_default_gateway
 
   - name: Macvlan | Enable service nat via gateway on Flatcar Container Linux
@@ -81,7 +81,7 @@
     template:
       src: "{{ item.src }}.j2"
       dest: "/etc/systemd/network/{{ item.dst }}"
-      mode: 0644
+      mode: "0644"
     with_items:
     - {src: coreos-device-macvlan.cfg, dst: macvlan.netdev }
     - {src: coreos-interface-macvlan.cfg, dst: output.network }
@@ -92,13 +92,13 @@
   template:
     src: 10-macvlan.conf.j2
     dest: /etc/cni/net.d/10-macvlan.conf
-    mode: 0644
+    mode: "0644"
 
 - name: Macvlan | Install loopback definition for Macvlan
   template:
     src: 99-loopback.conf.j2
     dest: /etc/cni/net.d/99-loopback.conf
-    mode: 0644
+    mode: "0644"
 
 - name: Enable net.ipv4.conf.all.arp_notify in sysctl
   ansible.posix.sysctl:

roles/network_plugin/multus/tasks/main.yml

@@ -3,7 +3,7 @@
   copy:
     src: "{{ item.file }}"
     dest: "{{ kube_config_dir }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: multus-crd, file: multus-crd.yml, type: customresourcedefinition}
     - {name: multus-serviceaccount, file: multus-serviceaccount.yml, type: serviceaccount}
@@ -20,7 +20,7 @@
   template:
     src: multus-daemonset.yml.j2
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: multus-daemonset-containerd, file: multus-daemonset-containerd.yml, type: daemonset, engine: containerd }
     - {name: multus-daemonset-docker, file: multus-daemonset-docker.yml, type: daemonset, engine: docker }

roles/network_plugin/ovn4nfv/tasks/main.yml

@@ -9,7 +9,7 @@
   template:
     src: "{{ item.file }}.j2"
     dest: "{{ kube_config_dir }}/{{ item.file }}"
-    mode: 0644
+    mode: "0644"
   with_items:
     - {name: ovn-daemonset, file: ovn-daemonset.yml}
     - {name: ovn4nfv-k8s-plugin, file: ovn4nfv-k8s-plugin.yml}

roles/network_plugin/weave/tasks/main.yml

@@ -3,10 +3,10 @@
   template:
     src: weave-net.yml.j2
     dest: "{{ kube_config_dir }}/weave-net.yml"
-    mode: 0644
+    mode: "0644"
 
 - name: Weave | Fix nodePort for Weave
   template:
     src: 10-weave.conflist.j2
     dest: /etc/cni/net.d/10-weave.conflist
-    mode: 0644
+    mode: "0644"