project: fix var-spacing ansible rule (#10266)

* project: fix var-spacing ansible rule

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix spacing on the beginning/end of jinja template

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix spacing of default filter

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix spacing between filter arguments

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix double space at beginning/end of jinja

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

* project: fix remaining jinja[spacing] ansible-lint warning

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

---------

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@proton.ch>

roles/kubernetes-apps/ansible/defaults/main.yml

@@ -6,10 +6,10 @@
 dns_memory_limit: 300Mi
 dns_cpu_requests: 100m
 dns_memory_requests: 70Mi
-dns_min_replicas: "{{ [ 2, groups['k8s_cluster'] | length ] | min }}"
+dns_min_replicas: "{{ [2, groups['k8s_cluster'] | length] | min }}"
 dns_nodes_per_replica: 16
 dns_cores_per_replica: 256
-dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas|int > 1 else 'false' }}"
+dns_prevent_single_point_failure: "{{ 'true' if dns_min_replicas | int > 1 else 'false' }}"
 enable_coredns_reverse_dns_lookups: true
 coredns_ordinal_suffix: ""
 # dns_extra_tolerations: [{effect: NoSchedule, operator: "Exists"}]

roles/kubernetes-apps/ansible/tasks/nodelocaldns.yml

@@ -1,6 +1,7 @@
 ---
 - name: Kubernetes Apps | set up necessary nodelocaldns parameters
   set_fact:
+    # noqa: jinja[spacing]
     primaryClusterIP: >-
       {%- if dns_mode in ['coredns', 'coredns_dual'] -%}
       {{ skydns_server }}
@@ -26,6 +27,7 @@
     - { name: nodelocaldns, file: nodelocaldns-daemonset.yml, type: daemonset }
   register: nodelocaldns_manifests
   vars:
+    # noqa: jinja[spacing]
     forwardTarget: >-
       {%- if secondaryclusterIP is defined and dns_mode == 'coredns_dual' -%}
       {{ primaryClusterIP }} {{ secondaryclusterIP }}
@@ -33,8 +35,8 @@
       {{ primaryClusterIP }}
       {%- endif -%}
     upstreamForwardTarget: >-
-      {%- if upstream_dns_servers is defined and upstream_dns_servers|length > 0 -%}
-      {{ upstream_dns_servers|join(' ') }}
+      {%- if upstream_dns_servers is defined and upstream_dns_servers | length > 0 -%}
+      {{ upstream_dns_servers | join(' ') }}
       {%- else -%}
       /etc/resolv.conf
       {%- endif -%}
@@ -54,15 +56,17 @@
     - { name: nodelocaldns, file: nodelocaldns-second-daemonset.yml, type: daemonset }
   register: nodelocaldns_second_manifests
   vars:
+    # noqa: jinja[spacing]
     forwardTarget: >-
       {%- if secondaryclusterIP is defined and dns_mode == 'coredns_dual' -%}
       {{ primaryClusterIP }} {{ secondaryclusterIP }}
       {%- else -%}
       {{ primaryClusterIP }}
       {%- endif -%}
+    # noqa: jinja[spacing]
     upstreamForwardTarget: >-
-      {%- if upstream_dns_servers is defined and upstream_dns_servers|length > 0 -%}
-      {{ upstream_dns_servers|join(' ') }}
+      {%- if upstream_dns_servers is defined and upstream_dns_servers | length > 0 -%}
+      {{ upstream_dns_servers | join(' ') }}
       {%- else -%}
       /etc/resolv.conf
       {%- endif -%}

roles/kubernetes-apps/ansible/templates/coredns-config.yml.j2

@@ -8,12 +8,12 @@ metadata:
       addonmanager.kubernetes.io/mode: EnsureExists
 data:
   Corefile: |
-{% if coredns_external_zones is defined and coredns_external_zones|length > 0 %}
+{% if coredns_external_zones is defined and coredns_external_zones | length > 0 %}
 {%   for block in coredns_external_zones %}
     {{ block['zones'] | join(' ') }} {
         log
         errors
-{% if block['rewrite'] is defined and block['rewrite']|length > 0 %}
+{% if block['rewrite'] is defined and block['rewrite'] | length > 0 %}
 {% for rewrite_match in block['rewrite'] %}
         rewrite {{ rewrite_match }}
 {% endfor %}
@@ -57,7 +57,7 @@ data:
 {% endif %}
         }
         prometheus :9153
-        forward . {{ upstream_dns_servers|join(' ') if upstream_dns_servers is defined and upstream_dns_servers|length > 0 else '/etc/resolv.conf' }} {
+        forward . {{ upstream_dns_servers | join(' ') if upstream_dns_servers is defined and upstream_dns_servers | length > 0 else '/etc/resolv.conf' }} {
           prefer_udp
           max_concurrent 1000
 {% if dns_upstream_forward_extra_opts is defined %}

roles/kubernetes-apps/ansible/templates/dns-autoscaler.yml.j2

@@ -32,7 +32,7 @@ spec:
       annotations:
     spec:
       nodeSelector:
-        {{ dns_autoscaler_deployment_nodeselector}}
+        {{ dns_autoscaler_deployment_nodeselector }}
       priorityClassName: system-cluster-critical
       securityContext:
         seccompProfile:

roles/kubernetes-apps/ansible/templates/netchecker-agent-ds.yml.j2

@@ -15,7 +15,7 @@ spec:
       labels:
         app: netchecker-agent
     spec:
-      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-node-critical{% else %}k8s-cluster-critical{% endif %}{{''}}
+      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-node-critical{% else %}k8s-cluster-critical{% endif %}{{ '' }}
       tolerations:
         - effect: NoSchedule
           operator: Exists

roles/kubernetes-apps/ansible/templates/netchecker-agent-hostnet-ds.yml.j2

@@ -19,7 +19,7 @@ spec:
       dnsPolicy: ClusterFirstWithHostNet
       nodeSelector:
         kubernetes.io/os: linux
-      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-node-critical{% else %}k8s-cluster-critical{% endif %}{{''}}
+      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-node-critical{% else %}k8s-cluster-critical{% endif %}{{ '' }}
       tolerations:
         - effect: NoSchedule
           operator: Exists

roles/kubernetes-apps/ansible/templates/netchecker-server-deployment.yml.j2

@@ -16,7 +16,7 @@ spec:
       labels:
         app: netchecker-server
     spec:
-      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-cluster-critical{% else %}k8s-cluster-critical{% endif %}{{''}}
+      priorityClassName: {% if netcheck_namespace == 'kube-system' %}system-cluster-critical{% else %}k8s-cluster-critical{% endif %}{{ '' }}
       volumes:
         - name: etcd-data
           emptyDir: {}

roles/kubernetes-apps/ansible/templates/nodelocaldns-config.yml.j2

@@ -8,13 +8,13 @@ metadata:
 
 data:
   Corefile: |
-{% if nodelocaldns_external_zones is defined and nodelocaldns_external_zones|length > 0 %}
+{% if nodelocaldns_external_zones is defined and nodelocaldns_external_zones | length > 0 %}
 {% for block in nodelocaldns_external_zones %}
     {{ block['zones'] | join(' ') }} {
         errors
         cache {{ block['cache'] | default(30) }}
         reload
-{% if block['rewrite'] is defined and block['rewrite']|length > 0 %}
+{% if block['rewrite'] is defined and block['rewrite'] | length > 0 %}
 {% for rewrite_match in block['rewrite'] %}
         rewrite {{ rewrite_match }}
 {% endfor %}
@@ -95,7 +95,7 @@ data:
     }
 {% if enable_nodelocaldns_secondary %}
   Corefile-second: |
-{% if nodelocaldns_external_zones is defined and nodelocaldns_external_zones|length > 0 %}
+{% if nodelocaldns_external_zones is defined and nodelocaldns_external_zones | length > 0 %}
 {% for block in nodelocaldns_external_zones %}
     {{ block['zones'] | join(' ') }} {
         errors