Rename ansible groups to use _ instead of - (#7552)

* rename ansible groups to use _ instead of -

k8s-cluster -> k8s_cluster
k8s-node -> k8s_node
calico-rr -> calico_rr
no-floating -> no_floating

Note: kube-node,k8s-cluster groups in upgrade CI
      need clean-up after v2.16 is tagged

* ensure old groups are mapped to the new ones

roles/kubernetes/preinstall/tasks/0020-verify-settings.yml

@@ -1,10 +1,10 @@
 ---
-- name: Stop if either kube_control_plane or kube-node group is empty
+- name: Stop if either kube_control_plane or kube_node group is empty
   assert:
     that: "groups.get('{{ item }}')"
   with_items:
     - kube_control_plane
-    - kube-node
+    - kube_node
   run_once: true
   when: not ignore_assert_errors
 
@@ -86,7 +86,7 @@
     that: ansible_memtotal_mb >= minimal_node_memory_mb
   when:
     - not ignore_assert_errors
-    - inventory_hostname in groups['kube-node']
+    - inventory_hostname in groups['kube_node']
 
 # This assertion will fail on the safe side: One can indeed schedule more pods
 # on a node than the CIDR-range has space for when additional pods use the host
@@ -99,7 +99,7 @@
     msg: "Do not schedule more pods on a node than inet addresses are available."
   when:
     - not ignore_assert_errors
-    - inventory_hostname in groups['k8s-cluster']
+    - inventory_hostname in groups['k8s_cluster']
     - kube_network_node_prefix is defined
     - kube_network_plugin != 'calico'
 
@@ -207,14 +207,14 @@
     - inventory_hostname == groups['kube_control_plane'][0]
   run_once: yes
 
-- name: "Check that calico_rr nodes are in k8s-cluster group"
+- name: "Check that calico_rr nodes are in k8s_cluster group"
   assert:
     that:
-      - '"k8s-cluster" in group_names'
-    msg: "calico-rr must be a child group of k8s-cluster group"
+      - '"k8s_cluster" in group_names'
+    msg: "calico_rr must be a child group of k8s_cluster group"
   when:
     - kube_network_plugin == 'calico'
-    - '"calico-rr" in group_names'
+    - '"calico_rr" in group_names'
 
 - name: "Check that kube_service_addresses is a network range"
   assert:

roles/kubernetes/preinstall/tasks/0050-create_directories.yml

@@ -4,7 +4,7 @@
     path: "{{ item }}"
     state: directory
     owner: kube
-  when: inventory_hostname in groups['k8s-cluster']
+  when: inventory_hostname in groups['k8s_cluster']
   become: true
   tags:
     - kubelet
@@ -28,7 +28,7 @@
     path: "{{ item }}"
     state: directory
     owner: root
-  when: inventory_hostname in groups['k8s-cluster']
+  when: inventory_hostname in groups['k8s_cluster']
   become: true
   tags:
     - kubelet
@@ -51,7 +51,7 @@
     get_mime: no
   register: kube_cert_compat_dir_check
   when:
-    - inventory_hostname in groups['k8s-cluster']
+    - inventory_hostname in groups['k8s_cluster']
     - kube_cert_dir != kube_cert_compat_dir
 
 - name: Create kubernetes kubeadm compat cert dir (kubernetes/kubeadm issue 1498)
@@ -60,7 +60,7 @@
     dest: "{{ kube_cert_compat_dir }}"
     state: link
   when:
-    - inventory_hostname in groups['k8s-cluster']
+    - inventory_hostname in groups['k8s_cluster']
     - kube_cert_dir != kube_cert_compat_dir
     - not kube_cert_compat_dir_check.stat.exists
 
@@ -75,7 +75,7 @@
     - "/var/lib/calico"
   when:
     - kube_network_plugin in ["calico", "weave", "canal", "flannel", "cilium", "kube-ovn", "ovn4nfv", "kube-router", "macvlan"]
-    - inventory_hostname in groups['k8s-cluster']
+    - inventory_hostname in groups['k8s_cluster']
   tags:
     - network
     - cilium
@@ -96,7 +96,7 @@
     mode: "{{ local_volume_provisioner_directory_mode }}"
   with_items: "{{ local_volume_provisioner_storage_classes.keys() | list }}"
   when:
-    - inventory_hostname in groups['k8s-cluster']
+    - inventory_hostname in groups['k8s_cluster']
     - local_volume_provisioner_enabled
   tags:
     - persistent_volumes

roles/kubernetes/preinstall/tasks/0090-etchosts.yml

@@ -2,7 +2,7 @@
 - name: Hosts | create list from inventory
   set_fact:
     etc_hosts_inventory_block: |-
-      {% for item in (groups['k8s-cluster'] + groups['etcd']|default([]) + groups['calico-rr']|default([]))|unique -%}
+      {% for item in (groups['k8s_cluster'] + groups['etcd']|default([]) + groups['calico_rr']|default([]))|unique -%}
       {% if 'access_ip' in hostvars[item] or 'ip' in hostvars[item] or 'ansible_default_ipv4' in hostvars[item] -%}
       {{ hostvars[item]['access_ip'] | default(hostvars[item]['ip'] | default(hostvars[item]['ansible_default_ipv4']['address'])) }}
       {%- if ('ansible_hostname' in hostvars[item] and item != hostvars[item]['ansible_hostname']) %} {{ hostvars[item]['ansible_hostname'] }}.{{ dns_domain }} {{ hostvars[item]['ansible_hostname'] }}{% endif %} {{ item }}.{{ dns_domain }} {{ item }}