Fix ansible-lint E305 (#6459)

tests/cloud_playbooks/roles/packet-ci/tasks/delete-vms.yml

@@ -16,8 +16,8 @@
     state: absent
     name: "{{ test_name }}"
 
-- name: Wait for namespace {{ test_name }} to be fully deleted  # noqa 305
-  shell: kubectl get ns {{ test_name }}
+- name: Wait for namespace {{ test_name }} to be fully deleted
+  command: kubectl get ns {{ test_name }}
   register: delete_namespace
   failed_when:
     - delete_namespace.rc == 0

tests/testcases/030_check-network.yml

@@ -89,8 +89,8 @@
     - item in pods_running
     with_items: "{{ pod_ips }}"
 
-  - name: Ping between pods is working  # noqa 305
-    shell: "{{ bin_dir }}/kubectl -n test exec {{ item[0] }} -- ping -c 4 {{ item[1] }}"
+  - name: Ping between pods is working
+    command: "{{ bin_dir }}/kubectl -n test exec {{ item[0] }} -- ping -c 4 {{ item[1] }}"
     when:
     - not item[0] in pods_hostnet
     - not item[1] in pods_hostnet
@@ -98,8 +98,8 @@
     - "{{ pod_names }}"
     - "{{ pod_ips }}"
 
-  - name: Ping between hostnet pods is working  # noqa 305
-    shell: "{{ bin_dir }}/kubectl -n test exec {{ item[0] }} -- ping -c 4 {{ item[1] }}"
+  - name: Ping between hostnet pods is working
+    command: "{{ bin_dir }}/kubectl -n test exec {{ item[0] }} -- ping -c 4 {{ item[1] }}"
     when:
     - item[0] in pods_hostnet
     - item[1] in pods_hostnet

tests/testcases/040_check-network-adv.yml

@@ -14,8 +14,8 @@
     netchecker_port: 31081
 
   tasks:
-    - name: Flannel | Disable tx and rx offloading on VXLAN interfaces (see https://github.com/coreos/flannel/pull/1282)  # noqa 305
-      shell: "ethtool --offload flannel.1 rx off tx off"
+    - name: Flannel | Disable tx and rx offloading on VXLAN interfaces (see https://github.com/coreos/flannel/pull/1282)
+      command: "ethtool --offload flannel.1 rx off tx off"
       ignore_errors: true
       when:
         - kube_network_plugin|default('calico') == 'flannel'
@@ -214,8 +214,8 @@
         - inventory_hostname == groups['kube-master'][0]
         - kube_network_plugin_multus|default(false)|bool
 
-    - name: Check secondary macvlan interface  # noqa 305
-      shell: "{{ bin_dir }}/kubectl exec samplepod -- ip addr show dev net1"
+    - name: Check secondary macvlan interface
+      command: "{{ bin_dir }}/kubectl exec samplepod -- ip addr show dev net1"
       register: output
       until: output.rc == 0
       retries: 90

tests/testcases/roles/cluster-dump/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
-- name: Generate dump folder  # noqa 305
-  shell: "{{ bin_dir }}/kubectl cluster-info dump --all-namespaces --output-directory /tmp/cluster-dump"
+- name: Generate dump folder
+  command: "{{ bin_dir }}/kubectl cluster-info dump --all-namespaces --output-directory /tmp/cluster-dump"
   no_log: true
   when: inventory_hostname in groups['kube-master']